Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rejecting Wallet Connect requests and sessions #20288

Closed
3 tasks
clauxx opened this issue May 31, 2024 · 2 comments · Fixed by #20649
Closed
3 tasks

Rejecting Wallet Connect requests and sessions #20288

clauxx opened this issue May 31, 2024 · 2 comments · Fixed by #20649
Assignees
@shivekkhurana
Labels
dapp-interactions-team feature feature requests wallet-connect: Integration Focusing on integrating the WC functionality and UX flows based on descoped designs
Milestone
2.30.0 Beta

Comments

@clauxx
Copy link
Member

clauxx commented May 31, 2024

Feature Issue

User Story

As a user, I would like to be able to reject a session/request, so that the dapp is aware of the interaction state and the user can continue using it.

Description

Acceptance Criteria

  • the session/request should be rejected when the user presses the x button in the navigation header
  • the session/request should be ignored when the user dismisses the sheet by dragging it down
  • the dapp should show the rejected state when the user rejects the session

Notes
@clauxx clauxx added dapp-interactions-team wallet-connect: Integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature feature requests labels May 31, 2024
@clauxx clauxx added this to the 2.30.0 Beta milestone May 31, 2024
@xAlisher
Copy link

xAlisher commented Jun 3, 2024

Just for reference

image

@clauxx clauxx added wallet-connect: UI Adding missing UI on top of the existing functionality and polishing it based on the descopeddesings E:Mobile Wallet Release 1.27 wallet-connect: Integration Focusing on integrating the WC functionality and UX flows based on descoped designs and removed wallet-connect: Integration Focusing on integrating the WC functionality and UX flows based on descoped designs wallet-connect: UI Adding missing UI on top of the existing functionality and polishing it based on the descopeddesings E:Mobile Wallet Release 1.27 labels Jun 3, 2024
@shivekkhurana
Copy link
Contributor

There are two aspects to feature:

  1. Rejecting requests as shown in Alisher's comment and
  2. Rejecting session proposals

@shivekkhurana shivekkhurana mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivekkhurana shivekkhurana

Labels
dapp-interactions-team feature feature requests wallet-connect: Integration Focusing on integrating the WC functionality and UX flows based on descoped designs
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

🙅 Gracefully reject proposals and requests status-im/status-mobile
3 participants
@shivekkhurana @xAlisher @clauxx