Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved ENS address is not checksummed #8121

Closed
churik opened this issue May 3, 2019 · 4 comments · Fixed by #8146
Closed

Resolved ENS address is not checksummed #8121

churik opened this issue May 3, 2019 · 4 comments · Fixed by #8146

Comments

@churik
Copy link
Member

churik commented May 3, 2019

Description

Type: Bug
Summary: when pasting valid ENS name as a recipient, get Error in address: <address> when tapping on Done

Expected behavior

address is resolved

Actual behavior

photo!UNITO-UNDERSCORE!2019-05-03 12 34 15

Reproduction

  • Open Status
  • Restore account with ETH
  • Go to wallet > Send transaction
  • In "Choose recipient" select "Enter recipient address"
  • Enter valid ENS name (tried with several, i.e. nastya.stateofus.eth

Additional Information

  • Status version: nightly 03/05/2019 (issue is not presented in nightly 02/05/2019
  • Operating System: Android, iOS
@asemiankevich
Copy link
Contributor

asemiankevich commented May 3, 2019

i believe it is not wallet problem, since wallet received address resolved from ens usernames contract. We need to update ENS contract here to send checksummed addresses when resolved.
@richard-ramos please take a look
or @3esmit :)

@asemiankevich asemiankevich changed the title Error in address at attempt to set valid ENS name as a recipient Resolved ENS address is not checksummed May 3, 2019
@asemiankevich asemiankevich added feature feature requests and removed bug labels May 3, 2019
@richard-ramos
Copy link
Member

Hi @asemiankevich .
The resolver is working as it should. You can check this on etherscan for the resolver used by status ens domain:
https://etherscan.io/address/0x5ffc014343cd971b7eb70732021e26c35b744cc4#readContract
If you go to the form "4. addr" and paste the value: 0x371decdaf7c88ef7881bcc3ecb2f08e4e9b2436c29b9ace2770ff5f6d90e06a8 which is the hash representation of nastya.stateofus.eth, it will resolve to the wallet address: 0x58d8c3d70ce4fa4b9fb10a665c8712238746f2ff.

If the issue is related to the checksum, in the wallet you can use: web3.utils.toChecksumAddress(WALLET_ADDRESS_HERE) to format it correctly, since the contract does not and needs not to handle this.

@asemiankevich
Copy link
Contributor

ah okay then it is still wallet , thank you for clarifying !

@asemiankevich asemiankevich assigned flexsurfer and unassigned 3esmit May 3, 2019
@asemiankevich asemiankevich added wallet and removed feature feature requests labels May 3, 2019
@flexsurfer flexsurfer removed their assignment May 6, 2019
@3esmit
Copy link
Member

3esmit commented May 6, 2019

seems like there is an empty space at the beginning?
If all chars are lowercase, or all chars are uppercase, than checksum should not be tested, it should only test the checksum if some are uppercase, and other lowercase.

@flexsurfer flexsurfer self-assigned this May 6, 2019
flexsurfer added a commit that referenced this issue May 8, 2019
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants