Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP681 value, chain_id, gasLimit and gasPrice are not supported #8150

Closed
churik opened this issue May 8, 2019 · 2 comments · Fixed by #10280
Closed

EIP681 value, chain_id, gasLimit and gasPrice are not supported #8150

churik opened this issue May 8, 2019 · 2 comments · Fixed by #10280
Labels
feature feature requests
Projects

Comments

@churik
Copy link
Member

churik commented May 8, 2019

Description

Type: Bug
Summary: Some of the parameters mentioned in EIP681 spec are not supported in Status app.

  1. Links without function_name are not resolved, i.e. ethereum:0xfb6916095ca1df60bb79Ce92ce3ea74c37c5d359?value=2.014e18 so when scanning URL with this link, got an error

Monosnap 2019-05-01 11-19-13

So I didn't find a way to check `value` for ETH
  1. If using ERC20 tokens as parameters, value is not resolved, i.e. after scanning ethereum:0x744d70fdbe2ba4cf95131626614a1763df805b9e/transfer?address=0x8e23ee67d1332ad560396262c48ffbb01f93d052&uint256=1 should sent 1 SNT as far as I understand.
    In fact after scanning QR with link I've got:
    photo_2019-05-01 11 27 14

So the asset was changed to tokens, but the value is not displayed.

  1. Parameters gasLimit and gasPrice are not resolved (i.e. in ethereum:0x744d70fdbe2ba4cf95131626614a1763df805b9e/transfer?address=0x8e23ee67d1332ad560396262c48ffbb01f93d052&value=1&gasLimit=100&gasPrice=1
    However gas is resolved, as it mentioned in spec

  2. chain_id is not resolved
    atattempt to scan ethereum:0x9810fc231ca9dabe30da595763a7b81a215aaceb/transfer?chain_id=3&address=0x8e23ee67d1332ad560396262c48ffbb01f93d052&value=1 on Ropsten got an error:

Expected behavior

all paramters are pasted on "Send transaction" screen

Actual behavior

mentioned in description

Reproduction

  • Make valid links according to EIP681 spec

  • Make a QR with any QR code genarator

  • Open Status

  • Tap on + > Scan QR

  • Status version: nightly 08/05/2019
    [comment]: # (Android or iOS.)

  • Operating System: Android, iOS

@churik churik added the bug label May 8, 2019
@annadanchenko annadanchenko added feature feature requests and removed bug labels May 9, 2019
@annadanchenko annadanchenko added this to To do (P0) in Core via automation May 9, 2019
@annadanchenko annadanchenko moved this from To do (P0) to Backlog in Core May 9, 2019
@rachelhamlin
Copy link
Contributor

Relabeling this feature because it's about completing the implementation of EIP681, not a problem with the portion we have complete.

@rachelhamlin rachelhamlin moved this from To Do - P0 to To Do - P1 in Core Oct 17, 2019
@rachelhamlin rachelhamlin moved this from To Do - P1 to To Do - P2 in Core Oct 17, 2019
@churik
Copy link
Member Author

churik commented Jan 7, 2020

value is still not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
Core
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants