[Fixes #7325] Add EIP681 deeplink support #8004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (26)
|
goranjovic
approved these changes
Apr 19, 2019
flexsurfer
approved these changes
Apr 22, 2019
rasom
approved these changes
Apr 25, 2019
|
@jeluard please, rebase to current |
|
@churik Done! |
100% of end-end tests have passedPassed tests (48)Click to expand
|
yenda
approved these changes
Apr 30, 2019
Pull Request Checklist
|
|
@jeluard Please, elaborate:
I tested the following scenarios using "Scan QR" on home screen (generating them using https://www.qr-code-generator.com/ > Text) or via Wallet > Send > Scan QR (result is that same)
So the asset was changed to tokens, but the value is not displayed.
|
33% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (1) |
|
@jeluard please, rebase PR to current Also some notes:
|
|
@churik Done |
|
@jeluard any comments on #8004 (comment)? |
|
@churik Sorry missed that comment!
|
jeluard
force-pushed
the
7325
branch
2 times, most recently
from
9f2adab
to
3ff08f8
Compare
|
@churik 1) should be fixed, with the caveat that onboarding will loose the wallet details. User would have to click a second time on the deep link. |
96% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (46)Click to expand
|
96% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (46)Click to expand
|
|
Created #8150 |
0% of end-end tests have passedFailed tests (1)Click to expand
|
|
|
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7325
Summary
Added EIP681 deep link support.
NOTE to testers EIP681 clicked in mobile stock browser should open status / send screen.
status: ready