Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error scrollToIndex when tapping [Fetch messages] twice in a row #8797

Closed
asemiankevich opened this issue Aug 21, 2019 · 1 comment · Fixed by #10009
Closed

Error scrollToIndex when tapping [Fetch messages] twice in a row #8797

asemiankevich opened this issue Aug 21, 2019 · 1 comment · Fixed by #10009
Labels
medium-priority medium-severity
Projects
Core

Comments

@asemiankevich
Copy link
Contributor

Problem

Error scrollToIndex should be used in conjunction with getItemLayout or on-ScrollToIndexFailed, otherwise there is no way to know the location of offscreen indicies or handle failures

image

Steps

  1. create new account
  2. join test-team public chat
  3. tap Fetch previous messages twice in a row before messages appear
@flexsurfer flexsurfer added this to To Do - P0 in Core via automation Feb 8, 2020
@flexsurfer
Copy link
Member

cc @rachelhamlin users report this issue in v1

flexsurfer added a commit that referenced this issue Feb 10, 2020
@flexsurfer
[#8797] Error scrollToIndex when tapping [Fetch messages] twice in a row
4b450b9
@flexsurfer flexsurfer mentioned this issue Feb 10, 2020
Merged
flexsurfer added a commit that referenced this issue Feb 10, 2020
@flexsurfer
[#8797] Error scrollToIndex when tapping [Fetch messages] twice in a row
27ea4bf 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
flexsurfer added a commit that referenced this issue Feb 10, 2020
@flexsurfer
[#8797] Error scrollToIndex when tapping [Fetch messages] twice in a row
481092d 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Core automation moved this from To Do - P0 to Done Feb 10, 2020
flexsurfer added a commit that referenced this issue Feb 10, 2020
@flexsurfer
[#8797] Error scrollToIndex when tapping [Fetch messages] twice in a row
4c95da3 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
medium-priority medium-severity
Projects
Core
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#8797] Error scrollToIndex when tapping [Fetch messages] twice in a row status-im/status-mobile
2 participants
@flexsurfer @asemiankevich