add factory reset option on new Keycard account #12055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (24)
|
bitgamma
changed the title
| (js->clj :keywordize-keys true) | ||
| (update :key-uid ethereum/normalized-hex))] | ||
| (on-success info)))) | ||
| (catch on-failure))) |
There was a problem hiding this comment.
Does catch work without a try block?
There was a problem hiding this comment.
Yes the same pattern is used throughout the file and the error handlers are known to work. I would leave it like this for consistency. Thanks for the review!
shivekkhurana
approved these changes
May 4, 2021
99% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (79)Click to expand
|
|
@bitgamma thank you, works great! One minor remark: The checkbox IMG_0584.mp4 |
5 tasks
|
@qoqobolo thanks for catching this! it is fixed now |
100% of end-end tests have passedPassed tests (1)Click to expand
|
bitgamma
force-pushed
the
feature/keycard-factory-reset
branch
2 times, most recently
from
31f92fd
to
b32d784
Compare
|
@bitgamma thanks for the fix! Two sporadically reproducing issues were found in develop. One of them is related to the scenario of this PR but can be reproduced in another flow as well. I will log them separately. |
Signed-off-by: Michele Balistreri <michele@bitgamma.com>
bitgamma
force-pushed
the
feature/keycard-factory-reset
branch
from
b32d784
to
0b85099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the ability to factory reset the Keycard during account creation and mnemonic import.
Factory reset reinstalls the Keycard applet. The package, NDEF applet and Cash applet are untouched. This makes resetting the card quite fast and does not require to load a cap file.
The card can be in any state (non-initialized, initialized, loaded with keys) before the reset and will always be non-initialized after.