Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the PUK and pairing screen from Keycard onboarding #12155

Merged
merged 1 commit into from
May 27, 2021
Merged

remove the PUK and pairing screen from Keycard onboarding #12155

merged 1 commit into from
May 27, 2021

Conversation

bitgamma
Copy link
Member

@bitgamma bitgamma commented May 26, 2021 •
edited

fixes #12083.

Since this removes a screen from the onboarding, E2E tests have been adapted too.

Another affected component is the "Begin setup" screen, which used to have bullet points with the steps to do. Since unless you are creating a new account a single bullet-point would remain, as discussed with @guylouis, the bullet points were replaced with text. The pairing screen also doesn't claim that the pairing code was shown during onboarding anymore.

attached are screenshots for localization. The enter-pair-code-description is an already existing key which has been modified so localization will need to be updated accordingly.

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 26, 2021
@status-im-auto
Copy link
Member

status-im-auto commented May 26, 2021 •
edited

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ c4f5f17 #1 2021-05-26 09:57:38 ~13 min android 📦apk 📲
✖️ c4f5f17 #1 2021-05-26 09:58:08 ~13 min android-e2e 📦apk 📲
✖️ c4f5f17 #1 2021-05-26 10:01:59 ~17 min ios 📦ipa 📲
✔️ 7f74a94 #2 2021-05-26 10:14:30 ~15 min ios 📦ipa 📲
✔️ 7f74a94 #2 2021-05-26 10:14:52 ~15 min android-e2e 📦apk 📲
✔️ 7f74a94 #2 2021-05-26 10:15:35 ~16 min android 📦apk 📲
✔️ c653d65 #3 2021-05-26 12:22:55 ~13 min ios 📦ipa 📲
✔️ c653d65 #3 2021-05-26 12:26:10 ~17 min android 📦apk 📲
✔️ c653d65 #3 2021-05-26 12:26:17 ~17 min android-e2e 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6322b09 #4 2021-05-27 06:38:58 ~13 min ios 📦ipa 📲
✔️ 6322b09 #4 2021-05-27 06:41:23 ~16 min android 📦apk 📲
✔️ 6322b09 #4 2021-05-27 06:41:24 ~16 min android-e2e 📦apk 📲
✔️ a962485 #5 2021-05-27 11:11:32 ~10 min android 📦apk 📲
✔️ a962485 #5 2021-05-27 11:16:07 ~14 min android-e2e 📦apk 📲
✔️ a962485 #5 2021-05-27 11:23:26 ~21 min ios 📦ipa 📲

@guylouis
Copy link
Contributor

@bitgamma indeed I think the text is ok

@bitgamma bitgamma moved this from REVIEW to E2E Tests in Pipeline for QA May 26, 2021
@status-im-auto
Copy link
Member

74% of end-end tests have passed

Total executed tests: 70
Failed tests: 18
Passed tests: 52

IDs of failed tests: 6291,6210,5314,5689,5412,5350,6328,6251,5758,6645,6289,5308,6228,6208,6249,6240,6293,6290

Failed tests (18)

Click to expand
  • Rerun tests

    • 1. test_keycard_can_see_all_transactions_in_history, id: 6291

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    2. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//*[@text="Continue anyway"]`

    Device 1: Button by xpath: `//*[@text="Continue anyway"]` is not found on the screen

    Device sessions

    3. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314

    Device 1: *Tap on found TransactionHistoryButton*
    Device 1: *Pull to refresh view*

    Device 1: TransactionElement by xpath:`//android.view.ViewGroup[@content-desc="transaction-item"]` is not found on the screen

    Device sessions

    4. test_keycard_create_login_resotore_unlock_same_seed, id: 5689

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    5. test_insufficient_funds_wallet_positive_balance, id: 5412

    Device 1: *Getting STT amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen

    Device sessions

    6. test_send_token_with_7_decimals, id: 5350

    Device 1: *Click until Button by accessibility id:*`choose-asset-button` *is presented*
    Device 1: Button element not found

    Device 1: ADIAssetButton by xpath: `(//*[@content-desc=':ADI-asset-value'])[1]` is not found on the screen

    Device sessions

    7. test_send_transaction_set_recipient_options, id: 6328

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//*[@text="↓ 1000 MDS"]`

    Device 1: Button by xpath: `//*[@text="↓ 1000 MDS"]` is not found on the screen

    Device sessions

    8. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    9. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

    Device 1: **Enter default pin 121212**
    Device 1: **Signed in successfully!**

    ETH value is not restored

    Device sessions

    10. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    11. test_keycard_send_eth_from_wallet_to_address, id: 6289

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    12. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308

    Device 1: EditBox element not found
    Device 1: *Find EditBox by accessibility id:* `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    13. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: *Find Button by xpath:* `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: *Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    14. test_send_transaction_with_custom_token, id: 6208

    Device 1: *Find Button by xpath:* `//*[@text='OK' or @text='Ok']`
    Device 1: *Tap on found Button*

    Name for custom token was not set Symbol for custom token was not set

    Device sessions

    15. test_keycard_request_stt_from_daap, id: 6249

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    16. test_restore_account_from_mnemonic_to_keycard, id: 6240

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    17. test_keycard_send_eth_in_1_1_chat, id: 6293

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    18. test_keycard_fetching_balance_after_offline, id: 6290

    Device 1: *Find Button by xpath:* `//*[@text="Next"]`
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath:* `//*[@text="Next"]` is not found on the screen

    Device sessions

    Passed tests (52)

    Click to expand

    1. test_sign_message_and_transactions_filters_from_daap, id: 5342
    Device sessions

    2. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    3. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    4. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    5. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    6. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    7. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    8. test_delete_close_all_tabs, id: 5390
    Device sessions

    9. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    10. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    11. test_block_user_from_public_chat, id: 5786
    Device sessions

    12. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    13. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    14. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    15. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    16. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    17. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    18. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    19. test_long_press_to_delete_chat, id: 5319
    Device sessions

    20. test_copy_and_paste_messages, id: 5317
    Device sessions

    21. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    22. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    23. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    24. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    25. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    26. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    27. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    28. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    29. test_manage_assets, id: 5341
    Device sessions

    30. test_browser_managing_bookmarks, id: 6633
    Device sessions

    31. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    32. test_request_stt_from_daap, id: 5309
    Device sessions

    33. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    34. test_dapps_permissions, id: 5738
    Device sessions

    35. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    36. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    37. test_create_new_group_chat_messaging_pn_delived, id: 3994
    Device sessions

    38. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    39. test_wallet_set_up, id: 5335
    Device sessions

    40. test_home_view, id: 5379
    Device sessions

    41. test_can_add_existing_ens, id: 5502
    Device sessions

    42. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    43. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    44. test_set_profile_picture, id: 6646
    Device sessions

    45. test_collectible_from_wallet, id: 5346
    Device sessions

    46. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    47. test_pass_phrase_validation, id: 5363
    Device sessions

    48. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    49. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    50. test_fetching_balance_after_offline, id: 6237
    Device sessions

    51. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    52. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @bitgamma bitgamma requested a review from churik as a code owner May 26, 2021 12:08
    @bitgamma bitgamma moved this from E2E Tests to REVIEW in Pipeline for QA May 26, 2021
    @bitgamma bitgamma moved this from REVIEW to E2E Tests in Pipeline for QA May 26, 2021
    Serhy
    Serhy approved these changes May 26, 2021
    View reviewed changes
    Copy link
    Contributor

    @Serhy Serhy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    👍

    @status-im status-im deleted a comment from status-im-auto May 26, 2021
    @status-im-auto
    Copy link
    Member

    89% of end-end tests have passed

    Total executed tests: 18
Failed tests: 2
Passed tests: 16

    IDs of failed tests: 6210,5758

    Failed tests (2)

    Click to expand
  • Rerun tests

    • 1. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//*[@text="Continue anyway"]`

    Device 1: Button by xpath: `//*[@text="Continue anyway"]` is not found on the screen

    Device sessions

    2. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

    Device 1: *Type '000000' to EditBox*
    Device 1: *Find Button by xpath:* `//*[@text="Pair to this device"]`

    Device 1: Button by xpath: `//*[@text="Pair to this device"]` is not found on the screen

    Device sessions

    Passed tests (16)

    Click to expand

    1. test_send_token_with_7_decimals, id: 5350
    Device sessions

    2. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    3. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    4. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    5. test_keycard_create_login_resotore_unlock_same_seed, id: 5689
    Device sessions

    6. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    7. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    8. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    9. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    10. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    11. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    12. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    13. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    14. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    15. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    16. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 1
Failed tests: 0
Passed tests: 1

    Passed tests (1)

    Click to expand

    1. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    @bitgamma bitgamma changed the title [WIP] remove the PUK and pairing screen from Keycard onboarding remove the PUK and pairing screen from Keycard onboarding May 26, 2021
    @qoqobolo qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA May 26, 2021
    @qoqobolo
    Copy link
    Contributor

    @bitgamma

    ISSUE 1: Text Pairing code was displaying to you during the Keycard setup is shown when recovering a multiaccount on another device using Keycard

    Since this information is no longer relevant, the text in this flow also should be changed.

    Steps:

    1. Open Status
    2. Access existing key
    3. Recover with Keycard

    Screenshot 2021-05-26 at 16 56 14

    @qoqobolo qoqobolo self-assigned this May 26, 2021
    @bitgamma
    Copy link
    Member Author

    @qoqobolo thanks for finding this! I have changed the text to reflect the current behaviour

    @bitgamma
    Copy link
    Member Author

    /cc @jinhojang6

    @qoqobolo
    Copy link
    Contributor

    @bitgamma thank you! PR looks good to me and can be merged.

    @qoqobolo qoqobolo moved this from IN TESTING to MERGE in Pipeline for QA May 27, 2021
    @bitgamma bitgamma force-pushed the feature/onboarding-remove-puk-pairing branch from 6322b09 to a962485 Compare May 27, 2021 11:01
    @bitgamma
    remove puk/pairing step from onboarding
    65d76ba 
    Signed-off-by: Michele Balistreri <michele@bitgamma.com>
    @bitgamma bitgamma force-pushed the feature/onboarding-remove-puk-pairing branch from a962485 to 65d76ba Compare May 27, 2021 11:02
    @bitgamma bitgamma merged commit 65d76ba into develop May 27, 2021
    Pipeline for QA automation moved this from MERGE to DONE May 27, 2021
    @bitgamma bitgamma deleted the feature/onboarding-remove-puk-pairing branch May 27, 2021 11:02
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Serhy Serhy Serhy approved these changes

    @churik churik Awaiting requested review from churik churik is a code owner

    Assignees

    @bitgamma bitgamma

    @qoqobolo qoqobolo

    Labels
    Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    remove PUK and Pairing code from keycard onboarding
    5 participants
    @bitgamma @status-im-auto @guylouis @qoqobolo @Serhy