Sort pinned messages by time of pinning #12402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansztamfater
force-pushed
the
bug/sort-pinned-messages
branch
from
58a9343
to
66cb2bf
Compare
Jenkins BuildsClick to see older builds (9)
|
|
@briansztamfater can we rebase PR please after merging #12411? |
flexsurfer
approved these changes
Aug 9, 2021
briansztamfater
force-pushed
the
bug/sort-pinned-messages
branch
from
66cb2bf
to
4cdd5c2
Compare
|
Rebase done @churik |
|
@briansztamfater thank you, works fine! The only thing is that currently, the newest pinned messages are placed at the bottom of the list. On Desktop they are at the top. Could you change the order accordingly, please? Steps:
|
|
@qoqobolo I can easily change that! Will do and let you know |
|
@briansztamfater just a reminder of this one :) |
|
@qoqobolo sorry for the delay, changes are now done! |
briansztamfater
force-pushed
the
bug/sort-pinned-messages
branch
from
39ea692
to
b1d2ba0
Compare
|
Thank you @briansztamfater! |
Signed-off-by: Brian Sztamfater <brian@status.im>
briansztamfater
force-pushed
the
bug/sort-pinned-messages
branch
from
b1d2ba0
to
0acca32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12290
Summary
This PR adds sorting pinned messages by time of pinning and also removes separation of pinned messages in timeframes
Screenshots
Platforms
Functional
Steps to test
status: ready