Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle multiple calls to frozen-keycard-popup #12473

Merged
merged 1 commit into from
Aug 24, 2021
Merged

handle multiple calls to frozen-keycard-popup #12473

merged 1 commit into from
Aug 24, 2021

Conversation

bitgamma
Copy link
Member

Fixes #12462

@bitgamma bitgamma self-assigned this Aug 23, 2021
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Aug 23, 2021
@rasom rasom moved this from REVIEW to E2E Tests in Pipeline for QA Aug 23, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Aug 23, 2021 •
edited

Jenkins Builds

Click to see older builds (3)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 63de0b1 #1 2021-08-23 10:38:34 ~11 min android-e2e 📦apk 📲
✔️ 63de0b1 #1 2021-08-23 10:38:37 ~11 min android 📦apk 📲
✔️ 63de0b1 #1 2021-08-23 10:45:55 ~18 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ce57652 #2 2021-08-23 12:23:19 ~11 min android 📦apk 📲
✔️ ce57652 #2 2021-08-23 12:25:18 ~13 min android-e2e 📦apk 📲
✔️ ce57652 #2 2021-08-23 12:30:04 ~18 min ios 📦ipa 📲
✔️ 3a0602c #3 2021-08-24 08:28:15 ~11 min android 📦apk 📲
✔️ 3a0602c #3 2021-08-24 08:29:33 ~12 min android-e2e 📦apk 📲
✔️ 3a0602c #3 2021-08-24 08:36:18 ~19 min ios 📦ipa 📲

@churik churik moved this from E2E Tests to IN TESTING in Pipeline for QA Aug 23, 2021
@churik churik self-assigned this Aug 23, 2021
@churik
Copy link
Member

churik commented Aug 23, 2021 •
edited

@bitgamma
Thank you for fix!
Noticed that on reproducing this issue #12462 on IOS apart from "Keycard is frozen" screen can see confusing "Wrong card" popup
Steps are:

  • login with keycard
  • open Profile > Keycard > Change PIN
  • enter wrong PIN 3 times
  • on Frozen keycard popup tap "Dismiss"
  • try to send tx
    The same issue is reproducible on e2e builds, but I don't see it on Android.

Can you please take a look?
IMAGE 2021-08-23 13:33:58

@bitgamma
Copy link
Member Author

@churik thanks for catching this, hadn't tested on iOS. Should be fixed now

@churik
Copy link
Member

churik commented Aug 23, 2021

Can reproduce with same steps on ce57652 commit
IMAGE 2021-08-23 14:41:05

@bitgamma
Copy link
Member Author

@churik only on iOS or e2e build too? I had tested my fix against the e2e build for simplicity. Will have to check on iOS too

@churik
Copy link
Member

churik commented Aug 23, 2021 •
edited

@bitgamma
on IOS it is reproducible with same steps.

on e2e: for me it is reproducible on e2e builds with test test_keycard_frozen_card_flows
Logs: https://app.saucelabs.com/tests/562b4c415cd84ceea4397b56723db935#421
Test steps for e2e:

  • enter wrong PIN 3 times in "Change PIN"
  • Dismiss
  • go back to Profile
  • open Keycard > Change PIN
  • enter wrong PIN again

It appeared on nightly 20/08/21 and may be related to 2a6cb97
It can be separate and not related to this PR, however not sure ( I mean how it will be better to fix it here or separately)

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 71
Failed tests: 3
Passed tests: 68

IDs of failed tests: 5395,5373,6237

Failed tests (3)

Click to expand
  • Rerun tests

    • 1. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)

    Device 1: *Find AllowButton by xpath:* `//*[@text="Allow" or @text="ALLOW"]`
    Device 1: *Find Button by xpath:* `//*[@text="ETH"]`

    Device 1: Button by xpath: `//*[@text="ETH"]` is not found on the screen

    Device sessions

    2. test_send_and_open_links_with_previews, id: 5373

    Device 1: *Tap on found OpenInStatusButton*
    Device 1: *Find Button by xpath:* `//*[@text="Private, Secure Communication"]`

    Device 1: Button by xpath: `//*[@text="Private, Secure Communication"]` is not found on the screen

    Device sessions

    3. test_fetching_balance_after_offline, id: 6237

    Device 1: *Find Button by accessibility id:* `mobile-network-continue-syncing`
    Device 1: *Tap on found Button*

    Device 1: Button by accessibility id:* `conn-button-offline` is still visible on the screen after 300 seconds

    Device sessions

    Passed tests (68)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    12. test_delete_close_all_tabs, id: 5390
    Device sessions

    13. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    14. test_send_token_with_7_decimals, id: 5350
    Device sessions

    15. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    26. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    27. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    30. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    31. test_long_press_to_delete_chat, id: 5319
    Device sessions

    32. test_copy_and_paste_messages, id: 5317
    Device sessions

    33. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    34. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    35. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    36. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    37. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    38. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    39. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    40. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    41. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    42. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    43. test_manage_assets, id: 5341
    Device sessions

    44. test_browser_managing_bookmarks, id: 6633
    Device sessions

    45. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    46. test_request_stt_from_daap, id: 5309
    Device sessions

    47. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    48. test_dapps_permissions, id: 5738
    Device sessions

    49. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    50. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    51. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    52. test_wallet_set_up, id: 5335
    Device sessions

    53. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    54. test_home_view, id: 5379
    Device sessions

    55. test_can_add_existing_ens, id: 5502
    Device sessions

    56. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    57. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    58. test_set_profile_picture, id: 6646
    Device sessions

    59. test_collectible_from_wallet, id: 5346
    Device sessions

    60. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    61. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    62. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    63. test_pass_phrase_validation, id: 5363
    Device sessions

    64. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    65. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    66. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    67. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    68. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    @bitgamma
    Copy link
    Member Author

    @churik as agreed I removed the ineffective fix and will fix that issue separately. Is this PR ready to merge?

    @churik churik moved this from IN TESTING to MERGE in Pipeline for QA Aug 24, 2021
    @churik
    Copy link
    Member

    churik commented Aug 24, 2021 •
    edited

    yes, I'll report remaining separately

    @bitgamma @churik
    handle multiple calls to frozen-keycard-popup
    e3f471e 
    Signed-off-by: Churikova Tetiana <churikova.tm@gmail.com>
    @churik churik merged commit e3f471e into develop Aug 24, 2021
    Pipeline for QA automation moved this from MERGE to DONE Aug 24, 2021
    @churik churik deleted the fix/12462 branch August 24, 2021 08:32
    @churik churik mentioned this pull request Aug 24, 2021
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rasom rasom rasom approved these changes

    Assignees

    @churik churik

    @bitgamma bitgamma

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    App freezes until reopening when signing tx with frozen Keycard
    4 participants
    @bitgamma @status-im-auto @churik @rasom