Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show notifications from self #12505

Merged
merged 1 commit into from
Aug 31, 2021
Merged

don't show notifications from self #12505

merged 1 commit into from
Aug 31, 2021

Conversation

bitgamma
Copy link
Member

Fixes #11550

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Aug 26, 2021
@bitgamma bitgamma self-assigned this Aug 26, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Aug 26, 2021 •
edited

Jenkins Builds

Click to see older builds (3)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ fc62656 #1 2021-08-26 11:30:28 ~13 min android-e2e 📦apk 📲
✖️ fc62656 #1 2021-08-26 11:30:50 ~14 min android 📦apk 📲
✖️ fc62656 #1 2021-08-26 11:35:24 ~18 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7b2c80d #2 2021-08-26 11:44:32 ~11 min android-e2e 📦apk 📲
✔️ 7b2c80d #2 2021-08-26 11:47:16 ~14 min android 📦apk 📲
✔️ 7b2c80d #2 2021-08-26 11:51:58 ~19 min ios 📦ipa 📲
✔️ 7b2c80d #3 2021-08-31 10:07:41 ~22 min ios 📦ipa 📲
✔️ 86b046d #3 2021-08-31 12:21:27 ~14 min android 📦apk 📲
✔️ 86b046d #3 2021-08-31 12:25:54 ~19 min android-e2e 📦apk 📲
✔️ 86b046d #4 2021-08-31 12:27:46 ~21 min ios 📦ipa 📲

@bitgamma bitgamma moved this from REVIEW to E2E Tests in Pipeline for QA Aug 27, 2021
@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 71
Failed tests: 7
Passed tests: 64

IDs of failed tests: 6251,5758,6226,5335,6240,6237,6290

Failed tests (7)

Click to expand
  • Rerun tests

    • 1. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: **Dapp is opened!**
    Device 1: **Wait 10s for assets in simpledapp**

    Device 1: Button by xpath:`//*[@text="Assets"] | //*[@content-desc="Assets"]` is not found on the screen

    Device sessions

    2. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

    Device 1: *Getting LXS amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':LXS-asset-value']//android.widget.TextView[1]` is not found on the screen

    Device sessions

    3. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226

    Device 1: *Type 'statuse2e' to EditBox*
    Device 1: *Click system back button*

    Device 1: Button by xpath: `//*[starts-with(@text,'This user name is owned by you and connected with your chat key.')]` is not found on the screen

    Device sessions

    4. test_wallet_set_up, id: 5335

    Device 1: =========================================================================
    Device 1: *Find SignInPhraseText by xpath:* `//*[@text="This is your signing phrase"]//following-sibling::*[2]/android.widget.TextView`

    Device 1: SignInPhraseText by xpath: `//*[@text="This is your signing phrase"]//following-sibling::*[2]/android.widget.TextView` is not found on the screen

    Device sessions

    5. test_restore_account_from_mnemonic_to_keycard, id: 6240

    Device 1: *Getting ADI amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen

    Device sessions

    6. test_fetching_balance_after_offline, id: 6237

    Device 1: *Find AirplaneModeButton by accessibility id:* `Airplane mode`
    Device 1: *Tap on found AirplaneModeButton*

    Device 1: Button by accessibility id:* `conn-button-offline` is still visible on the screen after 100 seconds

    Device sessions

    7. test_keycard_fetching_balance_after_offline, id: 6290

    Device 1: *Find Button by accessibility id:* `mobile-network-continue-syncing`
    Device 1: *Tap on found Button*

    Device 1: Button by accessibility id:* `conn-button-offline` is still visible on the screen after 300 seconds

    Device sessions

    Passed tests (64)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    12. test_delete_close_all_tabs, id: 5390
    Device sessions

    13. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    14. test_send_token_with_7_decimals, id: 5350
    Device sessions

    15. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    19. test_block_user_from_public_chat, id: 5786
    Device sessions

    20. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    21. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    22. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    23. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    24. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    25. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    26. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    27. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    28. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    29. test_long_press_to_delete_chat, id: 5319
    Device sessions

    30. test_copy_and_paste_messages, id: 5317
    Device sessions

    31. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    32. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    33. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    34. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    35. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    36. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    37. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    38. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    39. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    40. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    41. test_manage_assets, id: 5341
    Device sessions

    42. test_browser_managing_bookmarks, id: 6633
    Device sessions

    43. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    44. test_request_stt_from_daap, id: 5309
    Device sessions

    45. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    46. test_dapps_permissions, id: 5738
    Device sessions

    47. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    48. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    49. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    50. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    51. test_home_view, id: 5379
    Device sessions

    52. test_can_add_existing_ens, id: 5502
    Device sessions

    53. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    54. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    55. test_set_profile_picture, id: 6646
    Device sessions

    56. test_collectible_from_wallet, id: 5346
    Device sessions

    57. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    58. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    59. test_pass_phrase_validation, id: 5363
    Device sessions

    60. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    61. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    62. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    63. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    64. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @status-im-auto
    Copy link
    Member

    71% of end-end tests have passed

    Total executed tests: 7
Failed tests: 2
Passed tests: 5

    IDs of failed tests: 6290,6237

    Failed tests (2)

    Click to expand
  • Rerun tests

    • 1. test_keycard_fetching_balance_after_offline, id: 6290

    Device 1: *Find Button by accessibility id:* `mobile-network-continue-syncing`
    Device 1: *Tap on found Button*

    Device 1: Button by accessibility id:* `conn-button-offline` is still visible on the screen after 300 seconds

    Device sessions

    2. test_fetching_balance_after_offline, id: 6237

    Device 1: *Find AirplaneModeButton by accessibility id:* `Airplane mode`
    Device 1: *Tap on found AirplaneModeButton*

    Device 1: Button by accessibility id:* `conn-button-offline` is still visible on the screen after 100 seconds

    Device sessions

    Passed tests (5)

    Click to expand

    1. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    2. test_wallet_set_up, id: 5335
    Device sessions

    3. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    4. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    5. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    @qoqobolo qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA Aug 31, 2021
    @qoqobolo qoqobolo self-assigned this Aug 31, 2021
    @qoqobolo qoqobolo moved this from IN TESTING to MERGE in Pipeline for QA Aug 31, 2021
    @bitgamma
    don't show notifications from self
    fea2b9a 
    Signed-off-by: Michele Balistreri <michele@bitgamma.com>
    @bitgamma bitgamma merged commit fea2b9a into develop Aug 31, 2021
    Pipeline for QA automation moved this from MERGE to DONE Aug 31, 2021
    @bitgamma bitgamma deleted the fix/11550 branch August 31, 2021 12:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @bitgamma bitgamma

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Push notification of the outgoing message on the synced Android device in background
    4 participants
    @bitgamma @status-im-auto @flexsurfer @qoqobolo