Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12520] Sync deleted chats #12662

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[#12520] Sync deleted chats #12662

merged 1 commit into from
Oct 6, 2021

Conversation

rasom
Copy link
Member

@rasom rasom commented Sep 28, 2021 •
edited

fix #12520

status: ready

@rasom rasom self-assigned this Sep 28, 2021
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Sep 28, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Sep 28, 2021 •
edited

Jenkins Builds

Click to see older builds (29)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fa5fa8a #1 2021-09-28 10:47:01 ~14 min android 📦apk 📲
✔️ fa5fa8a #1 2021-09-28 10:48:52 ~16 min ios 📦ipa 📲
✔️ fa5fa8a #1 2021-09-28 10:50:06 ~17 min android-e2e 📦apk 📲
✔️ e5dbc7a #2 2021-09-29 09:26:31 ~15 min ios 📦ipa 📲
✔️ e5dbc7a #2 2021-09-29 09:29:57 ~19 min android-e2e 📦apk 📲
✔️ e5dbc7a #2 2021-09-29 09:30:00 ~19 min android 📦apk 📲
❌ 7bb468e #3 2021-09-30 12:06:21 ~21 sec android-e2e 📄log
❌ 7bb468e #3 2021-09-30 12:06:25 ~25 sec ios 📄log
❌ 7bb468e #3 2021-09-30 12:06:31 ~32 sec android 📄log
✔️ 5eba6a4 #4 2021-09-30 12:34:14 ~17 min android-e2e 📦apk 📲
✔️ 5eba6a4 #4 2021-09-30 12:35:45 ~19 min android 📦apk 📲
✔️ 5eba6a4 #4 2021-09-30 12:36:04 ~19 min ios 📦ipa 📲
❌ 470c1a4 #5 2021-09-30 14:17:30 ~14 min android-e2e 📄log
❌ 470c1a4 #5 2021-09-30 14:28:37 ~25 min android 📄log
❌ 470c1a4 #5 2021-09-30 14:44:18 ~41 min ios 📄log
✔️ ed35836 #6 2021-09-30 15:22:31 ~11 min android 📦apk 📲
✔️ ed35836 #6 2021-09-30 15:23:53 ~12 min android-e2e 📦apk 📲
✔️ ed35836 #6 2021-09-30 15:29:14 ~17 min ios 📦ipa 📲
✔️ e079d7d #7 2021-10-04 09:50:53 ~11 min android 📦apk 📲
✔️ e079d7d #7 2021-10-04 09:51:37 ~12 min android-e2e 📦apk 📲
✔️ e079d7d #7 2021-10-04 09:55:16 ~15 min ios 📦ipa 📲
✔️ 53e18d0 #8 2021-10-04 11:58:05 ~20 min android 📦apk 📲
✔️ 53e18d0 #8 2021-10-04 11:59:11 ~22 min android-e2e 📦apk 📲
✔️ 53e18d0 #8 2021-10-04 11:59:54 ~22 min ios 📦ipa 📲
❌ b6ff9de #9 2021-10-04 13:50:41 ~1 min android-e2e 📄log
❌ b6ff9de #9 2021-10-04 13:50:52 ~1 min android 📄log
✔️ 6aed8c9 #10 2021-10-04 14:14:11 ~18 min android 📦apk 📲
✔️ 6aed8c9 #10 2021-10-04 14:14:57 ~19 min android-e2e 📦apk 📲
✔️ 6aed8c9 #10 2021-10-04 15:25:39 ~1 hr 29 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 84982f2 #11 2021-10-05 10:58:42 ~17 min android-e2e 📦apk 📲
✔️ 84982f2 #11 2021-10-05 10:58:45 ~17 min android 📦apk 📲
✔️ 84982f2 #11 2021-10-05 10:58:47 ~17 min ios 📦ipa 📲
✔️ fe00971 #13 2021-10-06 12:02:36 ~15 min android-e2e 📦apk 📲
✔️ fe00971 #13 2021-10-06 12:05:05 ~17 min android 📦apk 📲
✔️ fe00971 #13 2021-10-06 12:05:24 ~17 min ios 📦ipa 📲

@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA Sep 28, 2021
@rasom rasom force-pushed the feature/#12520-sync-removing-chat branch from fa5fa8a to e5dbc7a Compare September 29, 2021 09:10
@rasom rasom marked this pull request as ready for review September 29, 2021 09:25
@flexsurfer flexsurfer moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA Sep 29, 2021
@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 67
Failed tests: 1
Passed tests: 66

IDs of failed tests: 5356

Failed tests (1)

Click to expand
  • Rerun tests

    • 1. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356

    Device 1: *Click until Button by xpath:*`//*[@text="Choose a chat name"]` *is NOT presented*
    Device 1: *Find Button by xpath:* `//*[@text="Next"]`

    Device 1: Button by xpath: `//*[@text="Next"]` is not found on the screen

    Device sessions

    Passed tests (66)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    26. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    27. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    28. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    29. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    31. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    32. test_long_press_to_delete_chat, id: 5319
    Device sessions

    33. test_copy_and_paste_messages, id: 5317
    Device sessions

    34. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    35. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    36. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    37. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    38. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    39. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    40. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    41. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    42. test_manage_assets, id: 5341
    Device sessions

    43. test_browser_managing_bookmarks, id: 6633
    Device sessions

    44. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    45. test_request_stt_from_daap, id: 5309
    Device sessions

    46. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    47. test_dapps_permissions, id: 5738
    Device sessions

    48. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    49. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    50. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    51. test_wallet_set_up, id: 5335
    Device sessions

    52. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    53. test_home_view, id: 5379
    Device sessions

    54. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    55. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    56. test_set_profile_picture, id: 6646
    Device sessions

    57. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    58. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    59. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    60. test_pass_phrase_validation, id: 5363
    Device sessions

    61. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    62. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    63. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    64. test_fetching_balance_after_offline, id: 6237
    Device sessions

    65. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    66. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @qoqobolo qoqobolo self-assigned this Sep 29, 2021
    @qoqobolo qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA Sep 29, 2021
    @qoqobolo
    Copy link
    Contributor

    @rasom thanks!
    The feature works fine but there is an issue in develop that can affect it:

    Unable to rejoin public chat after deletion until relogin. Currently syncing of deleted public chat works fine, but there is a problem with syncing after rejoining the same chat.

    How it looks in PR:

    1. Sync Device1 and Device2
    2. Join a public chat on Device1
    3. Delete the chat on Device1 (the chat is deleted on Device2 as expected)
    4. Relogin (because without relogin it's currently impossible to rejoin public chat at all due to #12669)
    5. Rejoin the same public chat on Device1
      Expected result: the chat is added on synced Device2
      Actual result: the chat is not added, need to add it manually

    What do you think, this issue could be fixed in current PR or it's only #12669 related (if so PR can be merged)?

    @rasom
    Copy link
    Member Author

    rasom commented Sep 30, 2021

    @qoqobolo should be fixed in this pr

    @rasom rasom force-pushed the feature/#12520-sync-removing-chat branch from 7bb468e to 5eba6a4 Compare September 30, 2021 12:16
    @qoqobolo
    Copy link
    Contributor

    @rasom In 5eba6a4 the app crashes on iOS and the "Unknown" screen opens on Android when trying to join a public chat (without pairing)

    Screenshot 2021-09-30 at 15 08 59

    @rasom
    Copy link
    Member Author

    rasom commented Sep 30, 2021

    @qoqobolo pushed anther attempt to fix it. Apparently history is not loaded on adding chat back, but that should be a separate problem...

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Oct 1, 2021

    @rasom now #12669 is fixed, thanks!
    But the issue from this comment is still reproducible:

    ISSUE 1: Re-added chat does not re-appear on paired device

    Steps:

    1. Sync Device1 and Device2
    2. Join a public chat on Device1
    3. Delete the chat on Device1
    4. Rejoin the same public chat on Device1

    Expected result: the chat is added on synced Device2
    Actual result: the chat is not added, need to add it manually

    Also, there are a couple of issues more

    ISSUE 2: If the chat list on the home screen contains several chats (2 and more, any type) then when deleting one of them the rest will become invisible

    Pairing doesn't matter in that case.

    Steps:

    1. Join several public chats
    2. Delete one of them
    video_2021-10-01_11-01-40.mp4

    ISSUE 3: If open a chat (any type) on the primary device and delete the same chat on the secondary device, then Unknown screen will be shown on the primary device

    Steps:

    1. Sync Device1 and Device2
    2. Join a public chat on Device1
    3. Open that public chat on Device2
    4. Delete the chat from the home screen on Device1

    Expected result: redirect to the home screen or message like "Chat is removed" on Device2
    Actual result: Unknown screen with an endless spinner on Device2

    @rasom rasom force-pushed the feature/#12520-sync-removing-chat branch from ed35836 to e079d7d Compare October 4, 2021 09:39
    @rasom
    Copy link
    Member Author

    rasom commented Oct 4, 2021

    issues 1 and 2 are fixed now, 3 in progress

    @rasom rasom force-pushed the feature/#12520-sync-removing-chat branch from b6ff9de to 6aed8c9 Compare October 4, 2021 13:55
    @rasom
    Copy link
    Member Author

    rasom commented Oct 4, 2021

    @qoqobolo all known issue should be fixed

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Oct 4, 2021

    Thanks @rasom

    ISSUE 4: Deleted chat re-appears on the paired device after relogin

    Steps:

    1. Sync Device1 and Device2
    2. Join a public chat on Device1
    3. Delete this chat from Device1
    4. Relogin on Device2 and check chat list

    Video from Device2:

    IMG_0927.mp4

    @rasom
    Copy link
    Member Author

    rasom commented Oct 5, 2021

    @qoqobolo should be fixed now

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Oct 5, 2021

    @rasom thanks, works fine now!
    PR can be merged

    @qoqobolo qoqobolo moved this from IN TESTING to MERGE in Pipeline for QA Oct 5, 2021
    @rasom rasom force-pushed the feature/#12520-sync-removing-chat branch from 84982f2 to 1b3a48d Compare October 6, 2021 11:46
    @rasom rasom force-pushed the feature/#12520-sync-removing-chat branch from 1b3a48d to fe00971 Compare October 6, 2021 11:47
    @rasom rasom merged commit fe00971 into develop Oct 6, 2021
    Pipeline for QA automation moved this from MERGE to DONE Oct 6, 2021
    @rasom rasom deleted the feature/#12520-sync-removing-chat branch October 6, 2021 11:47
    @rasom rasom mentioned this pull request Oct 7, 2021
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

    Assignees

    @rasom rasom

    @qoqobolo qoqobolo

    Labels
    Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Syncing of delete chats
    4 participants
    @rasom @status-im-auto @qoqobolo @flexsurfer