use react-native-fast-image for stickers #12769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (71)
|
justjapann
reviewed
Oct 29, 2021
|
Do you think it makes sense to use |
shivekkhurana
approved these changes
Nov 1, 2021
|
first, i need to build it and test on Android, before it didn't work, then we'll see |
|
The error is: And we can see the But we can also see that the error mentions Notice the addition of |
|
Apparently the path uses POM_ARTIFACT_ID=annotationshttps://github.com/bumptech/glide/blob/master/annotation/gradle.properties#L2 Very messy. |
|
If we look at their Gradle wrapper properties they are using Gradle https://github.com/bumptech/glide/blob/v4.12.0/gradle/wrapper/gradle-wrapper.properties#L6 |
|
The contents of the JAR appear to have what the error is mentioning: |
|
The Gradle tools version used by https://github.com/DylanVann/react-native-fast-image/blob/v8.5.11/android/build.gradle#L15 |
|
The class files definitely contain what is required: What the fuck is this? |
|
There's several issues that reference this module and dependency issues:
And they all reference the same fix: But we already have that: |
|
If I run Gradle with And we can clearly see the module is in there: |
|
I ran Gradle through So what the fuck? |
|
As far as I can tell Gradle does not get any So it seems to me like the issue is somewhere internally in how Gradle resolves Java classes. |
|
One interesting thing I've noticed. If But if Which is interesting... |
|
My best guess is that this indeed is an issue with ProGuard, but I'll have to read up on that. |
|
But if I set in minifyEnabled false
useProguard falseThen the build fails the same way. |
|
Oh, but I found something relevant in the logs: Lets try |
|
Help, I tied all possible ways, including setting the contents of But it still fails. So I'm starting to think it must be something else. |
|
One thing I noticed after looking at the Which doesn't look right. |
|
I've identified what's wrong by using And as we can see I could reproduce the error. But here's what worked: The key difference is that I copied that Which shows that the issue appears to be caused by Gradle getting confused that Which is ALSO a dependency for Which appears to confuse Gradle, and it does not include it in Not sure yet what's the proper fix, but this is progress. |
|
If I look at the dependencies defined in dependencies {
//noinspection GradleDynamicVersion
implementation 'com.facebook.react:react-native:+' // From node_modules
implementation "com.github.bumptech.glide:glide:${glideVersion}"
implementation "com.github.bumptech.glide:okhttp3-integration:${glideVersion}"
annotationProcessor "com.github.bumptech.glide:compiler:${glideVersion}"
}https://github.com/DylanVann/react-native-fast-image/blob/v8.5.11/android/build.gradle#L62-L68 Correctly we see that both |
|
actually, this error might be related |
|
i've added |
|
I don't see one: |
|
but now build is green, dunno |
|
anyway it still has runtime error :( |
|
Have you tried updating pods/gems? |
|
|
During |
|
|
jakubgs
force-pushed
the
feature/fast-image-for-stickers
branch
from
4935bb1
to
d4f319e
Compare
flexsurfer
force-pushed
the
feature/fast-image-for-stickers
branch
2 times, most recently
from
38a713c
to
cdb3950
Compare
97% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (67)Click to expand |
50% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (1) |
97% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (67)Click to expand |
flexsurfer
force-pushed
the
feature/fast-image-for-stickers
branch
from
cdb3950
to
437d58f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use react-native-fast-image for stickers