[#12760] Add Binance Smart chain as main network

[flexsurfer]

fixes #12760

[status-im-auto]

Jenkins Builds

Click to see older builds (9)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	9c8db7a	#1	2021-11-10 12:41:58	~19 min	android-e2e	📦apk 📲
✔️	9c8db7a	#1	2021-11-10 12:42:52	~20 min	ios	📦ipa 📲
✔️	9c8db7a	#1	2021-11-10 12:46:16	~23 min	android	📦apk 📲
✔️	e7f61db	#2	2021-11-11 09:17:36	~11 min	android-e2e	📦apk 📲
✔️	e7f61db	#2	2021-11-11 09:18:50	~13 min	android	📦apk 📲
✔️	e7f61db	#2	2021-11-11 09:22:16	~16 min	ios	📦ipa 📲
✔️	73711eb	#3	2021-11-11 13:27:42	~11 min	android	📦apk 📲
✔️	73711eb	#3	2021-11-11 13:28:57	~13 min	android-e2e	📦apk 📲
✔️	73711eb	#3	2021-11-11 13:33:50	~17 min	ios	📦ipa 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	60effa1	#4	2021-11-11 14:24:44	~11 min	android-e2e	📦apk 📲
✔️	60effa1	#4	2021-11-11 14:27:57	~14 min	android	📦apk 📲
✔️	60effa1	#4	2021-11-11 14:29:53	~16 min	ios	📦ipa 📲
❌	82d54bd	#5	2021-11-12 09:45:07	~4 min	ios	📄log
✔️	82d54bd	#5	2021-11-12 09:54:17	~14 min	android	📦apk 📲
✔️	82d54bd	#5	2021-11-12 09:54:17	~14 min	android-e2e	📦apk 📲

[status-im-auto]

99% of end-end tests have passed

Total executed tests: 69
Failed tests: 1
Passed tests: 68

IDs of failed tests: 5419 

Failed tests (1)

Click to expand

Rerun tests

1. test_logcat_backup_recovery_phrase, id: 5419

Device 1: Checking in logcat for: `address` Device 1: Checking in logcat for: `angle` Device 1: ['Passphrase1 in logcat!!!', 'Passphrase2 in logcat!!!'] Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (68)

Click to expand

1. test_send_token_with_7_decimals, id: 5350

Device sessions Device 1: Steps, video, logs

2. test_keycard_create_login_restore_unlock_same_seed, id: 5689

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_keycard_send_eth_from_wallet_to_address, id: 6289

Device sessions Device 1: Steps, video, logs

4. test_install_pack_and_send_sticker, id: 5782

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_send_audio_message_with_push_notification_check, id: 6316

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304

Device sessions Device 1: Steps, video, logs

7. test_long_press_to_delete_chat, id: 5319

Device sessions Device 1: Steps, video, logs

8. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

Device sessions Device 1: Steps, video, logs

9. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272

Device sessions Device 1: Steps, video, logs

10. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

11. test_send_and_open_links_with_previews, id: 5373

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

12. test_manage_assets, id: 5341

Device sessions Device 1: Steps, video, logs

13. test_open_public_chat_using_deep_link, id: 5396

Device sessions Device 1: Steps, video, logs

14. test_public_chat_messaging_emojis_timestamps, id: 5313

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

15. test_send_transaction_set_recipient_options, id: 6328

Device sessions Device 1: Steps, video, logs

16. test_unread_messages_counter_public_chat, id: 5360

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

17. test_keycard_send_eth_in_1_1_chat, id: 6293

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

18. test_keycard_request_stt_from_daap, id: 6249

Device sessions Device 1: Steps, video, logs

19. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

20. test_browser_managing_bookmarks, id: 6633

Device sessions Device 1: Steps, video, logs

21. test_mobile_data_usage_complex_settings, id: 6228

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

22. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210

Device sessions Device 1: Steps, video, logs

23. test_add_account_to_multiaccount_instance_generate_new, id: 6224

Device sessions Device 1: Steps, video, logs

24. test_send_eth_to_ens_in_chat, id: 6279

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

25. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308

Device sessions Device 1: Steps, video, logs

26. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

27. test_can_use_purchased_stickers_on_recovered_account, id: 5783

Device sessions Device 1: Steps, video, logs

28. test_dapps_permissions, id: 5738

Device sessions Device 1: Steps, video, logs

29. test_start_chat_with_ens_mention_in_one_to_one, id: 5403

Device sessions Device 1: Steps, video, logs

30. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

31. test_keycard_can_see_all_transactions_in_history, id: 6291

Device sessions Device 1: Steps, video, logs

32. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342

Device sessions Device 1: Steps, video, logs

33. test_request_stt_from_daap, id: 5309

Device sessions Device 1: Steps, video, logs

34. test_send_eth_in_1_1_chat_transaction_push, id: 6253

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

35. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

36. test_delete_close_all_tabs, id: 5390

Device sessions Device 1: Steps, video, logs

37. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675

Device sessions Device 1: Steps, video, logs

38. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

39. test_block_user_from_public_chat, id: 5786

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

40. test_keycard_sign_message_and_transactions_from_daap, id: 6251

Device sessions Device 1: Steps, video, logs

41. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314

Device sessions Device 1: Steps, video, logs

42. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

43. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

44. test_home_view, id: 5379

Device sessions Device 1: Steps, video, logs

45. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381

Device sessions Device 1: Steps, video, logs

46. test_create_new_group_chat_messaging_pn_delivered, id: 3994

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

47. test_reactions_to_message_in_chats, id: 6315

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

48. test_set_profile_picture, id: 6646

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

49. test_restore_account_from_mnemonic_to_keycard, id: 6240

Device sessions Device 1: Steps, video, logs

50. test_share_copy_contact_code_and_wallet_address, id: 5323

Device sessions Device 1: Steps, video, logs

51. test_delete_chats_via_delete_button_rejoin, id: 5387

Device sessions Device 1: Steps, video, logs

52. test_send_transaction_with_custom_token, id: 6208

Device sessions Device 1: Steps, video, logs

53. test_fetching_balance_after_offline, id: 6237

Device sessions Device 1: Steps, video, logs

54. test_offline_add_new_group_chat_member, id: 3998

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

55. test_copy_and_paste_messages, id: 5317

Device sessions Device 1: Steps, video, logs

56. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244

Device sessions Device 1: Steps, video, logs

57. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394

Device sessions Device 1: Steps, video, logs

58. test_pass_phrase_validation, id: 5363

Device sessions Device 1: Steps, video, logs

59. test_insufficient_funds_wallet_positive_balance, id: 5412

Device sessions Device 1: Steps, video, logs

60. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384

Device sessions Device 1: Steps, video, logs

61. test_wallet_set_up, id: 5335

Device sessions Device 1: Steps, video, logs

62. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

Device sessions Device 1: Steps, video, logs

63. test_can_add_existing_ens_on_mainnet, id: 5502

Device sessions Device 1: Steps, video, logs

64. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356

Device sessions Device 1: Steps, video, logs

65. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

66. test_collectible_from_wallet, id: 5346

Device sessions Device 1: Steps, video, logs

67. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

68. test_recover_account_from_new_user_seedphrase, id: 6296

Device sessions Device 1: Steps, video, logs

[Parveshdhull]

Issue
If I use the apk as a fresh install it works fine. But if I have an older apk installed and I install a new APK from PR. And then choose binance network, it gives this error.

Video: https://drive.google.com/file/d/1HiOL2wS-XG95n_47yrH39Lr-CkhI68B5/view?usp=sharing

[flexsurfer]

thanks @Parveshdhull , fixed

[qoqobolo]

Tested on iOS and Android:

• can switch to Binance Smart chain
• regular and Keycard accounts
• tabs Collectibles and History no longer appear on networks other than Mainnet
• can switch to other main networks
• can add a custom network
• can sign tx on BSC
• Mainnet is still set as the default network on Nightly build

@flexsurfer thanks for your work!
PR can be merged.