update react-native-webview #12987
Merged
update react-native-webview #12987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (9)
|
flexsurfer
approved these changes
Jan 10, 2022
88% of end-end tests have passedFailed tests (20)Click to expand
Passed tests (143)Click to expand |
|
@bitgamma thanks for your work! Unfortunately, I couldn't fully test it as well, since the DApp was stuck on the endless loading after the wallet connection. The DApp behaves like this on both Android and iOS; on Nightly and PR builds. Also, we tried to open it from different locations (i.e. Ukraine and Spain). IMG_1033.MP4Regarding #12726, I could reproduce the same error following the steps described in the issue on the PR build
|
|
@qoqobolo I will check if I find a solution for these problems, maybe they can be fixed too. I tried the Nova version of the tornado cash and it didn't have this behaviour and it did not crash (but I had no funds in the test account so I couldn't finish the setup, don't know what happens next) |
|
@bitgamma yeah, there is no crash with the Nova version. And since the site was changed probably it will be enough for merge. |
|
@qoqobolo I am almost sure that #12726 is fixed now (with my setup it required many many retries to reproduce, but now I can never reproduce it). The refresh problem with tornado.cash is still under investigation, but I'd need to debug the dApp itself and see if we can find a workaround. Probably not the scope of this PR. |
|
@bitgamma okay, let's merge this one then. |
* more robust send-to-bridge Signed-off-by: Michele Balistreri <michele@bitgamma.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11565.
Fixes #12726.
Upgrades react-native-webview to the latest version + our changes to permission handling. It also makes send-to-bridge more robust to dapp invoking web3 methods before the page is fully loaded
Since the react-native-webview module has changed we need to make sure no regressions.