Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12989] Use higher base fee value for default tx fee calculation #13020

Merged
merged 1 commit into from
Jan 19, 2022
Merged

[#12989] Use higher base fee value for default tx fee calculation #13020

merged 1 commit into from
Jan 19, 2022

Conversation

rasom
Copy link
Member

@rasom rasom commented Jan 18, 2022

fixes #12989 (probably)

  • for all networks 80th percentile ceiling of base fee removed
  • for testnet networks default max_fee=2*base_fee+max_priority_fee

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jan 18, 2022
@rasom rasom requested a review from bitgamma January 18, 2022 10:53
@status-im-auto
Copy link
Member

status-im-auto commented Jan 18, 2022 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4416736 #1 2022-01-18 11:06:39 ~12 min android-e2e 📦apk 📲
✔️ 4416736 #1 2022-01-18 11:07:05 ~13 min ios 📦ipa 📲
✔️ 4416736 #1 2022-01-18 11:10:59 ~17 min android 📦apk 📲

@flexsurfer flexsurfer moved this from REVIEW to E2E Tests in Pipeline for QA Jan 18, 2022
@churik churik moved this from E2E Tests to IN TESTING in Pipeline for QA Jan 18, 2022
@churik churik moved this from IN TESTING to E2E Tests in Pipeline for QA Jan 18, 2022
@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 162
Failed tests: 16
Passed tests: 146

IDs of failed tests: 6305,695810,6284,695811,5786,6316,695843,695812,695804,695805,5310,695783,5431,695842,5368,695845

Failed tests (16)

Click to expand
  • Rerun tests

    • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find 'AllowButton' by 'xpath': `//*[@text="Allow" or @text="ALLOW"]`
    Device 2: Find 'Button' by 'xpath': `//*[@content-desc='open-gallery']/following-sibling::android.view.ViewGroup[1]`

    Status of another user not shown when open another user profile Status of another user not shown when open another user profile

    Device sessions

    2. test_keycard_upgrade (TestRail link is not found)

    Device 1: Find 'Button' by 'xpath': `//*[@text="Total value"]`
    Device 1: Upgrading apk to apk_upgrade

    An unknown server-side error occurred while processing the command. Original error: Cannot read property 'endsWith' of undefined

    Device sessions

    3. test_unread_previews_public_chat_version_upgrade (TestRail link is not found)

    Device 1: Find 'SignInButton' by 'xpath': `//*[@text="Sign in"]`
    Device 1: Tap on found: SignInButton

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    4. test_devices_group_chats_upgrade (TestRail link is not found)

    Device 1: Find 'SignInButton' by 'xpath': `//*[@text="Sign in"]`
    Device 1: Tap on found: SignInButton

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    5. test_block_user_from_public_chat, id: 5786

    ## Public chat 'ktcdvoo' is created successfully!
    Device 1: Find 'EditBox' by 'accessibility id': `chat-message-input`

    Cannot set the element to 'Before block from 1'. Did you interact with the correct element?

    Device sessions

    6. test_send_audio_message_with_push_notification_check, id: 6316

    Device 2: Find 'Text' by 'xpath': `//*[@content-desc='play-pause-audio-message-button']/../..//android.widget.TextView[1]`
    Device 2: 'Text' is '00:05'

    Timer exceed 2 minutes

    Device sessions

    7. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843

    Device 1: Looking for a message by text: Message AFTER edit 2
    Device 2: Looking for a message by text: Message AFTER edit 2

    No mark in message bubble about this message was edited Message is not edited.

    Device sessions

    8. test_devices_activity_centre_profile_settings_upgrade (TestRail link is not found)

    Device 1: Find 'SignInButton' by 'xpath': `//*[@text="Sign in"]`
    Device 1: Tap on found: SignInButton

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    9. test_dapps_browser_several_accounts_upgrade (TestRail link is not found)

    Device 1: Find 'SignInButton' by 'xpath': `//*[@text="Sign in"]`
    Device 1: Tap on found: SignInButton

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    10. test_devices_sync_contact_management_upgrade (TestRail link is not found)

    Device 1: Find 'SignInButton' by 'xpath': `//*[@text="Sign in"]`
    Device 1: Tap on found: SignInButton

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    11. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Button element not found
    Device 1: Find 'Button' by 'xpath': `//*[@text="Generate keys"]`

    Device 1: Button by xpath: `//*[@text="Generate keys"]` is not found on the screen

    Device sessions

    12. test_commands_audio_backward_compatibility_upgrade (TestRail link is not found)

    Device 1: Find 'SignInButton' by 'xpath': `//*[@text="Sign in"]`
    Device 1: Tap on found: SignInButton

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    13. test_add_custom_network, id: 5431

    Device 1: Button element not found
    Device 1: Find 'EditBox' by 'xpath': `//*[@text="RPC URL"]/following-sibling::*[1]/android.widget.EditText`

    Device 1: EditBox by xpath: `//*[@text="RPC URL"]/following-sibling::*[1]/android.widget.EditText` is not found on the screen

    Device sessions

    14. test_creating_community_accept_membership, id: 695842

    Device 2: Wait for 'EditBox'
    ## Public chat 'sbryvsv' is created successfully!

    Device 2: Button by xpath: `//*[@text="some name"]` is not found on the screen

    Device sessions

    15. test_change_log_level_and_fleet, id: 5368

    Device 1: Find 'AdvancedButton' by 'accessibility id': `advanced-button`
    Device 1: Find 'AdvancedButton' by 'accessibility id': `advanced-button`

    An unknown server-side error occurred while processing the command. Original error: Error executing adbExec. Original error: 'Command '/home/chef/android-sdk-linux/platform-tools/adb -P 5037 -s emulator-5554 pull /storage/emulated/0/Android/data/im.statu

    Device sessions

    16. test_notification_in_activity_center_for_mention_in_community_and_group_chat, id: 695845

    Device 1: Find 'BackButton' by 'accessibility id': `Navigate Up`
    # STEP: Tapping on community link and request membership

    Device 2: Button by xpath: `//*[@text="some name"]` is not found on the screen

    Device sessions

    Passed tests (146)

    Click to expand

    1. test_reply_to_message_in_chats, id: 6233
    Device sessions

    2. test_switching_accounts_in_dapp, id: 6232
    Device sessions

    3. test_privacy_policy_terms_of_use_node_version_need_help_in_profile, id: 5453
    Device sessions

    4. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    5. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    6. test_request_stt_from_dapp, id: 5309
    Device sessions

    7. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    8. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    9. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    10. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    11. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    12. test_block_and_unblock_user_from_group_chat_via_group_info, id: 5752
    Device sessions

    13. test_create_account_short_and_mismatch_password, id: 5460
    Device sessions

    14. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    15. test_use_pinned_mailserver, id: 5766
    Device sessions

    16. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    17. test_keycard_frozen_card_flows, id: 695851
    Device sessions

    18. test_markdown_support_in_messages, id: 5425
    Device sessions

    19. test_set_primary_ens_custom_domain, id: 6219
    Device sessions

    20. test_webview_camera_permission, id: 6635
    Device sessions

    21. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    22. test_different_status_in_timeline, id: 6342
    Device sessions

    23. test_make_admin_member_of_group_chat, id: 5694
    Device sessions

    24. test_decline_invitation_to_group_chat, id: 5756
    Device sessions

    25. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    26. test_mention_users_not_in_chats_if_not_in_contacts, id: 6326
    Device sessions

    27. test_delete_close_all_tabs, id: 5390
    Device sessions

    28. test_can_delete_several_multiaccounts, id: 6318
    Device sessions

    29. test_can_scan_qr_with_chat_key_from_home_start_chat, id: 6298
    Device sessions

    30. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 5781
    Device sessions

    31. test_keycard_interruption_creating_onboarding_flow, id: 5742
    Device sessions

    32. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    33. test_set_currency, id: 5429
    Device sessions

    34. test_backup_recovery_phrase_warning_from_wallet, id: 5358
    Device sessions

    35. test_can_send_all_tokens_via_max_option, id: 6330
    Device sessions

    36. test_pair_devices_group_chat_different_messages_nicknames, id: 6317
    Device sessions

    37. test_open_dapp_using_deep_link, id: 5442
    Device sessions

    38. test_send_token_with_7_decimals, id: 5350
    Device sessions

    39. test_can_accept_or_reject_multiple_chats_from_activity_center, id: 695782
    Device sessions

    40. test_open_user_profile_long_press_on_message, id: 6267
    Device sessions

    41. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    42. test_add_remove_contact_via_contacts_view, id: 6312
    Device sessions

    43. test_keycard_blocked_card_lost_or_frozen_flows, id: 695852
    Device sessions

    44. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    45. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    46. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    47. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    48. test_send_eth_from_wallet_incorrect_address, id: 5461
    Device sessions

    49. test_push_notifications_reactions_for_messages_in_stickers_audio_image, id: 6321
    Device sessions

    50. test_activity_center_group_chats_trusted_contacts, id: 695771
    Device sessions

    51. test_keycard_send_eth_to_ens, id: 6295
    Device sessions

    52. test_can_change_account_settings, id: 6235
    Device sessions

    53. test_same_seed_added_inside_multiaccount_and_keycard, id: 6311
    Device sessions

    54. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    55. test_network_mismatch_for_send_request_in_1_1_chat, id: 6257
    Device sessions

    56. test_can_pin_messages_in_one_to_one_and_group_chats, id: 695847
    Device sessions

    57. test_block_user_from_one_to_one_header_check_push_notification_service, id: 5763
    Device sessions

    58. test_keycard_can_recover_keycard_account_offline_and_add_watch_only_acc, id: 6243
    Device sessions

    59. test_search_asset_and_currency, id: 6269
    Device sessions

    60. test_invite_friends, id: 5433
    Device sessions

    61. test_public_chat_text_timestamps_while_on_different_tab, id: 5313
    Device sessions

    62. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    63. test_public_clear_history_via_options_and_long_press, id: 5426
    Device sessions

    64. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    65. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    66. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    67. test_can_start_chat_from_suggestions_using_search_chat, id: 6320
    Device sessions

    68. test_can_access_images_by_link, id: 5456
    Device sessions

    69. test_search_chat_on_home, id: 5757
    Device sessions

    70. test_leave_group_chat_highligted_via_group_info, id: 3997
    Device sessions

    71. test_nicknames_ens_group_chats, id: 6327
    Device sessions

    72. test_keycard_send_funds_between_accounts_set_max_in_multiaccount_instance, id: 6292
    Device sessions

    73. test_can_scan_different_links_with_universal_qr_scanner, id: 6322
    Device sessions

    74. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    75. test_back_forward_refresh_navigation_history_kept_after_relogin, id: 5395
    Device sessions

    76. test_send_funds_between_accounts_in_multiaccount_instance, id: 6225
    Device sessions

    77. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    78. test_long_press_to_delete_chat, id: 5319
    Device sessions

    79. test_share_user_profile_url_public_chat, id: 5498
    Device sessions

    80. test_open_user_profile_using_deep_link, id: 5441
    Device sessions

    81. test_recover_accounts_with_certain_seedphrase, id: 5455
    Device sessions

    82. test_copy_and_paste_messages, id: 5317
    Device sessions

    83. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    84. test_rename_group_chat, id: 6280
    Device sessions

    85. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    86. test_invite_to_group_chat_handling, id: 6324
    Device sessions

    87. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    88. test_can_use_another_fleets_and_networks_advanced_set_nonce, id: 695890
    Device sessions

    89. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    90. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    91. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    92. test_mark_all_messages_as_read_public_chat, id: 6270
    Device sessions

    93. test_can_reset_password, id: 695850
    Device sessions

    94. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    95. test_keycard_settings_pin_puk_pairing, id: 695841
    Device sessions

    96. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    97. test_unread_messages_counter_preview_highlited_1_1_chat, id: 5362
    Device sessions

    98. test_offline_can_login_cant_send_transaction, id: 5407
    Device sessions

    99. test_manage_assets, id: 5341
    Device sessions

    100. test_browser_managing_bookmarks, id: 6633
    Device sessions

    101. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    102. test_can_scan_eip_681_links, id: 6282
    Device sessions

    103. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    104. test_can_not_connect_to_mailserver, id: 5767
    Device sessions

    105. test_dapps_permissions, id: 5738
    Device sessions

    106. test_resolve_ipns_name, id: 6323
    Device sessions

    107. test_open_url_with_non_english_text_connect_revoke_wallet_new_tab_open_chat_options, id: 5424
    Device sessions

    108. test_keycard_interruption_access_key_onboarding_flow, id: 6246
    Device sessions

    109. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    110. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    111. test_deny_access_camera_and_gallery, id: 6319
    Device sessions

    112. test_remove_member_from_group_chat, id: 4001
    Device sessions

    113. test_pair_devices_sync_photo_community_group_chats, id: 695856
    Device sessions

    114. test_validation_amount_errors, id: 5437
    Device sessions

    115. test_custom_gas_settings, id: 695855
    Device sessions

    116. test_public_unread_messages_counter, id: 5360
    Device sessions

    117. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    118. test_keycard_sign_typed_message_deploy_simple_contract, id: 6310
    Device sessions

    119. test_wallet_set_up, id: 5335
    Device sessions

    120. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    121. test_home_view, id: 5379
    Device sessions

    122. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    123. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    124. test_sign_typed_message_deploy_simple_contract_request_pub_key_from_dapp, id: 5784
    Device sessions

    125. test_app_on_background_by_back_button, id: 6221
    Device sessions

    126. test_set_profile_picture, id: 6646
    Device sessions

    127. test_public_unread_messages_counter_for_mentions_relogin, id: 700718
    Device sessions

    128. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    129. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    130. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    131. test_pass_phrase_validation, id: 5363
    Device sessions

    132. test_public_emoji, id: 700719
    Device sessions

    133. test_cant_add_more_twenty_participants_to_group_chat, id: 5721
    Device sessions

    134. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    135. test_unblocked_user_is_not_added_in_contacts, id: 6213
    Device sessions

    136. test_delete_cut_and_paste_messages, id: 5322
    Device sessions

    137. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    138. test_custom_bootnodes, id: 5432
    Device sessions

    139. test_keycard_request_and_receive_stt_in_1_1_chat_offline_opened_from_push, id: 6294
    Device sessions

    140. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    141. test_add_switch_delete_custom_mailserver, id: 5436
    Device sessions

    142. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    143. test_fetching_balance_after_offline, id: 6237
    Device sessions

    144. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    145. test_show_profile_picture_of_setting, id: 6636
    Device sessions

    146. test_disable_use_history_node, id: 6332
    Device sessions

    @churik
    Copy link
    Member

    churik commented Jan 19, 2022

    Awosome! Failed e2e are unrelated to PR.

    @churik churik moved this from E2E Tests to IN TESTING in Pipeline for QA Jan 19, 2022
    @churik churik self-assigned this Jan 19, 2022
    @churik churik moved this from IN TESTING to MERGE in Pipeline for QA Jan 19, 2022
    @rasom rasom force-pushed the fix/#12989-use-higher-base-fee-value-for-tx-fee branch from 4416736 to eefc2ed Compare January 19, 2022 12:15
    @rasom rasom merged commit eefc2ed into develop Jan 19, 2022
    Pipeline for QA automation moved this from MERGE to DONE Jan 19, 2022
    @rasom rasom deleted the fix/#12989-use-higher-base-fee-value-for-tx-fee branch January 19, 2022 12:15
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @bitgamma bitgamma bitgamma approved these changes

    Assignees

    @rasom rasom

    @churik churik

    Labels
    Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Transactions couldn't be created from certain multiaccounts
    4 participants
    @rasom @status-im-auto @churik @bitgamma