Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12919] Allow adding emoji to group intro message if it exceeds limit #13024

Merged
merged 1 commit into from
Jan 19, 2022
Merged

[#12919] Allow adding emoji to group intro message if it exceeds limit #13024

merged 1 commit into from
Jan 19, 2022

Conversation

rasom
Copy link
Member

@rasom rasom commented Jan 19, 2022 •
edited

fix #12919

status: ready

@rasom rasom requested review from flexsurfer and churik and removed request for flexsurfer January 19, 2022 09:47
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jan 19, 2022
@rasom rasom self-assigned this Jan 19, 2022
@rasom rasom removed the request for review from churik January 19, 2022 09:47
@rasom rasom changed the title [#12989] Allow adding emoji to group intro message if it exceeds limit [#12919] Allow adding emoji to group intro message if it exceeds limit Jan 19, 2022
@rasom rasom force-pushed the fix/#12989-group-chat-invite branch from 4838770 to 758d817 Compare January 19, 2022 09:49
@status-im-auto
Copy link
Member

status-im-auto commented Jan 19, 2022 •
edited

Jenkins Builds

Click to see older builds (3)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 758d817 #2 2022-01-19 10:01:15 ~11 min ios 📦ipa 📲
✔️ 758d817 #2 2022-01-19 10:06:14 ~16 min android 📦apk 📲
✔️ 758d817 #2 2022-01-19 10:06:21 ~16 min android-e2e 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4838770 #1 2022-01-19 10:01:38 ~14 min android-e2e 📦apk 📲
✔️ 4838770 #1 2022-01-19 10:01:46 ~14 min ios 📦ipa 📲
✔️ 4838770 #1 2022-01-19 10:09:15 ~22 min android 📦apk 📲
✔️ bf92c51 #3 2022-01-19 15:50:05 ~12 min ios 📦ipa 📲
✔️ bf92c51 #3 2022-01-19 16:00:33 ~23 min android 📦apk 📲
✔️ bf92c51 #3 2022-01-19 16:01:07 ~23 min android-e2e 📦apk 📲

@qoqobolo qoqobolo moved this from REVIEW to E2E Tests in Pipeline for QA Jan 19, 2022
@qoqobolo qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA Jan 19, 2022
@qoqobolo qoqobolo self-assigned this Jan 19, 2022
@qoqobolo qoqobolo moved this from IN TESTING to MERGE in Pipeline for QA Jan 19, 2022
@status-im-auto
Copy link
Member

48% of end-end tests have passed

Total executed tests: 65
Failed tests: 34
Passed tests: 31

IDs of failed tests: 5502,5309,6291,5342,6244,5315,5314,5412,5350,6328,6251,6296,5758,6226,6289,5689,6272,5384,5308,6265,6253,5782,5341,5783,5394,6279,5335,6263,6646,5332,6249,5381,6293,6237

Failed tests (34)

Click to expand
  • Rerun tests

    • 1. test_can_add_existing_ens_on_mainnet, id: 5502

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    2. test_request_stt_from_dapp, id: 5309

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244

    Device 1: Swiping up
    Device 1: Waiting 400 seconds for ADI to display asset

    Device 1: Balance ADI 0 is not changed during 400 seconds!

    Device sessions

    6. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

    Device 1: Button element not found
    Device 1: Find 'Text' by 'accessibility id': `default-username`

    Device 1: Text by accessibility id: `default-username` is not found on the screen; also Unexpected Alert is shown: 'Wrong decimals for token PPP at address 0xc42209accc14029c1012fb5680d95fbd6036e2a0 - set to 8 but detected as 18'

    Device sessions

    7. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    8. test_insufficient_funds_wallet_positive_balance, id: 5412

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    9. test_send_token_with_7_decimals, id: 5350

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    10. test_send_transaction_set_recipient_options, id: 6328

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    11. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    12. test_recover_account_from_new_user_seedphrase, id: 6296

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    13. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

    Device 1: Button element not found
    Device 1: Click until 'Button' by 'accessibility id': `lets-go-button` is NOT presented

    Device 1: HomeButton by xpath:`//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    14. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    15. test_keycard_send_eth_from_wallet_to_address, id: 6289

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    16. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/0e6b1c5104074c989bee81452c0da3b6

    17. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272

    Device 1: Swiping up
    Device 1: Waiting 400 seconds for ADI to display asset

    Device 1: Balance ADI 0 is not changed during 400 seconds!

    Device sessions

    18. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    19. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    20. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    21. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    22. test_install_pack_and_send_sticker, id: 5782

    Device 1: Looking for chat: '#kluvbwk'
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token PAY at address 0xb97048628db6b661d4c2aa833e95dbe1a905b280 - set to Tenx Pay Token but detected as TenX Pay

    Device sessions

    23. test_manage_assets, id: 5341

    Device 1: Find 'AssetCheckBox' by 'xpath': `//*[@text='MDS']`
    Device 1: Find 'AssetCheckBox' by 'xpath': `//*[@text='MDS']`

    Device 1: AssetCheckBox by xpath: `//*[@text='MDS']` is not found on the screen

    Device sessions

    24. test_can_use_purchased_stickers_on_recovered_account, id: 5783

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    25. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    26. test_send_eth_to_ens_in_chat, id: 6279

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    27. test_wallet_set_up, id: 5335

    Device 1: Click until 'Button' by 'accessibility id': `maybe-later` will be presented
    Device 1: Find 'Button' by 'xpath': `//*[@text="Next"]`

    Device 1: Button by accessibility id: `maybe-later` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    28. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 1: Find 'AssetCheckBox' by 'xpath': `//*[@text='STT']`
    Device 1: Find 'AssetCheckBox' by 'xpath': `//*[@text='STT']`

    Device 1: AssetCheckBox by xpath: `//*[@text='STT']` is not found on the screen

    Device sessions

    29. test_set_profile_picture, id: 6646
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/6b7c6c5e00104d0287aae2e50ac77d4c

    30. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332

    Device 1: Find 'ChatElementByText' by 'xpath': `//*[starts-with(@text,'Substantial Starchy Queenalexandrasbirdwingbutterfly')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`
    Device 1: Tap on found: ChatElementByText

    Device 1: ProfileSendMessageButton by accessibility id:`Chat-item-button` is not found on the screen

    Device sessions

    31. test_keycard_request_stt_from_daap, id: 6249

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    32. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    33. test_keycard_send_eth_in_1_1_chat, id: 6293

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    34. test_fetching_balance_after_offline, id: 6237

    Device 1: Button element not found
    Device 1: Find 'Button' by 'accessibility id': `lets-go-button`

    Device 1: Button by accessibility id: `lets-go-button` is not found on the screen; also Unexpected Alert is shown: 'true is not ISeqable'

    Device sessions

    Passed tests (31)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    4. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    5. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    6. test_delete_close_all_tabs, id: 5390
    Device sessions

    7. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    8. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    9. test_block_user_from_public_chat, id: 5786
    Device sessions

    10. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    11. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    12. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    13. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    14. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    15. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    16. test_long_press_to_delete_chat, id: 5319
    Device sessions

    17. test_copy_and_paste_messages, id: 5317
    Device sessions

    18. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    19. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    20. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    21. test_browser_managing_bookmarks, id: 6633
    Device sessions

    22. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    23. test_dapps_permissions, id: 5738
    Device sessions

    24. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    25. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    26. test_home_view, id: 5379
    Device sessions

    27. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    28. test_pass_phrase_validation, id: 5363
    Device sessions

    29. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    30. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    31. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    @rasom rasom force-pushed the fix/#12989-group-chat-invite branch from 758d817 to bf92c51 Compare January 19, 2022 15:36
    @rasom rasom merged commit bf92c51 into develop Jan 19, 2022
    @rasom rasom deleted the fix/#12989-group-chat-invite branch January 19, 2022 15:37
    Pipeline for QA automation moved this from MERGE to DONE Jan 19, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @rasom rasom

    @qoqobolo qoqobolo

    Labels
    Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Emoji as last char erases value in input field if char + emoji > acceptable limit
    4 participants
    @rasom @status-im-auto @flexsurfer @qoqobolo