Add support for mutual contact requests #13054
Conversation
Jenkins BuildsClick to see older builds (56)
|
rasom
force-pushed
the
feature/contact-request-2
branch
from
d53b827
to
85fc3a4
Compare
rasom
force-pushed
the
feature/contact-request-2
branch
from
85fc3a4
to
d799260
Compare
cammellos
force-pushed
the
feature/contact-request-2
branch
2 times, most recently
from
d86df4b
to
d253533
Compare
cammellos
force-pushed
the
feature/contact-request-2
branch
from
d253533
to
a20baf5
Compare
cammellos
force-pushed
the
feature/contact-request-2
branch
from
51d25a9
to
d5116eb
Compare
cammellos
force-pushed
the
feature/contact-request-2
branch
from
d5116eb
to
a7060af
Compare
80% of end-end tests have passedNot executed tests (1)Failed tests (17)Click to expand
Passed tests (67)Click to expand
|
| :margin-left (if outgoing 0 8)}} | ||
| [react/image {:source (resources/get-image :hand-wave) | ||
| :style {:width 112 | ||
| :height 96.71}}] |
There was a problem hiding this comment.
that pretty weird number, why it's not round ?
There was a problem hiding this comment.
Not sure :) but the UI will have to be changed when we redesign (using still old designs), but I'll make it round
src/status_im/ui/screens/contact_requests/views/contact_request.cljs
Outdated
Show resolved
Hide resolved
59% of end-end tests have passedFailed tests (7)Click to expand
Passed tests (10)Click to expand
|
|
@cammellos thank you for PR! Regression issuesISSUE 1: items in the activity center are not alignedSteps:
Expected result: ISSUE 2: error on the opening group info in group chatFound by e2e.
Test: https://ethstatus.testrail.net/index.php?/tests/view/2735684 Expected result: OS: IOS, Android ISSUE 3: "Unknown" on redirect to 1-1 chat when tapping on push notificationSteps:
Expected result: FILE.2022-05-13.11.12.01.mp4OS: Android Feature issuesISSUE 4: Error when attempting to send the contact request to the userSteps:
Expected result: Don't think it requires for now further testing, taking into account described issues. |
cammellos
force-pushed
the
feature/contact-request-2
branch
2 times, most recently
from
576f1f9
to
655242d
Compare
|
@flexsurfer should be ready for review again, thanks! |
90% of end-end tests have passedFailed tests (17)Click to expand
Passed tests (158)Click to expand
|
cammellos
force-pushed
the
feature/contact-request-2
branch
3 times, most recently
from
545e097
to
5cacda5
Compare
|
Looks like this branch needs a rebase: Since the APK is unsigned. Most probably missing changes from #13296. |
|
@cammellos please tell if the below behaviour is expected? ISSUE/Question 12 When user with enabled CR deletes another user from contacts - he (the user with enabled CR) is also automatically been deleted from contacts of that userSTR:
Actual result: User B is removed from contacts of User A (which is expected). But in addition to that, User A is removed from contacts for User B (is this behaviour expected?) Expected result: ? |
|
@pavloburykh that's expected, basically removing from one side should remove on both, so that the flow can be restarted, thanks for testing! |
91% of end-end tests have passedNot executed tests (1)Failed tests (15)Click to expand
Passed tests (158)Click to expand
|
50% of end-end tests have passedFailed tests (8)Click to expand
Passed tests (8)Click to expand
|
|
Tested basic flows only. ISSUE 8: Can neither start 1-1 chat with the contact nor send Mutual contact request if the user was added to contacts via "Add to contact" on the user profile (details here)ISSUE 10: Request is not accepted when using Select - Accept and add button from AC(details here) Issues with input fieldISSUE 13: Value from contact request is not duplicating in chat input after accepting itPrerequisites: mutual CR (contact request) is enabled for User1 and User2
ISSUE 14: Can use mentions in CR field, markdown/links are not resolvedPrerequisites: mutual CR (contact request) is enabled for User1 and User2
Issues with activity center (AC)ISSUE 15: Can not tap on pending CR to see the full text
ISSUE 16: Accepting CR from User2 generates a message in AC about accepted CR from User1 on User1 devicePrerequisites: mutual CR (contact request) is enabled for User1 and User2
ISSUE 17: "Accepted" CR are not erased from AC when opening 1-1 chat with accepted CRSo they need to be manually accepted/rejected from AC.
Other issuesISSUE 18: No push notifications on new CR for the user (if it is the case)Not sure here, maybe it shouldn't be the case due to spam for new CRs, but there is no push on accepted PNs neither ISSUE 19: can't see the previous history if was removed from contactsPrerequisites: mutual CR (contact request) is enabled for User1 and User2
https://user-images.githubusercontent.com/4557972/170281156-a73b73c6-64e8-4954-b75c-6d3018f0fdf0.mp4 ISSUE 20: not sure that "Accept new chats from" makes any sense if mutual CR is enabled============================================================================================ No regression issues from my side, good to merge |
|
@churik @pavloburykh @qoqobolo thanks for testing! It will go through testing on desktop as well and then it'd be ready to merge, if you could please create separate issues so can be tracked independently, thank you! |
cammellos
force-pushed
the
feature/contact-request-2
branch
from
5cacda5
to
67be76a
Compare
Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
cammellos
force-pushed
the
feature/contact-request-2
branch
from
67be76a
to
91f444b
Compare
This commit adds support for mutual contact requests.
The code is behind a toggle in advanced.
Currently the feature supported is:
If enabled:
Not supported yet:
The code has likely some issues still, but it's already quite a lot of code and I'd rather fix them separately (since it will be only toggled off in advanced I hope is ok).
In terms of testing, probably just basic flows (i.e enable on both sides, make sure you can't contact each other until contact request is exchanged, remove one from contact and make sure the flow can be done again).
fixes #12175