Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13104] Fix deadlock on syncing all data #13128

Merged
merged 1 commit into from
Feb 23, 2022
Merged

[#13104] Fix deadlock on syncing all data #13128

merged 1 commit into from
Feb 23, 2022

Conversation

rasom
Copy link
Member

@rasom rasom commented Feb 23, 2022

fix #13104

status: ready

@rasom rasom self-assigned this Feb 23, 2022
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Feb 23, 2022
@rasom rasom moved this from REVIEW to E2E Tests in Pipeline for QA Feb 23, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Feb 23, 2022 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1c0d16a #1 2022-02-23 11:26:44 ~9 min android-e2e 📦apk 📲
✔️ 1c0d16a #1 2022-02-23 11:27:28 ~10 min android 📦apk 📲
✔️ 1c0d16a #1 2022-02-23 11:30:37 ~13 min ios 📦ipa 📲

@status-github-bot status-github-bot bot moved this from E2E Tests to CONTRIBUTOR in Pipeline for QA Feb 23, 2022
@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 80
Failed tests: 11
Passed tests: 69

IDs of failed tests: 6279,700747,695843,6283,700743,700745,6316,700746,6263,700744,6228

Failed tests (11)

Click to expand
  • Rerun tests

    • 1. test_send_eth_to_ens_in_chat, id: 6279

    Device 1: Find 'AccessKeyButton' by 'xpath': `//*[@text="Access existing keys"]`
    Device 1: Find 'AccessKeyButton' by 'xpath': `//*[@text="Access existing keys"]`

    Device 1: AccessKeyButton by xpath: `//*[@text="Access existing keys"]` is not found on the screen

    Device sessions

    2. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Logging out
    Device 1: Scrolling down to LogoutButton

    Device 1: LogoutButton by accessibility id: `log-out-button` is not found on the screen

    Device sessions

    3. test_edit_delete_message_in_one_to_one_, id: 695843

    Device 1: Getting PN by 'DELETE ME'
    Device 1: Click system back button

    UNedited message version displayed on preview

    Device sessions

    4. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283

    Device 2: Button element not found
    Device 2: Find 'Button' by 'xpath': `//*[@text="Generate keys"]`

    Device 2: Button by xpath: `//*[@text="Generate keys"]` is not found on the screen

    Device sessions

    5. test_onboarding_share_contact_address, id: 700743

    Device 1: ChatButton element not found
    Device 1: Find 'ChatButton' by 'accessibility id': `start-1-1-chat-button`

    Device 1: ChatButton by accessibility id: `start-1-1-chat-button` is not found on the screen

    Device sessions

    6. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    # STEP: Check that badge on profile about back up seed phrase is presented
    Device 1: Find 'Counter' by 'xpath': `//*[contains(@content-desc,'5 out of 5')]/android.widget.TextView`

    Device 1: Counter by xpath: `//*[contains(@content-desc,'5 out of 5')]/android.widget.TextView` is not found on the screen

    Device sessions

    7. test_send_audio_message_with_push_notification_check, id: 6316

    Device 2: Find 'Text' by 'xpath': `//*[@content-desc='play-pause-audio-message-button']/../..//android.widget.TextView[1]`
    Device 2: 'Text' is '00:03'

    Listened 5 seconds but timer shows different listened time in audio message

    Device sessions

    8. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Device 1: Logging out
    Device 1: Scrolling down to LogoutButton

    Device 1: LogoutButton by accessibility id: `log-out-button` is not found on the screen

    Device sessions

    9. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="STT"]`

    Device 1: Button by xpath: `//*[@text="STT"]` is not found on the screen

    Device sessions

    10. test_onboarding_share_wallet_address, id: 700744

    Device 1: Find 'WalletButton' by 'xpath': `//*[contains(@content-desc,'tab, 3 out of 5')]`
    Device 1: Button element not found

    Device 1: 'AccountElementButton' by xpath:'//*[@content-desc='accountcardEthereum account']' not found on the screen

    Device sessions

    11. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    Passed tests (69)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    3. test_wallet_manage_assets, id: 700758
    Device sessions

    4. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    5. test_public_mark_all_messages_as_read, id: 6270
    Device sessions

    6. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    7. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    8. test_group_leave_relogin, id: 3997
    Device sessions

    9. test_send_tx_token_7_decimals, id: 700764
    Device sessions

    10. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    11. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    12. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    13. test_public_delete_chat_long_press, id: 5319
    Device sessions

    14. test_public_tag_message, id: 700738
    Device sessions

    15. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    16. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    17. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    18. test_keycard_fetching_balance_after_offline, id: 6237
    Device sessions

    19. test_send_tx_set_recipient_options_invalid_password, id: 700757
    Device sessions

    20. test_recover_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    21. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    22. test_public_message_edit, id: 700734
    Device sessions

    23. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    24. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    25. test_public_link_send_open, id: 700736
    Device sessions

    26. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    27. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    28. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    29. test_public_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    31. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    32. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    33. test_block_user_from_public_chat, id: 5786
    Device sessions

    34. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    35. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    36. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    37. test_browser_managing_bookmarks, id: 6633
    Device sessions

    38. test_group_add_new_member_activity_centre, id: 700732
    Device sessions

    39. test_public_fetch_more_history, id: 5675
    Device sessions

    40. test_wallet_tx_history_copy_tx_hash_on_lte, id: 700756
    Device sessions

    41. test_send_tx_custom_token_18_decimals, id: 700765
    Device sessions

    42. test_recover_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    43. test_request_stt_from_dapp, id: 5309
    Device sessions

    44. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    45. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    46. test_set_profile_picture, id: 6646
    Device sessions

    47. test_delete_close_all_tabs, id: 5390
    Device sessions

    48. test_public_unread_messages_counter_for_mentions_relogin, id: 700718
    Device sessions

    49. test_group_offline_pn, id: 3998
    Device sessions

    50. test_public_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    51. test_recover_validation_seed_phrase_field, id: 700750
    Device sessions

    52. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    53. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    54. test_dapps_permissions, id: 5738
    Device sessions

    55. test_group_pn_system_messages_when_invited, id: 3994
    Device sessions

    56. test_group_decline_invite_chat_highligted, id: 5756
    Device sessions

    57. test_public_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    58. test_public_unread_messages_counter, id: 5360
    Device sessions

    59. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    60. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    61. test_public_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    62. test_public_message_delete, id: 700735
    Device sessions

    63. test_copy_and_paste_messages, id: 5317
    Device sessions

    64. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    65. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    66. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    67. test_group_join_send_text_messages_pn, id: 700731
    Device sessions

    68. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    69. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    @churik churik self-assigned this Feb 23, 2022
    @status-im-auto
    Copy link
    Member

    73% of end-end tests have passed

    Total executed tests: 11
Failed tests: 3
Passed tests: 8

    IDs of failed tests: 700747,6263,6228

    Failed tests (3)

    Click to expand
  • Rerun tests

    • 1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Tap on found: Button
    Device 1: Wait for element 'Button' for max 10s and click when it is available

    Device 1: Button by accessibility id:`maybe-later` is not found on the screen

    Device sessions

    2. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="STT"]`

    Device 1: Button by xpath: `//*[@text="STT"]` is not found on the screen

    Device sessions

    3. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    Passed tests (8)

    Click to expand

    1. test_onboarding_share_contact_address, id: 700743
    Device sessions

    2. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    3. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    4. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    6. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    7. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    8. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    @churik churik moved this from CONTRIBUTOR to IN TESTING in Pipeline for QA Feb 23, 2022
    @churik churik moved this from IN TESTING to MERGE in Pipeline for QA Feb 23, 2022
    @rasom rasom force-pushed the fix/#13104-deadlock-on-checking-pending-notification branch from 1c0d16a to e8e7014 Compare February 23, 2022 20:17
    @rasom rasom merged commit e8e7014 into develop Feb 23, 2022
    Pipeline for QA automation moved this from MERGE to DONE Feb 23, 2022
    @rasom rasom deleted the fix/#13104-deadlock-on-checking-pending-notification branch February 23, 2022 20:18
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    Assignees

    @rasom rasom

    @churik churik

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Data added before sync is not synced if Activity center contained some notifications before sync
    4 participants
    @rasom @status-im-auto @Parveshdhull @churik