E2e: backup of nicknames, blocked users, ENS #13238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (6)
|
100% of end-end tests have passedPassed tests (1) |
churik
approved these changes
Mar 31, 2022
| home.back_button.click() | ||
|
|
||
| home.just_fyi('Block user') | ||
| from tests.users import chat_users |
There was a problem hiding this comment.
better to move it to the top of the file, we mostly import modules there
| profile.element_by_text(basic_user["username"]) | ||
| if not profile.element_by_text(basic_user['username']).is_element_displayed(): | ||
| self.driver.fail("Contact was not backed up!") | ||
| profile.element_by_text(nickname) |
There was a problem hiding this comment.
this row does nothing; can be removed
| self.errors.append('Nickname of contact was not backed up') | ||
|
|
||
| sign_in.just_fyi('Check backup of ENS contact') | ||
| profile.element_by_text('@%s' % ens_user['ens']) |
There was a problem hiding this comment.
this row does nothing; can be removed
qoqobolo
force-pushed
the
tests/test-extended-contacts-backup
branch
from
df47ffd
to
335ea9e
Compare
qoqobolo
force-pushed
the
tests/test-extended-contacts-backup
branch
from
335ea9e
to
78864c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test adds checks for backup of blocked and ENS users, nicknames for contact and non-contact users.