Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: activity center medium group #13276

Merged
merged 1 commit into from
May 16, 2022
Merged

e2e: activity center medium group #13276

merged 1 commit into from
May 16, 2022

Conversation

qoqobolo
Copy link
Contributor

@qoqobolo qoqobolo commented Apr 13, 2022 •
edited

Group of medium tests for the activity center

@qoqobolo qoqobolo added the tests label Apr 13, 2022
@qoqobolo qoqobolo self-assigned this Apr 13, 2022
@qoqobolo qoqobolo requested a review from churik as a code owner April 13, 2022 14:28
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 13, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Apr 13, 2022 •
edited

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 24e28b8 #1 2022-04-13 14:40:08 ~11 min android 📄log
✔️ 24e28b8 #1 2022-04-13 14:40:24 ~11 min android-e2e 📦apk 📲
✔️ 24e28b8 #1 2022-04-13 14:47:20 ~18 min ios 📦ipa 📲
❌ b000802 #2 2022-05-13 13:02:36 ~21 sec ios 📄log
❌ b000802 #2 2022-05-13 13:02:43 ~28 sec android 📄log
❌ b000802 #2 2022-05-13 13:02:43 ~29 sec android-e2e 📄log
✔️ 3104f35 #3 2022-05-13 13:39:16 ~11 min android-e2e 📦apk 📲
✔️ 3104f35 #3 2022-05-13 13:39:16 ~11 min android 📦apk 📲
✔️ 3104f35 #3 2022-05-13 13:40:17 ~12 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2c07d2e #4 2022-05-16 09:14:35 ~11 min android-e2e 📦apk 📲
✔️ 2c07d2e #4 2022-05-16 09:14:40 ~11 min android 📦apk 📲
✔️ 2c07d2e #4 2022-05-16 09:15:42 ~12 min ios 📦ipa 📲
✔️ c3e5997 #5 2022-05-16 09:19:08 ~10 min android-e2e 📦apk 📲
✔️ c3e5997 #5 2022-05-16 09:19:23 ~11 min ios 📦ipa 📲
✔️ c3e5997 #5 2022-05-16 09:19:31 ~11 min android 📦apk 📲

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 4
Failed tests: 0
Passed tests: 4

Passed tests (4)

Click to expand

1. test_activity_center_reject_chats, id: 702183
Device sessions

2. test_activity_center_notifications_on_mentions_in_groups_and_communities_empty_state, id: 702185
Device sessions

3. test_activity_center_accept_chats_only_from_contacts, id: 702187
Device sessions

4. test_activity_center_accept_chats, id: 702184
Device sessions

churik
churik approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@churik churik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
1 test - should be split into several, as there is no need to create a community only for 1 check within the whole group
All other requested things are minor changes.

test/appium/tests/atomic/chats/test_activity_center.py Outdated
self.home_1.home_button.double_click()

self.device_1.just_fyi('Device1 rejects both chats and verifies they disappeared and not in Chats too')
self.home_1.notifications_button.click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to replace here self.home_1.notifications_unread_badge.wait_and_click(wait_time) as it may be that chats won't appear quickly and appium may not find them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

test/appium/tests/atomic/chats/test_activity_center.py Outdated
self.home_1.notifications_select_button.click()
self.home_1.element_by_text_part(self.username_2[:10]).click()
self.home_1.element_by_text_part(self.group_chat_name_1).click()
self.home_1.notifications_reject_and_delete_button.click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this action close the activity centre?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. We need to check first that there are no chats anymore after rejection (lines 44-47).
We go to the home screen on line 48

test/appium/tests/atomic/chats/test_activity_center.py Outdated
self.errors.append("Group chat is added on home after rejection")

self.home_1.just_fyi("Verify there are still no chats after relogin")
self.home_1.relogin()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use reopen_app instead - works faster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

test/appium/tests/atomic/chats/test_activity_center.py Outdated

self.device_1.just_fyi('Device1 accepts both chats (via Select All button) and verifies they disappeared '
'from activity center view but present on Chats view')
self.home_1.notifications_button.click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to replace here self.home_1.notifications_unread_badge.wait_and_click(wait_time) as it may be that chats won't appear quickly and appium may not find them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

test/appium/tests/atomic/chats/test_activity_center.py Outdated
self.errors.verify_no_errors()

@marks.testrail_id(702185)
def test_activity_center_notifications_on_mentions_in_groups_and_communities_empty_state(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to remove creating community from group of tests and add simple check to the community [695842] itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

churik
churik reviewed Apr 13, 2022
View reviewed changes
test/appium/tests/atomic/chats/test_activity_center.py Outdated
self.device_1_one_to_one_chat.close_button.click()

self.device_1.just_fyi('Device1 removes 1-1 chat from home screen (for the next test)')
self.home_1.home_button.double_click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to do preparation for next test in next test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA Apr 14, 2022
@qoqobolo qoqobolo force-pushed the tests/refactoring-activity-center branch 2 times, most recently from b000802 to 3104f35 Compare May 13, 2022 13:27
@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 4
Failed tests: 0
Passed tests: 4

Passed tests (4)

Click to expand

1. test_activity_center_reject_chats, id: 702183

Class: TestActivityCenterMultipleDeviceMedium

Device sessions

2. test_activity_center_notifications_on_mentions_in_groups_and_empty_state, id: 702185

Class: TestActivityCenterMultipleDeviceMedium

Device sessions

3. test_activity_center_accept_chats_only_from_contacts, id: 702187

Class: TestActivityCenterMultipleDeviceMedium

Device sessions

4. test_activity_center_accept_chats, id: 702184

Class: TestActivityCenterMultipleDeviceMedium

Device sessions

@qoqobolo qoqobolo force-pushed the tests/refactoring-activity-center branch from 2c07d2e to c3e5997 Compare May 16, 2022 09:07
@qoqobolo qoqobolo merged commit c3e5997 into develop May 16, 2022
Pipeline for QA automation moved this from CONTRIBUTOR to DONE May 16, 2022
@qoqobolo qoqobolo deleted the tests/refactoring-activity-center branch May 16, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@churik churik churik approved these changes

Assignees

@qoqobolo qoqobolo

Labels
tests
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qoqobolo @status-im-auto @churik @cammellos