Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgarde to Xcode 13.3.1 #13324

Merged
merged 1 commit into from
May 6, 2022
Merged

ci: upgarde to Xcode 13.3.1 #13324

merged 1 commit into from
May 6, 2022

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented May 5, 2022

App store now requires all applications to be built with XCode 13: https://developer.apple.com/news/?id=2t1chhp3

Related: https://github.com/status-im/infra-ci/issues/48

@jakubgs jakubgs self-assigned this May 5, 2022
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 5, 2022
@status-im-auto
Copy link
Member

status-im-auto commented May 5, 2022

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
0bb8b51 #1 2022-05-05 12:49:44 ~3 min ios 📄log
✔️ 0bb8b51 #1 2022-05-05 12:57:36 ~11 min android-e2e 📦apk 📲
✔️ 0bb8b51 #1 2022-05-05 12:57:43 ~11 min android 📦apk 📲
✔️ 0bb8b51 #2 2022-05-05 13:07:05 ~12 min ios 📦ipa 📲
✔️ b5f2218 #2 2022-05-05 13:19:33 ~11 min android-e2e 📦apk 📲
✔️ b5f2218 #2 2022-05-05 13:19:34 ~11 min android 📦apk 📲
✔️ b5f2218 #3 2022-05-05 13:21:55 ~13 min ios 📦ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
3527609 #4 2022-05-06 16:21:23 ~4 min ios 📄log
✔️ 3527609 #3 2022-05-06 16:28:05 ~10 min android-e2e 📦apk 📲
✔️ 3527609 #3 2022-05-06 16:28:17 ~11 min android 📦apk 📲
✔️ 37db8c8 #4 2022-05-06 17:25:26 ~11 min android 📦apk 📲
✔️ 37db8c8 #4 2022-05-06 17:25:33 ~11 min android-e2e 📦apk 📲
✔️ 37db8c8 #5 2022-05-06 17:26:42 ~12 min ios 📦ipa 📲

@jakubgs
Copy link
Member Author

jakubgs commented May 5, 2022

Looks like the Go build issues experienced by some devs are related to Xcode 13.3:

/nix/store/z6cp2113drrp94wmr48xr8lwvqw4f0k2-gomobile-unstable-2021-06-14/bin/gomobile: darwin-amd64: go build -tags ios -v -ldflags -extldflags=-Wl,--allow-multiple-definition -X github.com/status-im/status-go/params.GitCommit=640793fe85d9a9eef9eb3712cda1c5a1ceea401a -X github.com/status-im/status-go/params.Version=0.98.5 -s -w -buildmode=c-archive -o /private/tmp/nix-build-status-go-0.98.5-640793f-ios.drv-0/gomobile-work/Statusgo-amd64.a ./gobind failed: exit status 2

error: builder for '/nix/store/8igs5wd87ldbmbl3iclm0l8wxpj0015v-status-go-0.98.5-640793f-ios.drv' failed with exit code 1;
       last 10 log lines:
       > github.com/status-im/status-go/vendor/github.com/golang/protobuf/ptypes
       > github.com/status-im/status-go/vendor/github.com/ethereum/go-ethereum/accounts/usbwallet/trezor
       > github.com/status-im/status-go/vendor/github.com/status-im/go-waku/waku/v2/protocol/pb
       > github.com/status-im/status-go/vendor/github.com/vacp2p/mvds/store
       > github.com/status-im/status-go/vendor/github.com/vacp2p/mvds/transport
       > github.com/status-im/status-go/vendor/github.com/prometheus/client_golang/prometheus/internal
       > github.com/status-im/status-go/vendor/zombiezen.com/go/sqlite
       > github.com/status-im/status-go/vendor/zombiezen.com/go/sqlite/sqlitex
       > /nix/store/z6cp2113drrp94wmr48xr8lwvqw4f0k2-gomobile-unstable-2021-06-14/bin/gomobile: darwin-amd64: go build -tags ios -v -ldflags -extldflags=-Wl,--allow-multiple-definition -X github.com/status-im/status-go/params.GitCommit=640793fe85d9a9eef9eb3712cda1c5a1ceea401a -X github.com/status-im/status-go/params.Version=0.98.5 -s -w -buildmode=c-archive -o /private/tmp/nix-build-status-go-0.98.5-640793f-ios.drv-0/gomobile-work/Statusgo-amd64.a ./gobind failed: exit status 2

https://ci.status.im/job/status-react/job/prs/job/ios/job/PR-13324/1/console

With no clear error beyond ./gobind failed: exit status 2 which isn't very helpful.

EDIT: Second pass worked fine, really weird.

@jakubgs jakubgs marked this pull request as ready for review May 6, 2022 08:46
@jakubgs jakubgs moved this from REVIEW to E2E Tests in Pipeline for QA May 6, 2022
@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 84
Failed tests: 1
Passed tests: 83
IDs of failed tests: 700762 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • 1. test_wallet_add_account_seed_phrase_collectibles_rinkeby_set_as_profile_image, id: 700762

    Device 1: Find `Text` by `xpath`: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView`
    Device 1: Find `Text` by `xpath`: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView`

    Device 1: Text by xpath: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` is not found on the screen

    Class: TestWalletManagementDeviceMerged

    Device sessions

    Passed tests (83)

    Click to expand

    1. test_wallet_manage_assets, id: 700758

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_public_chat_message_edit, id: 700734

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    3. test_contact_block_unblock_public_chat_offline, id: 702176
    4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    5. test_keycard_relogin_after_restore, id: 700768

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    6. test_group_chat_push_system_messages_when_invited, id: 3994

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    7. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    8. test_send_tx_token_7_decimals, id: 700764

    Class: TestSendTxDeviceMerged

    Device sessions

    9. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
    10. test_public_chat_open_using_deep_link, id: 700739

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    11. test_public_chat_unread_messages_counter, id: 5360

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    12. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    13. test_pairing_sync_contacts_block_unblock, id: 702196

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    14. test_public_chat_emoji_send_copy_paste_reply, id: 700719

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    15. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    16. test_browser_bookmarks_create_edit_remove, id: 702077

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    17. test_send_tx_eth_check_logcat, id: 700763

    Class: TestSendTxDeviceMerged

    Device sessions

    18. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    19. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

    Class: TestSendTxDeviceMerged

    Device sessions

    20. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    21. test_public_chat_delete_chat_long_press, id: 5319

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    22. test_onboarding_home_initial_popup, id: 700742

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    23. test_browser_blocked_url, id: 702072

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    24. test_wallet_add_hide_unhide_account_private_key, id: 700761

    Class: TestWalletManagementDeviceMerged

    Device sessions

    25. test_1_1_chat_message_reaction, id: 6315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    26. test_ens_mention_push_highlighted_public_chat, id: 702156

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    27. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    28. test_1_1_chat_image_send_save_reply, id: 6305

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    29. test_1_1_chat_emoji_and_link_send_and_open, id: 5373

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    30. test_public_chat_link_send_open, id: 700736

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    31. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
    32. test_onboarding_share_contact_address, id: 700743

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    33. test_sticker_1_1_public_chat, id: 702157

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    34. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    35. test_restore_set_up_wallet_sign_phrase, id: 700749

    Class: TestRestoreOneDeviceMerged

    Device sessions

    36. test_ens_mention_nickname_1_1_chat, id: 702155

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    37. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    38. test_browser_delete_close_tabs, id: 702076

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    39. test_public_chat_mark_all_messages_as_read, id: 6270

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    40. test_browser_connection_is_secure_not_secure_warning, id: 702073

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    41. test_send_tx_set_recipient_options, id: 700757

    Class: TestSendTxDeviceMerged

    Device sessions

    42. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    43. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

    Class: TestSendTxDeviceMerged

    Device sessions

    44. test_group_chat_join_send_text_messages_push, id: 700731

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    45. test_browser_web3_permissions_testdapp, id: 702078

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    46. test_1_1_chat_text_message_with_push, id: 6316

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    47. test_wallet_add_delete_watch_only_account, id: 700760

    Class: TestWalletManagementDeviceMerged

    Device sessions

    48. test_group_chat_decline_invite_chat_highligted, id: 5756

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    49. test_public_chat_tag_message, id: 700738

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    50. test_onboarding_share_wallet_address, id: 700744

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    51. test_keycard_create_account_unlock_same_seed, id: 5689

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    52. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    53. test_pairing_sync_initial_contacts_blocked_users, id: 702194

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    54. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    55. test_pairing_sync_1_1_chat_message, id: 702198

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    56. test_pairing_sync_public_chat_add_remove, id: 702199

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    57. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    58. test_public_chat_fetch_more_history, id: 5675

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    59. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

    Class: TestWalletManagementDeviceMerged

    Device sessions

    60. test_group_chat_offline_pn, id: 3998

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    61. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
    62. test_group_chat_add_new_member_activity_centre, id: 700732

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    63. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    64. test_ens_purchased_in_profile, id: 702152

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    65. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    66. test_keycard_send_tx_eth, id: 700767

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    67. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Class: TestRestoreOneDeviceMerged

    Device sessions

    68. test_browser_offline, id: 702075

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    69. test_browser_invalid_url, id: 702074

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    70. test_restore_seed_phrase_field_validation, id: 700750

    Class: TestRestoreOneDeviceMerged

    Device sessions

    71. test_wallet_add_account_generate_new, id: 700759

    Class: TestWalletManagementDeviceMerged

    Device sessions

    72. test_start_new_chat_public_key_validation, id: 702158

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    73. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

    Class: TestRestoreOneDeviceMerged

    Device sessions

    74. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    75. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

    Class: TestWalletManagementDeviceMerged

    Device sessions

    76. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
    77. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    78. test_group_chat_leave_relogin, id: 3997

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    79. test_public_chat_message_delete, id: 700735

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    80. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    81. test_1_1_chat_push_emoji, id: 6283

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    82. test_pairing_sync_initial_public_chats, id: 702195

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    83. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    @qoqobolo qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA May 6, 2022
    @qoqobolo qoqobolo self-assigned this May 6, 2022
    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented May 6, 2022

    @jakubgs thanks for PR, looks good (except for a few UI issues on iOS which will be logged separately).

    App store now requires all applications to be built with XCode 13:
    https://developer.apple.com/news/?id=2t1chhp3
    
    Related: status-im/infra-ci#48
    
    Signed-off-by: Jakub Sokołowski <jakub@status.im>
    @jakubgs jakubgs merged commit 6f45b5c into develop May 6, 2022
    Pipeline for QA automation moved this from MERGE to DONE May 6, 2022
    @jakubgs jakubgs deleted the ci/upgrade-xcode branch May 6, 2022 17:27
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    None yet

    4 participants