-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: fortify the nix-update-gradle process #13369
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parveshdhull
approved these changes
May 17, 2022
Jenkins BuildsClick to see older builds (9)
|
jakubgs
force-pushed
the
nix/fix-gradle-update
branch
3 times, most recently
from
May 18, 2022 08:28
6601024
to
27219eb
Compare
Since @flexsurfer was having weird random failures to fetch POMs and JARs:
I've added a limit on the number of |
flexsurfer
approved these changes
May 18, 2022
jakubgs
force-pushed
the
nix/fix-gradle-update
branch
from
May 18, 2022 09:03
27219eb
to
43f7aaf
Compare
@flexsurfer checked the logs for the fetch failures and it appears they are timeouts:
Which might still be rate-limiting - though a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues with the
nix-update-gradle
target:This makes the process more robust, since we can see something is missing right away, and a developer may re-run the process to take account of possible temporary networking failures or rate limiting.
It also slims down the size of the
deps.json
by removing dependencies which contribute no actual JARs or AARs to the build process.Also limited the number of jobs started by
parallel
fornix/deps/gradle/url2json.sh
to limit possibility of rate limiting.