-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#13357] 'Unknown Not a contact' screen with endless spinner when sta… #13379
Conversation
Jenkins BuildsClick to see older builds (18)
|
0310b95
to
9546a0e
Compare
75% of end-end tests have passed
Failed tests (21)Click to expand
Passed tests (63)Click to expand
|
@flexsurfer thanks for the fix! Judging by the first e2e run the issue is not reproducible anymore. But here’s another problem that’s been found at this point ISSUE 1: Light/dark mode of the
|
thanks @qoqobolo , fixed |
77% of end-end tests have passed
Failed tests (19)Click to expand
Passed tests (65)Click to expand
|
5% of end-end tests have passed
Failed tests (18)Click to expand
Passed tests (1)Click to expand
|
76% of end-end tests have passed
Failed tests (20)Click to expand
Passed tests (64)Click to expand
|
70% of end-end tests have passed
Failed tests (52)Click to expand
Passed tests (123)Click to expand
|
ba98668
to
2e54b14
Compare
ISSUE 2: If repeatedly tap the top bar in 1-1 chat, then the profile will also be opened several times (Android only)The issue is presented in develop as well. video_2022-05-23_12-42-56.mp4 |
2e54b14
to
941b3e5
Compare
thanks @qoqobolo fixed |
@flexsurfer thanx for the fixes! A new one ISSUE 3: Error when creating and joining a group chatvideo_2022-05-23_15-39-29.mp4Steps:
OS: iOS, Android |
thanks @qoqobolo fixed |
64% of end-end tests have passed
Failed tests (63)Click to expand
Passed tests (112)Click to expand
|
@flexsurfer found another way to reproduce the ISSUE 4: The screen appears if open a 1-1 chat, open a user profile and then quickly close the profile and tap
|
78% of end-end tests have passed
Failed tests (13)Click to expand
Passed tests (47)Click to expand
|
54% of end-end tests have passed
Failed tests (6)Click to expand
Passed tests (7)Click to expand
|
50% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (2)Click to expand
|
100% of end-end tests have passed
Passed tests (1)Click to expand
|
@flexsurfer e2e are fixed in #13393, so ready to go after the fix #13379 (comment) Also please ignore 2a0e2afe612ffdb6932be343e3922d58ff8176dd, all required fixes are already included into #13393 |
…rting new 1-1 or public chat / opening it via push notification
015ceb1
to
a081584
Compare
92% of end-end tests have passed
Failed tests (5)Click to expand
Passed tests (55)Click to expand
|
@churik thanks for your help with e2e, @flexsurfer thanks for finding a solution to the issue and your patience. |
It's an awful solution, but its the only way to fix it, the big problem with react-native-navigation, is because of its native nature, now we have two states, one state is visible on the screen in native, and one in js thread, so when we close the screen by native button we don't have information in js thread that screen is closed until it will be unmounted, but at that moment there might be another screen visible and active for some time, also there is no control on hardware back button, so its hard to sync states
fixes: #13357
fixes: #12507