Implementation of new UI toggle #13384

Parveshdhull · 2022-05-22T22:59:50Z

fixes #13370

Summary:

PR implement toggle for enabling new UI at runtime

Note:

New UI is only optimized for android
The browser tab is being used for accessing the user profile for disabling the new UI

Development:

Screens added to the screen-overwrites function will replace current screens on enabling UI toggle
home-stack.cljs file is used for changing current home screen tabs content
Only one navigation2 dispatch is used for now :chat.ui/navigate-to-chat-nav2 for opening chats without topbar for switcher. You can remove this call if you need the top bar in chat.

cc: @briansztamfater @jo-mut

Testing:

Please check for regressions
Please smoke test the new UI for basic flow

status: ready

status-im-auto · 2022-05-22T23:09:21Z

Jenkins Builds

Click to see older builds (18)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`98585eb`	#1	2022-05-22 23:09:21	~9 min	`android-e2e`	📦`apk` 📲
✔️	`98585eb`	#1	2022-05-22 23:09:27	~9 min	`android`	📦`apk` 📲
✔️	`98585eb`	#1	2022-05-22 23:09:58	~9 min	`ios`	📦`ipa` 📲

✔️	`48ac7fc`	#2	2022-05-22 23:30:57	~9 min	`android`	📦`apk` 📲
✔️	`48ac7fc`	#2	2022-05-22 23:30:57	~9 min	`android-e2e`	📦`apk` 📲
✔️	`48ac7fc`	#2	2022-05-22 23:31:19	~9 min	`ios`	📦`ipa` 📲

✔️	`dbc3c7e`	#3	2022-05-23 23:11:42	~9 min	`ios`	📦`ipa` 📲
✔️	`dbc3c7e`	#3	2022-05-23 23:12:31	~10 min	`android-e2e`	📦`apk` 📲
✔️	`dbc3c7e`	#3	2022-05-23 23:13:01	~10 min	`android`	📦`apk` 📲

✔️	`b95ef1b`	#4	2022-05-23 23:41:13	~10 min	`android-e2e`	📦`apk` 📲
✔️	`b95ef1b`	#4	2022-05-23 23:41:31	~10 min	`android`	📦`apk` 📲
✔️	`b95ef1b`	#4	2022-05-23 23:45:20	~14 min	`ios`	📦`ipa` 📲

✔️	`4302c02`	#5	2022-05-23 23:45:20	~10 min	`ios`	📦`ipa` 📲
✔️	`4302c02`	#5	2022-05-23 23:45:23	~10 min	`android`	📦`apk` 📲
✔️	`4302c02`	#5	2022-05-23 23:46:54	~12 min	`android-e2e`	📦`apk` 📲

✔️	`6f74491`	#6	2022-05-24 11:32:54	~9 min	`ios`	📦`ipa` 📲
✔️	`6f74491`	#6	2022-05-24 11:34:18	~11 min	`android`	📦`apk` 📲
✔️	`6f74491`	#6	2022-05-24 11:36:02	~13 min	`android-e2e`	📦`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`9b71059`	#7	2022-05-25 16:08:13	~9 min	`android`	📦`apk` 📲
✔️	`9b71059`	#7	2022-05-25 16:08:47	~10 min	`android-e2e`	📦`apk` 📲
✔️	`9b71059`	#7	2022-05-25 16:09:49	~11 min	`ios`	📦`ipa` 📲

✔️	`4c8b80f`	#8	2022-05-25 16:10:23	~10 min	`ios`	📦`ipa` 📲
✔️	`4c8b80f`	#8	2022-05-25 16:18:17	~18 min	`android`	📦`apk` 📲
✔️	`4c8b80f`	#8	2022-05-25 16:18:36	~18 min	`android-e2e`	📦`apk` 📲

flexsurfer

could you also please add new wallet screen

src/status_im/navigation2/screens.cljs

src/status_im/ui/screens/advanced_settings/views.cljs

Parveshdhull · 2022-05-24T09:04:29Z

could you also please add new wallet screen

Yes, the new wallet redesign is enabled. home-stack.cljs

src/status_im/multiaccounts/login/core.cljs

src/status_im/navigation2/home_stack.cljs

Parveshdhull · 2022-05-24T13:00:27Z

Thank you @flexsurfer for reviewing PR

status-im-auto · 2022-05-24T14:20:03Z

94% of end-end tests have passed

Total executed tests: 84
Failed tests: 5
Passed tests: 79

IDs of failed tests: 700762,702156,700743,702157,700744

Failed tests (5)

Click to expand

Rerun failed tests

1. test_wallet_add_account_seed_phrase_collectibles_rinkeby_set_as_profile_image, id: 700762
Device 1: Find `Text` by `xpath`: `//[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` Device 1: Find `Text` by `xpath`: `//[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` Device 1: Text by xpath: `//[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` is not found on the screen Class: TestWalletManagementDeviceMerged* Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_ens_mention_push_highlighted_public_chat, id: 702156
Device 2: Find `Button` by `xpath`: `//[starts-with(@text,'statuse2e.eth')]` Device 2: Image differs from template to 8.533342434284855 percents `Mention is not highlighted!` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_onboarding_share_contact_address, id: 700743
## 1-1 chat is created successfully! Device 1: Find `EditBox` by `accessibility id`: `chat-message-input` Device 1: EditBox by accessibility id: `chat-message-input` is not found on the screen Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_sticker_1_1_public_chat, id: 702157
## Public chat 'dcbilry' is created successfully! Device 1: Find `Button` by `accessibility id`: `show-stickers-icon` Device 1: Button by accessibility id: `show-stickers-icon` is not found on the screen Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
5. test_onboarding_share_wallet_address, id: 700744
Device 1: Looking for chat: '#kqhnhrl' Device 1: Wait for element `Button` for max 30s and click when it is available Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen after wait_for_visibility_of_element Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (79)

Click to expand

1. test_wallet_manage_assets, id: 700758
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_public_chat_message_edit, id: 700734
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_contact_block_unblock_public_chat_offline, id: 702176
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_keycard_relogin_after_restore, id: 700768
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_group_chat_push_system_messages_when_invited, id: 3994
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
7. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_send_tx_token_7_decimals, id: 700764
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
9. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_public_chat_open_using_deep_link, id: 700739
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
11. test_public_chat_unread_messages_counter, id: 5360
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
12. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
13. test_pairing_sync_contacts_block_unblock, id: 702196
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
14. test_public_chat_emoji_send_copy_paste_reply, id: 700719
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
15. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
16. test_browser_bookmarks_create_edit_remove, id: 702077
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
17. test_send_tx_eth_check_logcat, id: 700763
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
18. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
19. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
20. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
21. test_public_chat_delete_chat_long_press, id: 5319
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
22. test_onboarding_home_initial_popup, id: 700742
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
23. test_browser_blocked_url, id: 702072
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
24. test_wallet_add_hide_unhide_account_private_key, id: 700761
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
25. test_1_1_chat_message_reaction, id: 6315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
26. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
27. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
28. test_1_1_chat_image_send_save_reply, id: 6305
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
29. test_public_chat_link_send_open, id: 700736
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
30. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
31. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
32. test_restore_set_up_wallet_sign_phrase, id: 700749
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
33. test_ens_mention_nickname_1_1_chat, id: 702155
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
34. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
35. test_browser_delete_close_tabs, id: 702076
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
36. test_public_chat_mark_all_messages_as_read, id: 6270
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
37. test_browser_connection_is_secure_not_secure_warning, id: 702073
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
38. test_send_tx_set_recipient_options, id: 700757
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
39. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
40. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
41. test_group_chat_join_send_text_messages_push, id: 700731
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
42. test_browser_web3_permissions_testdapp, id: 702078
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
43. test_1_1_chat_text_message_with_push, id: 6316
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
44. test_wallet_add_delete_watch_only_account, id: 700760
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
45. test_group_chat_decline_invite_chat_highligted, id: 5756
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
46. test_public_chat_tag_message, id: 700738
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
47. test_keycard_create_account_unlock_same_seed, id: 5689
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
48. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
49. test_pairing_sync_initial_contacts_blocked_users, id: 702194
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
50. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
51. test_pairing_sync_1_1_chat_message, id: 702198
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
52. test_pairing_sync_public_chat_add_remove, id: 702199
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
53. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
54. test_public_chat_fetch_more_history, id: 5675
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
55. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
56. test_group_chat_offline_pn, id: 3998
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
57. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
58. test_group_chat_add_new_member_activity_centre, id: 700732
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
59. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
60. test_ens_purchased_in_profile, id: 702152
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
61. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
62. test_keycard_send_tx_eth, id: 700767
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
63. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
64. test_browser_offline, id: 702075
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
65. test_browser_invalid_url, id: 702074
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
66. test_restore_seed_phrase_field_validation, id: 700750
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
67. test_wallet_add_account_generate_new, id: 700759
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
68. test_start_new_chat_public_key_validation, id: 702158
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
69. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
70. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
71. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
72. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
73. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
74. test_group_chat_leave_relogin, id: 3997
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
75. test_public_chat_message_delete, id: 700735
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
76. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
77. test_1_1_chat_push_emoji, id: 6283
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
78. test_pairing_sync_initial_public_chats, id: 702195
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
79. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2022-05-24T15:44:20Z

85% of end-end tests have passed

Total executed tests: 89
Failed tests: 13
Passed tests: 76
Not executed tests: 85

IDs of not executed tests: 6253,6265,6263,6315,6316,5373,695843,5315,6283,6305,5310,5387,5313,700734,700735,700719,5360,700718,5319,700736,700737,6270,5675,5396,5317,700738,700739,3994,700731,700732,3998,5756,3997,702152,702153,702155,702156,702157,702158,700742,700743,700744,700745,700746,700747,700748,700749,702189,700750,700756,700758,700759,700760,700761,700762,700766,700763,700764,700765,700757,5342,700767,700768,700769,700770,5689,702072,702073,702074,702075,702076,702077,702078,702186,702175,702176,702188,702177,702194,702195,702196,702197,702198,702199,702292

IDs of failed tests: 6292,702287,702286,702296,702250,702295,702291,702285,702284,702065,702294,6225,702293

Not executed tests (85)

Click to expand

Rerun not executed tests

Failed tests (13)

Click to expand

Rerun failed tests

1. test_keycard_send_funds_between_accounts_set_max_in_multiaccount_instance, id: 6292
Device 1: Find `SignWithKeycardButton` by `xpath`: `//*[contains(@text,'Sign with')]` Device 1: Enter default pin 111111 Device 1: `SilentButton` by `accessibility id`:`numpad-button-1` not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_profile_can_not_connect_to_custom_history_node_add_delete, id: 702287
Test setup failed: Device `1`: `EditBox` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Class: TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium
3. test_profile_use_history_node_disable_enable, id: 702286
Test setup failed: Device `1`: `EditBox` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Class: TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium
4. test_block_user_from_1_1_chat_header_check_mentions_and_push_notification_service, id: 702296
Test setup failed: Device `2`: `EditBox` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Class: TestChatKeycardMentionsMediumMultipleDevice
5. test_chat_public_clear_history_via_options_and_long_press, id: 702250
## Public chat 'public-clear-options' is created successfully! Device 1: Sending message 'test message' Device `1`: `EditBox` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs Failure screenshot
6. test_keycard_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline_opened_from_push, id: 702295
Test setup failed: Device `2`: `EditBox` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Class: TestChatKeycardMentionsMediumMultipleDevice
7. test_scan_qr_with_scan_contact_code_via_start_chat, id: 702291
Device 1: Find `Button` by `xpath`: `//[@text='OK' or @text='Ok']` Device 1: Tap on found: Button `In "ens_with_stateofus_domain_deep_link" case chat input is not found after scanning, so no redirect to 1-1 In "ens_with_stateofus_domain_deep_link" case "@nastya" not found after scanning In "ens_another_domain_deep_link" case chat input is no` Class: TestPermissionsScanQrOneDevice* Device sessions Device 1: Steps, video, logs Failure screenshot
8. test_profile_custom_bootnodes_enable_disable, id: 702285
Test setup failed: Device `1`: `EditBox` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Class: TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium
9. test_public_chat_timeline_different_statuses_reaction, id: 702284
## Public chat 'ixkugct' is created successfully! Device 1: Sending message 'hello' Test setup failed: Device `1`: `EditBox` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Class: TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
10. test_chat_public_markdown_support, id: 702065
Device 2: Looking for a message by text: quote reply (one row) Device 1: Looking for a message by text: quote reply (one row) italic text in underscore is not displayed with markdown in 1-1 chat for the recipient code blocks is not displayed with markdown in 1-1 chat for the recipient</code><br/><br/><p><b>Class: TestChatMediumMultipleDevice</b></p><ins>Device sessions</ins><p><ul><p>Device 1:<ul><li><a href="https://saucelabs.com/jobs/32a44e0338cb4ec5b1c2efda8e6bd96b?auth=c7a3cc0b7d99be9518bfeb148d22c1d4#267">Steps, video, logs</a></li><li><a href="https://assets.saucelabs.com/jobs/32a44e0338cb4ec5b1c2efda8e6bd96b/0191screenshot.png?auth=c7a3cc0b7d99be9518bfeb148d22c1d4">Failure screenshot</a></li></ul></p><p>Device 2:<ul><li><a href="https://saucelabs.com/jobs/f26c0af8a5284fea9be2a6154f9bfec8?auth=f290dda0af406d898faea6241ef148a3#345">Steps, video, logs</a></li><li><a href="https://assets.saucelabs.com/jobs/f26c0af8a5284fea9be2a6154f9bfec8/0155screenshot.png?auth=f290dda0af406d898faea6241ef148a3">Failure screenshot</a></li></ul></p></ul></p></td></tr><tr><td><b>11. <a href="https://ethstatus.testrail.net/index.php?/tests/view/2792888">test_chat_1_1_unread_counter_highligted</a>, id: 702294 </b></td></tr><tr><td><p><blockquote><div>## 1-1 chat is created successfully!</div><div>Device 2: Sending message 'test message' </div></blockquote></p><code>Test setup failed: `Device 2: EditBox by accessibility id: chat-message-input is not found on the screen after wait_for_element` Class: TestChatKeycardMentionsMediumMultipleDevice Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
12. test_wallet_send_tx_between_accounts_in_multiaccount_instance, id: 6225
Device 1: EditBox element not found Device 1: Find `EditBox` by `accessibility id`: `enter-password-input` `Device 1: EditBox by accessibility id: enter-password-input is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
13. test_scan_qr_different_links_with_universal_qr_scanner, id: 702293
Device 1: Tap on found: Button Device 1: Find `BackButton` by `accessibility id`: `Navigate Up` `No message input is shown in case of navigating to public chat via deep link! Chat name is not shown in case of navigating to public chat via deep link!` Class: TestPermissionsScanQrOneDevice Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (76)

Click to expand

1. test_use_pinned_history_node, id: 5766
Device sessions Device 1: Steps, video, logs
2. test_profile_add_remove_contact_via_contacts_view, id: 702160
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
3. test_profile_invite_friends, id: 702159
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
4. test_profile_privacy_policy_terms_of_use_node_version_need_help, id: 5453
Device sessions Device 1: Steps, video, logs
5. test_browser_refresh_page, id: 702179
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
6. test_wallet_search_asset_and_currency, id: 6269
Device sessions Device 1: Steps, video, logs
7. test_wallet_set_currency, id: 5429
Device sessions Device 1: Steps, video, logs
8. test_wallet_backup_recovery_phrase_warning_from_wallet, id: 5358
Device sessions Device 1: Steps, video, logs
9. test_keycard_settings_pin_puk_pairing, id: 695841
Device sessions Device 1: Steps, video, logs
10. test_browser_open_chat_options, id: 702181
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
11. test_wallet_offline_can_login_cant_send_transaction, id: 5407
Device sessions Device 1: Steps, video, logs
12. test_pairing_sync_initial_community_send_message, id: 702269
Class: TestPairingSyncMediumMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
13. test_browser_resolve_ipns_name, id: 702201
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
14. test_keycard_can_recover_keycard_account_offline_and_add_watch_only_acc, id: 6243
Device sessions Device 1: Steps, video, logs
15. test_chat_group_chat_set_nickname_and_ens_via_group_info_mention, id: 702258
Class: TestChatMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
16. test_chat_group_chat_rename, id: 702098
Class: TestChatMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_browser_connect_revoke_wallet, id: 702180
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
18. test_profile_can_reset_password, id: 702161
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
19. test_group_chat_remove_member, id: 702259
Class: TestGroupChatMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
20. test_testdapp_sign_typed_message_deploy_simple_contract_request_pub_key, id: 5784
Device sessions Device 1: Steps, video, logs
21. test_profile_use_another_fleets_balance_bsc_xdai_advanced_set_nonce, id: 695890
Device sessions Device 1: Steps, video, logs
22. test_wallet_can_change_account_settings, id: 6235
Device sessions Device 1: Steps, video, logs
23. test_profile_show_profile_picture_and_online_indicator_settings, id: 702281
Class: TestProfileGapsCommunityMediumMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
24. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 702244
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
25. test_chat_can_search_while_offline, id: 702254
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
26. test_scan_qr_eip_681_links_via_wallet, id: 702291
Class: TestPermissionsScanQrOneDevice Device sessions Device 1: Steps, video, logs
27. test_keycard_testdapp_sign_typed_message_deploy_simple_contract_send_tx, id: 6310
Device sessions Device 1: Steps, video, logs
28. test_deep_link_open_dapp, id: 702246
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
29. test_profile_add_custom_network, id: 702166
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
30. test_deep_link_open_user_profile, id: 702245
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
31. test_community_create_approve_membership, id: 702283
Class: TestProfileGapsCommunityMediumMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
32. test_share_user_profile_url_browser, id: 702251
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
33. test_group_chat_make_admin, id: 702260
Class: TestGroupChatMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
34. test_browser_back_forward_navigation_history_kept_after_relogin, id: 702150
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
35. test_keycard_onboarding_interruption_access_key_flow, id: 6246
Device sessions Device 1: Steps, video, logs
36. test_group_chat_accept_decline_invite, id: 702261
Class: TestGroupChatMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
37. test_pairing_sync_group_chat_send_different_messages, id: 702273
Class: TestPairingSyncMediumMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
38. test_contacts_unblock_user_is_not_added_back_to_contacts, id: 6213
Device sessions Device 1: Steps, video, logs
39. test_chat_1_1_pin_messages, id: 702069
Class: TestChatMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
40. test_permissions_webview_camera, id: 702290
Class: TestPermissionsScanQrOneDevice Device sessions Device 1: Steps, video, logs
41. test_profile_chat_two_minutes_gap_in_public_and_no_gap_in_1_1_chat_and_group_chat, id: 702282
Class: TestProfileGapsCommunityMediumMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
42. test_profile_change_fleet, id: 702178
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
43. test_chat_pin_messages_in_group_chat, id: 702070
Class: TestChatMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
44. test_browser_new_tab_open, id: 702182
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
45. test_activity_center_notifications_on_mentions_in_groups_and_empty_state, id: 702185
Class: TestActivityCenterMultipleDeviceMedium Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
46. test_can_delete_several_multiaccounts, id: 6318
Device sessions Device 1: Steps, video, logs
47. test_testdapp_wallet_permissions_switching_accounts_in_dapp, id: 6232
Device sessions Device 1: Steps, video, logs
48. test_activity_center_reject_chats_no_pn, id: 702183
Class: TestActivityCenterMultipleDeviceMedium Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
49. test_profile_change_log_level, id: 702165
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
50. test_chat_1_1_push_and_reaction_for_messages_sticker_audio_image, id: 702066
Class: TestChatMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
51. test_profile_backup_of_contacts, id: 702164
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
52. test_share_user_profile_url_one_to_one_chat, id: 702247
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
53. test_keycard_blocked_card_lost_or_frozen_flows, id: 695852
Device sessions Device 1: Steps, video, logs
54. test_permissions_deny_access_camera_and_gallery, id: 702289
Class: TestPermissionsScanQrOneDevice Device sessions Device 1: Steps, video, logs
55. test_keycard_onboarding_interruption_creating_flow, id: 5742
Device sessions Device 1: Steps, video, logs
56. test_recover_accounts_with_certain_seedphrase, id: 5455
Device sessions Device 1: Steps, video, logs
57. test_activity_center_accept_chats_only_from_contacts, id: 702187
Class: TestActivityCenterMultipleDeviceMedium Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
58. test_pairing_sync_community_add_new, id: 702272
Class: TestPairingSyncMediumMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
59. test_browser_open_url_with_non_english_text, id: 702151
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
60. test_share_user_profile_url_public_chat, id: 702252
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
61. test_chat_input_delete_cut_and_paste_messages, id: 702249
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
62. test_chat_block_and_unblock_user_from_group_chat_via_group_info, id: 702097
Class: TestChatMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
63. test_keycard_frozen_card_flows, id: 695851
Device sessions Device 1: Steps, video, logs
64. test_cant_add_more_twenty_participants_to_group_chat, id: 5721
Device sessions Device 1: Steps, video, logs
65. test_wallet_validation_amount_errors, id: 5437
Device sessions Device 1: Steps, video, logs
66. test_keycard_send_tx_eth_to_ens, id: 6295
Device sessions Device 1: Steps, video, logs
67. test_chat_no_suggestions_invalid_data_search, id: 702253
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
68. test_profile_set_primary_ens_custom_domain, id: 6219
Device sessions Device 1: Steps, video, logs
69. test_activity_center_accept_chats, id: 702184
Class: TestActivityCenterMultipleDeviceMedium Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
70. test_pairing_sync_community_add_new_channel, id: 702270
Class: TestPairingSyncMediumMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
71. test_chat_can_start_and_find_from_suggestions_using_search, id: 702248
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
72. test_custom_gas_settings, id: 695855
Device sessions Device 1: Steps, video, logs
73. test_pairing_sync_community_leave, id: 702271
Class: TestPairingSyncMediumMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
74. test_keycard_same_seed_added_inside_multiaccount, id: 6311
Device sessions Device 1: Steps, video, logs
75. test_browser_can_access_images_by_link, id: 702149
Class: TestBrowserProfileOneDevice Device sessions Device 1: Steps, video, logs
76. test_wallet_send_tx_token_set_max, id: 6330
Device sessions Device 1: Steps, video, logs

status-im-auto · 2022-05-25T10:38:54Z

60% of end-end tests have passed

Total executed tests: 5
Failed tests: 2
Passed tests: 3

IDs of failed tests: 702156,700743

Failed tests (2)

Click to expand

Rerun failed tests

1. test_ens_mention_push_highlighted_public_chat, id: 702156
Device 2: Find `Button` by `xpath`: `//[starts-with(@text,'statuse2e.eth')]` Device 2: Image differs from template to 9.34597102244161 percents `Mention is not highlighted!` Class: TestEnsStickersMultipleDevicesMerged* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_onboarding_share_contact_address, id: 700743
Device 1: ChatButton element not found Device 1: Find `ChatButton` by `accessibility id`: `start-1-1-chat-button` Device 1: ChatButton by accessibility id: `start-1-1-chat-button` is not found on the screen Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (3)

Click to expand

1. test_wallet_add_account_seed_phrase_collectibles_rinkeby_set_as_profile_image, id: 700762
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_sticker_1_1_public_chat, id: 702157
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_onboarding_share_wallet_address, id: 700744
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

qoqobolo · 2022-05-25T12:57:04Z

@Parveshdhull thanks for your work! It's so exciting to touch the new UI for the first time! 🤩

Found some issues, but not sure if all of them should be fixed at this stage. So please let me know if some of them are not relevant atm and weren't meant by "smoke test the new UI for basic flow". I'll continue testing with that in mind.

ISSUE 1: The new UI switches to the old one when switching mode (light/dark) in Settings

Steps:

Enable New UI
Settings > Appearance > Switch mode
Keep an eye on tabs

The tabs have become "old" again, although in the settings New UI is still enabled.

video_2022-05-25_14-05-57.mp4

ISSUE 2: The `Close` button of the opened switcher is barely visible in dark mode

ISSUE 3: Dark/light mode in the new UI is reset after reopening the app

Steps:

Enable New UI
Open the second tab
Switch mode
Reopen the app

video_2022-05-25_14-26-48.mp4

ISSUE 4: Dark mode is not applied correctly if the device is in light mode (and vice versa)

Visible in the video above.

And some questions:

Q 5: Chats without topbar

The top bar disappears after reopening the chat but returns after reopening the app.
Can you please confirm if this behavior is expected now?

video_2022-05-25_13-47-40.mp4

Q 6: Should the switcher be hidden when the keyboard is opened?

Q 7: Buttons `Buy`, `Send`, and `Recieve` in Wallet are now inactive. Is it expected?

video_2022-05-25_14-52-55.mp4

Parveshdhull · 2022-05-25T13:19:41Z

Hi @qoqobolo , Thank you very much for testing the PR and finding all these great issues. They all are related to redesign implementation WIP, so I will fix them separately along with issues mentioned in above comment. Thank you

status-im-auto · 2022-05-25T14:46:50Z

0% of end-end tests have passed

Total executed tests: 1
Failed tests: 1
Passed tests: 0

IDs of failed tests: 700743

Failed tests (1)

Click to expand

Rerun failed tests

1. test_onboarding_share_contact_address, id: 700743
Device 1: ChatButton element not found Device 1: Find `ChatButton` by `accessibility id`: `start-1-1-chat-button` Device 1: ChatButton by accessibility id: `start-1-1-chat-button` is not found on the screen Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

status-im-auto · 2022-05-25T15:40:28Z

57% of end-end tests have passed

Total executed tests: 14
Failed tests: 6
Passed tests: 8

IDs of failed tests: 702291,702287,702065,702286,702285,702284

Failed tests (6)

Click to expand

Rerun failed tests

1. test_scan_qr_with_scan_contact_code_via_start_chat, id: 702291
Device 1: Find `Button` by `xpath`: `//[@text='OK' or @text='Ok']` Device 1: Tap on found: Button `In "ens_without_stateofus_domain_deep_link" case chat input is not found after scanning, so no redirect to 1-1 In "ens_without_stateofus_domain_deep_link" case "@nastya" not found after scanning In "ens_another_domain_deep_link" case chat input` Class: TestPermissionsScanQrOneDevice* Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_profile_can_not_connect_to_custom_history_node_add_delete, id: 702287
`Test setup failed: E http.client.RemoteDisconnected: Remote end closed connection without response` `During handling of the above exception, another exception occurred: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without re` Class: TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium
3. test_chat_public_markdown_support, id: 702065
## Installing 'Status Cat' stickerpack Device 2: Find `EditBox` by `accessibility id`: `chat-message-input` `Test setup failed: Device 2: EditBox by accessibility id: chat-message-input is not found on the screen` Class: TestChatMediumMultipleDevice Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_profile_use_history_node_disable_enable, id: 702286
`Test setup failed: E http.client.RemoteDisconnected: Remote end closed connection without response` `During handling of the above exception, another exception occurred: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without re` Class: TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium
5. test_profile_custom_bootnodes_enable_disable, id: 702285
`Test setup failed: E http.client.RemoteDisconnected: Remote end closed connection without response` `During handling of the above exception, another exception occurred: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without re` Class: TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium
6. test_public_chat_timeline_different_statuses_reaction, id: 702284
## Creating new multiaccount (password:'qwerty', keycard:'False') Device 2: Click until `Button` by `accessibility id`: `checkbox-on` will be presented `Test setup failed: E http.client.RemoteDisconnected: Remote end closed connection without response` `During handling of the above exception, another exception occurred: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without re` Class: TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (8)

Click to expand

1. test_wallet_send_tx_between_accounts_in_multiaccount_instance, id: 6225
Device sessions Device 1: Steps, video, logs
2. test_block_user_from_1_1_chat_header_check_mentions_and_push_notification_service, id: 702296
Class: TestChatKeycardMentionsMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_keycard_send_funds_between_accounts_set_max_in_multiaccount_instance, id: 6292
Device sessions Device 1: Steps, video, logs
4. test_keycard_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline_opened_from_push, id: 702295
Class: TestChatKeycardMentionsMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_scan_qr_eip_681_links_via_wallet, id: 702291
Class: TestPermissionsScanQrOneDevice Device sessions Device 1: Steps, video, logs
6. test_scan_qr_different_links_with_universal_qr_scanner, id: 702293
Class: TestPermissionsScanQrOneDevice Device sessions Device 1: Steps, video, logs
7. test_chat_public_clear_history_via_options_and_long_press, id: 702250
Class: TestDeeplinkChatProfileOneDevice Device sessions Device 1: Steps, video, logs
8. test_chat_1_1_unread_counter_highligted, id: 702294
Class: TestChatKeycardMentionsMediumMultipleDevice Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2022-05-25T16:16:34Z

Got it, thanks for your answer @Parveshdhull !
PR looks good to me, no visible regression found manually and by e2e. Let's merge!

status-github-bot bot added this to REVIEW in Pipeline for QA May 22, 2022

Parveshdhull self-assigned this May 22, 2022

Parveshdhull force-pushed the feature/new-ui-toggle branch 2 times, most recently from 48ac7fc to dbc3c7e Compare May 23, 2022 23:01

Parveshdhull changed the title ~~[WIP] Implementation of new UI toggle~~ Implementation of new UI toggle May 23, 2022

Parveshdhull requested review from flexsurfer, briansztamfater and jo-mut May 23, 2022 23:25

Parveshdhull force-pushed the feature/new-ui-toggle branch 2 times, most recently from b95ef1b to 4302c02 Compare May 23, 2022 23:34

Parveshdhull added the request-manual-qa label May 23, 2022

flexsurfer reviewed May 24, 2022

View reviewed changes

src/status_im/navigation2/screens.cljs Show resolved Hide resolved

src/status_im/ui/screens/advanced_settings/views.cljs Outdated Show resolved Hide resolved

flexsurfer reviewed May 24, 2022

View reviewed changes

src/status_im/multiaccounts/login/core.cljs Show resolved Hide resolved

flexsurfer reviewed May 24, 2022

View reviewed changes

src/status_im/navigation2/home_stack.cljs Show resolved Hide resolved

flexsurfer approved these changes May 24, 2022

View reviewed changes

qoqobolo moved this from REVIEW to E2E Tests in Pipeline for QA May 24, 2022

qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA May 25, 2022

qoqobolo self-assigned this May 25, 2022

Implementation of new UI toggle

4c8b80f

Parveshdhull force-pushed the feature/new-ui-toggle branch from 9b71059 to 4c8b80f Compare May 25, 2022 15:59

qoqobolo added the Tested - OK label May 25, 2022

qoqobolo moved this from IN TESTING to MERGE in Pipeline for QA May 25, 2022

Parveshdhull merged commit 1ccb015 into develop May 25, 2022

Pipeline for QA automation moved this from MERGE to DONE May 25, 2022

Parveshdhull deleted the feature/new-ui-toggle branch May 25, 2022 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of new UI toggle #13384

Implementation of new UI toggle #13384

Parveshdhull commented May 22, 2022 •

edited

status-im-auto commented May 22, 2022 •

edited

flexsurfer left a comment

Parveshdhull commented May 24, 2022

Parveshdhull commented May 24, 2022

status-im-auto commented May 24, 2022

status-im-auto commented May 24, 2022

status-im-auto commented May 25, 2022

qoqobolo commented May 25, 2022

Parveshdhull commented May 25, 2022

status-im-auto commented May 25, 2022

status-im-auto commented May 25, 2022

qoqobolo commented May 25, 2022

Implementation of new UI toggle #13384

Implementation of new UI toggle #13384

Conversation

Parveshdhull commented May 22, 2022 • edited

Summary:

Note:

Development:

Testing:

status-im-auto commented May 22, 2022 • edited

Jenkins Builds

flexsurfer left a comment

Choose a reason for hiding this comment

Parveshdhull commented May 24, 2022

Parveshdhull commented May 24, 2022

status-im-auto commented May 24, 2022

94% of end-end tests have passed

Failed tests (5)

Passed tests (79)

status-im-auto commented May 24, 2022

85% of end-end tests have passed

Not executed tests (85)

Failed tests (13)

Passed tests (76)

status-im-auto commented May 25, 2022

60% of end-end tests have passed

Failed tests (2)

Passed tests (3)

qoqobolo commented May 25, 2022

ISSUE 1: The new UI switches to the old one when switching mode (light/dark) in Settings

ISSUE 2: The Close button of the opened switcher is barely visible in dark mode

ISSUE 3: Dark/light mode in the new UI is reset after reopening the app

ISSUE 4: Dark mode is not applied correctly if the device is in light mode (and vice versa)

Q 5: Chats without topbar

Q 6: Should the switcher be hidden when the keyboard is opened?

Q 7: Buttons Buy, Send, and Recieve in Wallet are now inactive. Is it expected?

Parveshdhull commented May 25, 2022

status-im-auto commented May 25, 2022

0% of end-end tests have passed

Failed tests (1)

status-im-auto commented May 25, 2022

57% of end-end tests have passed

Failed tests (6)

Passed tests (8)

qoqobolo commented May 25, 2022

Parveshdhull commented May 22, 2022 •

edited

status-im-auto commented May 22, 2022 •

edited

ISSUE 2: The `Close` button of the opened switcher is barely visible in dark mode

Q 7: Buttons `Buy`, `Send`, and `Recieve` in Wallet are now inactive. Is it expected?