nix: lock Go builders at 1.17.x, small cleanup #13402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (6)
|
jakubgs
force-pushed
the
nix/lock-go-versions
branch
from
67a850c
to
2c9e487
Compare
Parveshdhull
approved these changes
May 26, 2022
If we keep using specific `buildGo117Package` we can easily forge to upgrade when we bump the Go compiler itself. By locking those explicitly in `overlay.nix` we make sure they all get bumped together. Signed-off-by: Jakub Sokołowski <jakub@status.im>
Mostly achieved by running via `nix-linter`. Signed-off-by: Jakub Sokołowski <jakub@status.im>
Otherwise `watchman` utility is unavailable for MacOS. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
nix/lock-go-versions
branch
from
461822f
to
e2fabd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we keep using specific
buildGo117Packagewe can easily forget to upgrade when we bump the Go compiler itself. By locking those explicitly inoverlay.nixwe make sure they all get bumped together.