Fix App getting stucked on logout #13427
Conversation
Jenkins BuildsClick to see older builds (13)
|
Parveshdhull
force-pushed
the
fix/app-gets-stucked-on-logout
branch
from
91d5477
to
a1ba5d9
Compare
90% of end-end tests have passedFailed tests (8)Click to expand
Passed tests (76)Click to expand
|
|
@Parveshdhull unfortunately, the issue is still reproducible with the scenario for PR builds:
video_2022-05-31_15-01-12.mp4Also, I can reproduce this on iOS as well (updated the issue) |
|
Hi @qoqobolo, Thanks for testing the PR and finding the issue. I will see why it is still occurring. |
62% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (5)Click to expand
|
Parveshdhull
force-pushed
the
fix/app-gets-stucked-on-logout
branch
from
a1ba5d9
to
82117fa
Compare
|
@qoqobolo, issue should be fixed now. |
| <color name="alert_background">#141414</color> | ||
| <color name="alert_text">#ffffff</color> |
There was a problem hiding this comment.
fix indents: pending chore from #13273
|
|
||
| Runnable r = new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| String result = Statusgo.logout(); | ||
| if (result.startsWith("{\"error\":\"\"")) { | ||
| Log.d(TAG, "Logout result: " + result); | ||
| } else { | ||
| Log.e(TAG, "Logout failed: " + result); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| StatusThreadPoolExecutor.getInstance().execute(r); |
There was a problem hiding this comment.
Even when the issue is fixed, Statusgo.logout sometime takes 2-3 seconds to return the result. So it's better to use StatusThreadPoolExecutor so that UI don't look frozen. (now will show the progress bar instead)
96% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (81)Click to expand
|
|
@Parveshdhull thank you, logout and stickers are working fine now. |
Parveshdhull
force-pushed
the
fix/app-gets-stucked-on-logout
branch
from
2978ff8
to
0a2cd3c
Compare
Parveshdhull
force-pushed
the
fix/app-gets-stucked-on-logout
branch
from
0a2cd3c
to
9d8f218
Compare
fixes #13421
status-go PR
status-im/status-go#2699
status: ready