You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was decided to deprecate the invitation link for group chats.
For now, we should just hide the link in group chats so that 1.20 users will not be using it, but we maintain all the functionalities so it's backward compatible.
Platforms
Android
iOS
Functional
group chats
Steps to test
Open Status
add some contacts,
create a group chat with them,
go to the group chat,
click on the dots on the top,
group info,
Group invite,
and you shouldn't see the group invite link, because it is removed.
an admin will still be able to accept pending requests
Test setup failed:
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/d96a2c2e445c4ee4bd95636c64d812fa
Test setup failed:
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/d96a2c2e445c4ee4bd95636c64d812fa
Test setup failed:
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/d96a2c2e445c4ee4bd95636c64d812fa
Test setup failed:
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/d96a2c2e445c4ee4bd95636c64d812fa
Test setup failed:
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/d96a2c2e445c4ee4bd95636c64d812fa
@audriu thanks for your work!
Checked invitation links and the upgrade from the nightly to test pending requests - everything is working fine.
One question: since we're no longer gonna have invitation links and only previously sent requests will be displayed there, maybe it would be better to rename this button to Membership requests for example?
Because the current name Group invite seems a bit misleading to me, as I'm expecting to find a link there that I can use for the invites.
What do you think?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audriu
force-pushed
the
13399-hide-invitation-link-to-group-chats
branch
from
Hide invitation link to group chats
fixes #13399
Summary
It was decided to deprecate the invitation link for group chats.
For now, we should just hide the link in group chats so that 1.20 users will not be using it, but we maintain all the functionalities so it's backward compatible.
Platforms
Functional
Steps to test
status: ready