Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-install hook for generating node bindings #13453

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

cammellos
Copy link
Member

fixes: #13446

@cammellos cammellos self-assigned this Jun 6, 2022
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jun 6, 2022
@Parveshdhull
Copy link
Member

Hi @cammellos, yarn add command is working now, thanks for fixing it quickly.
Please can you also explain why we are calling make status-go-library for yarn install calls

@status-im-auto
Copy link
Member

status-im-auto commented Jun 6, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b7e2f9a #1 2022-06-06 10:37:56 ~11 min android 📦apk 📲
✔️ b7e2f9a #1 2022-06-06 10:38:05 ~11 min android-e2e 📦apk 📲
✔️ b7e2f9a #1 2022-06-06 10:41:10 ~14 min ios 📦ipa 📲

@cammellos
Copy link
Member Author

Hi @cammellos, yarn add command is working now, thanks for fixing it quickly. Please can you also explain why we are calling make status-go-library for yarn install calls

Basically we need to install gyp modules for testing, and it needs the compiled headers from status-go library, which are generated by gyp. We could try to skip in some cases, but I could not find an option (it will look for them when running yarn x), and eventually everyone should have tested their changes with status-go as the check is required in CI as well.

Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
@cammellos cammellos merged commit ef8a7f3 into develop Jun 6, 2022
Pipeline for QA automation moved this from REVIEW to DONE Jun 6, 2022
@cammellos cammellos deleted the bug/#13446-fix-pre-install branch June 6, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Yarn add is not working
3 participants