Display a contact request when added via AddContact #13477
Conversation
Jenkins BuildsClick to see older builds (12)
|
cammellos
force-pushed
the
feature/backward-compatible-contact-requests
branch
2 times, most recently
from
c42f0fb
to
1af7f9f
Compare
cammellos
force-pushed
the
feature/backward-compatible-contact-requests
branch
from
1af7f9f
to
5882264
Compare
cammellos
changed the title
94% of end-end tests have passedFailed tests (5)Click to expand
Passed tests (79)Click to expand
|
75% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (3)Click to expand
|
|
@cammellos thanx for the PR. Please, take a look at following issues. All those issues are connected and to some extend duplicate each other. I decided to describe them as separate issues in order to show different cases which Users can face. ISSUE 1 User 1 with enabled CR (contact requests) cannot send messages to User 2 if users have added each other to contacts via Add contactPreconditions: User 1 - enabled CR. User 2 - enabled or disabled CR, doesn't matter Steps:
Actual result: no textfield in 1-1 chat for User 1. Expected result: User 1 can send messages to User 2 as they are already contacts. Adding to contacts should work the same as sending and accepting contact requests from chat. no_text_field.mp4ISSUE/QUESTION 2 Is this an expected behaviour: User 1 is unable to resend contact request via Add contact if User 2 (receiver) has once declined such contact request or removed User 1 from contactsLet's say we have User 1 and User 2 with enabled CR. Steps:
Actual result: **Expected result:**IMO we should send contact requests every time when user adds someone to contacts. Otherwise users can face such cases as described above, when it is not clear how to start messaging. I understand, that it potentially may lead to spam of CRs but at the same time currently we do not limit sending of requests from chats: users can delete and restart 1-1 chats plenty of times and send plenty of contact requests, as button reappears every time when user re-starts the chat. no_resend_cr.mp4ISSUE 3 Send request button is not displayed in 1-1 chat for User 1 when he has User 2 in contacts but User 2 does not have User 1 in contactsThis issue can be observed on video from above ISSUE 2 and reproduced via same steps. The main point is that User 1 should have possibility to send contact request to User 2 form chat if he already has User 2 in contacts but User 2 does not have User 1 in contacts. |
cammellos
force-pushed
the
feature/backward-compatible-contact-requests
branch
2 times, most recently
from
7ad84fc
to
8703f67
Compare
100% of end-end tests have passedPassed tests (84)Click to expand
|
|
@cammellos thank you for fixes. Issues 1 and 2 are fixed. Issue 3 agreed agreed to leave as it is until new designs of CR will come up. |
cammellos
force-pushed
the
feature/backward-compatible-contact-requests
branch
from
8703f67
to
7f8ad61
Compare
Fixes: #13396
Description
When adding someone with
AddContacta contact request should be displayed on the other device activity center with some pre-populated text (Please add me to your contacts).This is regardless of whether it has mutual contact requests enabled, for backward compatibility.
status: ready