e2e: mutual contact request basic checks #13600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (17)
|
pavloburykh
changed the title
100% of end-end tests have passedNot executed tests (180)Passed tests (3)Click to expand
|
churik
reviewed
Jul 1, 2022
| self.chat_1.send_contact_request("Hi, please add me to contacts") | ||
|
|
||
| self.home_1.just_fyi('Check pending request is displayed, input field still disabled') | ||
| if not self.chat_1.element_by_text('Pending...').is_element_displayed(): |
There was a problem hiding this comment.
replace with translation-id "contact-request-pending"
There was a problem hiding this comment.
@churik thanks, replaced
churik
reviewed
Jul 1, 2022
| self.drivers[0].fail('Chat input field has not appeared after contact request has been accepted') | ||
|
|
||
| self.home_1.just_fyi('Verify request sender can send messages to request acceptor after acceptance of cr') | ||
| self.chat_1.just_fyi("Clicking send button to clear input field from remained request message. Bug #13610") |
There was a problem hiding this comment.
Better comment with #TODO : - they are reviewed periodically and easily can be found in code (built-in feature of PyCarm)
There was a problem hiding this comment.
added #TODO comment
churik
approved these changes
Jul 1, 2022
| chat_2 = self.home_2.add_contact(self.public_key_1, add_in_contacts=False) | ||
|
|
||
| self.chat_1.just_fyi('Verify cannot sent messages to user who declined contact request') | ||
| if self.chat_1.chat_message_input.is_element_displayed(): |
There was a problem hiding this comment.
Typo, Verify cannot send messages to user who declined contact request
There was a problem hiding this comment.
Thanks @churik , fixed
100% of end-end tests have passedNot executed tests (180)Passed tests (3)Click to expand
|
pavloburykh
force-pushed
the
tests/mutual_contact_requests
branch
from
95c2da8
to
39578d9
Compare
pavloburykh
force-pushed
the
tests/mutual_contact_requests
branch
from
39578d9
to
934cecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic mutual contact requests cases.