Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group avatar & context tags #13629

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

cammellos
Copy link
Member

Implements group avatar and context tags (missing one of the modes of context tag)
Also partially implement activity logs component, but still wip.

@status-im-auto
Copy link
Member

status-im-auto commented Jul 5, 2022

Jenkins Builds

Click to see older builds (13)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a302477 #1 2022-07-05 14:27:54 ~9 min android 📦apk 📲
✔️ a302477 #1 2022-07-05 14:29:42 ~11 min ios 📦ipa 📲
✔️ a302477 #1 2022-07-05 14:31:21 ~13 min android-e2e 📦apk 📲
096c846 #2 2022-07-08 11:00:46 ~13 sec android 📄log
096c846 #2 2022-07-08 11:00:50 ~12 sec ios 📄log
096c846 #2 2022-07-08 11:00:56 ~23 sec android-e2e 📄log
2ab31cb #3 2022-07-08 11:52:56 ~13 sec ios 📄log
2ab31cb #3 2022-07-08 11:52:57 ~14 sec android-e2e 📄log
2ab31cb #3 2022-07-08 11:53:08 ~25 sec android 📄log
✔️ 9c307a3 #4 2022-07-08 12:05:18 ~11 min android 📦apk 📲
✔️ 9c307a3 #4 2022-07-08 12:07:50 ~14 min ios 📦ipa 📲
✔️ b9a7b83 #5 2022-07-08 16:51:26 ~10 min ios 📦ipa 📲
✔️ b9a7b83 #5 2022-07-08 16:53:06 ~11 min android 📦apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 665e947 #6 2022-07-18 11:54:33 ~11 min android-e2e 📦apk 📲
✔️ 665e947 #6 2022-07-18 11:54:57 ~11 min android 📦apk 📲
✔️ 665e947 #6 2022-07-18 11:56:05 ~12 min ios 📦ipa 📲
✔️ 6fb4969 #7 2022-08-08 10:09:03 ~8 min android-e2e 📦apk 📲
✔️ 6fb4969 #7 2022-08-08 10:09:07 ~8 min android 📦apk 📲
✔️ 6fb4969 #7 2022-08-08 10:10:39 ~10 min ios 📦ipa 📲

@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA Jul 8, 2022
@cammellos cammellos force-pushed the feature/activity-logs-content branch 2 times, most recently from 2ab31cb to 9c307a3 Compare July 8, 2022 11:53
@Parveshdhull
Copy link
Member

Oh, I missed the PR description, it is still WIP. Old UI is also affected right now with changes
image

@cammellos
Copy link
Member Author

Oh, I missed the PR description, it is still WIP. Old UI is also affected right now with changes image

Yes, I was testing a separate PR, I will revert the status-go changes before it's ready :) thanks for the review!

@cammellos cammellos force-pushed the feature/activity-logs-content branch from b9a7b83 to 665e947 Compare July 18, 2022 11:43
@cammellos cammellos moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA Jul 18, 2022
@jakubgs jakubgs moved this from E2E Tests to REVIEW in Pipeline for QA Jul 18, 2022
@jakubgs jakubgs moved this from REVIEW to E2E Tests in Pipeline for QA Jul 18, 2022
@jakubgs jakubgs moved this from E2E Tests to REVIEW in Pipeline for QA Jul 18, 2022
@jakubgs jakubgs moved this from REVIEW to E2E Tests in Pipeline for QA Jul 18, 2022
@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 84
Failed tests: 6
Passed tests: 78
IDs of failed tests: 700736,700718,702196,700757,702188,702194 

Failed tests (6)

Click to expand
  • Rerun failed tests

  • 1. test_public_chat_link_send_open, id: 700736

    Device 2: Tap on found: SendMessageButton
    Device 1: Find `Button` by `xpath`: `//*[starts-with(@text,'http://status.im')]`

    critical/test_public_chat_browsing.py:158: in test_public_chat_link_send_open self.chat_1.element_starts_with_text(url_message, 'button').click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in fin

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    2. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

    Device 1: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented
    Device 2: Looking for chat: '#ofbvcra'

    /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request six.raise_from(e, No

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    3. test_pairing_sync_contacts_block_unblock, id: 702196
    Test is not run, e2e blocker [[reason: [NOTRUN] failing due to issue #13635. Skipping until fix]]

    Class: TestPairingSyncMultipleDevicesMerged

    4. test_send_tx_set_recipient_options, id: 700757

    Device 1: Tap on found: Button
    Device 1: Find `Text` by `xpath`: `//*[@content-desc='choose-recipient-button']//android.widget.TextView`

    critical/wallet_and_tx/test_send_tx_dapp_keycard.py:240: in test_send_tx_set_recipient_options if send_tr.enter_recipient_address_text.text != send_tr.get_formatted_recipient_address(ens_status['address']): ../views/base_element.py:358: in text te

    Class: TestSendTxDeviceMerged

    Device sessions

    5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

    Device 1: Find `Button` by `xpath`: `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find `Button` by `xpath`: `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    critical/chats/test_1_1_public_chats.py:931: in test_cellular_settings_on_off_public_chat_fetching_history self.errors.verify_no_errors() base_test_case.py:189: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    6. test_pairing_sync_initial_contacts_blocked_users, id: 702194
    Test is not run, e2e blocker [[reason: [NOTRUN] failing due to issue #13635. Skipping until fix]]

    Class: TestPairingSyncMultipleDevicesMerged

    Passed tests (78)

    Click to expand

    1. test_browser_connection_is_secure_not_secure_warning, id: 702073

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    2. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    3. test_1_1_chat_push_emoji, id: 6283

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    4. test_start_new_chat_public_key_validation, id: 702158

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    5. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    6. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    7. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Class: TestRestoreOneDeviceMerged

    Device sessions

    8. test_wallet_add_account_generate_new, id: 700759

    Class: TestWalletManagementDeviceMerged

    Device sessions

    9. test_public_chat_message_delete, id: 700735

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    10. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

    Class: TestSendTxDeviceMerged

    Device sessions

    11. test_onboarding_share_contact_address, id: 700743

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    12. test_browser_invalid_url, id: 702074

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    13. test_public_chat_unread_messages_counter, id: 5360

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    14. test_keycard_send_tx_eth, id: 700767

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    15. test_sticker_1_1_public_chat, id: 702157

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    16. test_contact_block_unblock_public_chat_offline, id: 702176

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    17. test_browser_bookmarks_create_edit_remove, id: 702077

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    18. test_group_chat_leave_relogin, id: 3997

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    19. test_public_chat_tag_message, id: 700738

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    20. test_public_chat_delete_chat_long_press, id: 5319

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    21. test_browser_offline, id: 702075

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    22. test_1_1_chat_image_send_save_reply, id: 6305

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    23. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    24. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    25. test_group_chat_highligted, id: 5756

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    26. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    27. test_keycard_create_account_unlock_same_seed, id: 5689

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    28. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    29. test_wallet_add_hide_unhide_account_private_key, id: 700761

    Class: TestWalletManagementDeviceMerged

    Device sessions

    30. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    31. test_wallet_add_delete_watch_only_account, id: 700760

    Class: TestWalletManagementDeviceMerged

    Device sessions

    32. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

    Class: TestRestoreOneDeviceMerged

    Device sessions

    33. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    34. test_1_1_chat_message_reaction, id: 6315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    35. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    36. test_public_chat_open_using_deep_link, id: 700739

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    37. test_public_chat_emoji_send_copy_paste_reply, id: 700719

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    38. test_public_chat_mark_all_messages_as_read, id: 6270

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    39. test_group_chat_push_system_messages_when_invited, id: 3994

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    40. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    41. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    42. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    43. test_ens_mention_push_highlighted_public_chat, id: 702156

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    44. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    45. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    46. test_onboarding_share_wallet_address, id: 700744

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    47. test_pairing_sync_initial_public_chats, id: 702195

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    48. test_keycard_relogin_after_restore, id: 700768

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    49. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    50. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

    Class: TestWalletManagementDeviceMerged

    Device sessions

    51. test_browser_delete_close_tabs, id: 702076

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    52. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    53. test_pairing_sync_public_chat_add_remove, id: 702199

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    54. test_restore_set_up_wallet_sign_phrase, id: 700749

    Class: TestRestoreOneDeviceMerged

    Device sessions

    55. test_pairing_sync_1_1_chat_message, id: 702198

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    56. test_browser_blocked_url, id: 702072

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    57. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    58. test_browser_web3_permissions_testdapp, id: 702078

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    59. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    60. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

    Class: TestWalletManagementDeviceMerged

    Device sessions

    61. test_group_chat_join_send_text_messages_push, id: 700731

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    62. test_ens_mention_nickname_1_1_chat, id: 702155

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    63. test_ens_purchased_in_profile, id: 702152

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    64. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    65. test_send_tx_eth_check_logcat, id: 700763

    Class: TestSendTxDeviceMerged

    Device sessions

    66. test_send_tx_token_7_decimals, id: 700764

    Class: TestSendTxDeviceMerged

    Device sessions

    67. test_wallet_add_account_seed_phrase_validation, id: 700762

    Class: TestWalletManagementDeviceMerged

    Device sessions

    68. test_1_1_chat_text_message_with_push, id: 6316

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    69. test_public_chat_message_edit, id: 700734

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    70. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    71. test_onboarding_home_initial_popup, id: 700742

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    72. test_group_chat_add_new_member_activity_centre, id: 700732

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    73. test_wallet_manage_assets, id: 700758

    Class: TestWalletManagementDeviceMerged

    Device sessions

    74. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

    Class: TestSendTxDeviceMerged

    Device sessions

    75. test_public_chat_fetch_more_history, id: 5675

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    76. test_group_chat_offline_pn, id: 3998

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    77. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    78. test_restore_seed_phrase_field_validation, id: 700750

    Class: TestRestoreOneDeviceMerged

    Device sessions

    @pavloburykh pavloburykh self-assigned this Jul 20, 2022
    @pavloburykh
    Copy link
    Contributor

    @cammellos thanx for the PR. Failed e2e are not related to PR changes.

    @pavloburykh pavloburykh moved this from E2E Tests to MERGE in Pipeline for QA Jul 20, 2022
    @cammellos cammellos force-pushed the feature/activity-logs-content branch from 665e947 to 6fb4969 Compare August 8, 2022 09:59
    @cammellos cammellos merged commit 6fb4969 into develop Aug 8, 2022
    @cammellos cammellos deleted the feature/activity-logs-content branch August 8, 2022 10:31
    Pipeline for QA automation moved this from MERGE to DONE Aug 8, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    None yet

    4 participants