Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync of blocked contacts #13712

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

audriu
Copy link
Contributor

@audriu audriu commented Jul 22, 2022

status-im/status-go@3cd92fd...4aa3413
fixes #13635

Summary

Fix sync of blocked contacts. Receiving device was dropping requests if blocked contact is also removed.

Platforms

  • Android
  • iOS
Functional
  • 1-1 chats
  • public chats
  • account recovery

Steps to test

Please see: here

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jul 22, 2022
@audriu audriu self-assigned this Jul 22, 2022
@audriu audriu requested a review from pavloburykh July 22, 2022 12:57
@pavloburykh
Copy link
Contributor

Already tested here #13701

@status-im-auto
Copy link
Member

status-im-auto commented Jul 22, 2022

Jenkins Builds

Click to see older builds (3)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5b5bda8 #1 2022-07-22 13:04:37 ~9 min android-e2e 📦apk 📲
✔️ 5b5bda8 #1 2022-07-22 13:04:40 ~9 min android 📦apk 📲
✔️ 5b5bda8 #1 2022-07-22 13:12:07 ~17 min ios 📦ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9252e11 #3 2022-07-22 13:30:33 ~12 min android 📦apk 📲
✔️ 9252e11 #3 2022-07-22 13:32:01 ~13 min android-e2e 📦apk 📲
✔️ 9252e11 #3 2022-07-22 13:37:34 ~19 min ios 📦ipa 📲
✔️ 913994b #4 2022-07-22 13:52:08 ~11 min android-e2e 📦apk 📲
✔️ 913994b #4 2022-07-22 13:52:31 ~11 min android 📦apk 📲
✔️ 913994b #4 2022-07-22 13:53:46 ~13 min ios 📦ipa 📲

@audriu audriu moved this from REVIEW to E2E Tests in Pipeline for QA Jul 22, 2022
@audriu audriu force-pushed the 13635-currently-blocked-users-are-not-syncing- branch 2 times, most recently from 4e500ce to 9252e11 Compare July 22, 2022 13:18
status-im/status-go@4aa3413...4aa3413

Signed-off-by: Audrius Molis <masta@dr.com>
@audriu audriu force-pushed the 13635-currently-blocked-users-are-not-syncing- branch from 9252e11 to 913994b Compare July 22, 2022 13:40
@audriu audriu merged commit 798c604 into develop Jul 22, 2022
Pipeline for QA automation moved this from E2E Tests to DONE Jul 22, 2022
@audriu audriu deleted the 13635-currently-blocked-users-are-not-syncing- branch July 22, 2022 13:41
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 84
Failed tests: 5
Passed tests: 79
Not executed tests: 3
IDs of not executed tests: 702392,702393,702394 
IDs of failed tests: 6263,6305,5310,702076,5387 

Not executed tests (3)

Click to expand
  • Rerun not executed tests
  • Failed tests (5)

    Click to expand
  • Rerun failed tests

  • 1. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Device 1: Element TransactionStatus text is equal to Confirmed
    Device 2: Wait for text element `TransactionStatus` to be equal to `Confirmed`

    critical/chats/test_1_1_public_chats.py:200: in test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline [message.transaction_status.wait_for_element_text(message.confirmed, wait_time=120) for message in critical/chats/test_1_1_public_chats.p

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    2. test_1_1_chat_image_send_save_reply, id: 6305

    Device 2: Tap 'Confirm' on native keyboard
    Device 2: Find `Button` by `accessibility id`: `save-button`

    critical/chats/test_1_1_public_chats.py:547: in test_1_1_chat_image_send_save_reply self.chat_2.save_image_icon_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

    Device 2: Looking for chat: 'Graceful Our Iceblueredtopzebra'
    Device 2: Wait for element `Button` for max 30s and click when it is available

    critical/chats/test_1_1_public_chats.py:574: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.home_2.get_chat(username=self.default_username_1).click() ../views/home_view.py:254: in get_chat self.notifications_unread_badge.wait_a

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    4. test_browser_delete_close_tabs, id: 702076

    Device 1: Find `Button` by `xpath`: `//*[contains(@text, 'bbc.com')]/../../../../*[@content-desc='empty-tab']`
    Device 1: Tap on found: Button

    critical/test_public_chat_browsing.py:423: in test_browser_delete_close_tabs web_page.element_by_text_part(urls['bbc.com']).wait_for_invisibility_of_element() ../views/base_element.py:144: in wait_for_invisibility_of_element raise TimeoutException

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    5. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

    Device 2: Looking for chat: 'Graceful Our Iceblueredtopzebra'
    Device 2: Wait for element `Button` for max 30s and click when it is available

    critical/chats/test_1_1_public_chats.py:604: in test_1_1_chat_delete_via_delete_button_relogin self.home_2.get_chat(username=self.default_username_1).click() ../views/home_view.py:254: in get_chat self.notifications_unread_badge.wait_and_click(wai

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    Passed tests (79)

    Click to expand

    1. test_wallet_manage_assets, id: 700758

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_public_chat_message_edit, id: 700734

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    3. test_contact_block_unblock_public_chat_offline, id: 702176

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    5. test_keycard_relogin_after_restore, id: 700768

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    6. test_sticker_1_1_public_chat_mainnet, id: 702157

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    7. test_group_chat_push_system_messages_when_invited, id: 3994

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    8. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    9. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    10. test_public_chat_open_using_deep_link, id: 700739

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    11. test_public_chat_unread_messages_counter, id: 5360

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    12. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    13. test_pairing_sync_contacts_block_unblock, id: 702196

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    14. test_public_chat_emoji_send_copy_paste_reply, id: 700719

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    15. test_browser_bookmarks_create_edit_remove, id: 702077

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    16. test_send_tx_eth_check_logcat, id: 700763

    Class: TestSendTxDeviceMerged

    Device sessions

    17. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    18. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

    Class: TestSendTxDeviceMerged

    Device sessions

    19. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    20. test_wallet_add_account_seed_phrase_validation, id: 700762

    Class: TestWalletManagementDeviceMerged

    Device sessions

    21. test_public_chat_delete_chat_long_press, id: 5319

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    22. test_onboarding_home_initial_popup, id: 700742

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    23. test_browser_blocked_url, id: 702072

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    24. test_wallet_add_hide_unhide_account_private_key, id: 700761

    Class: TestWalletManagementDeviceMerged

    Device sessions

    25. test_1_1_chat_message_reaction, id: 6315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    26. test_ens_mention_push_highlighted_public_chat, id: 702156

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    27. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    28. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    29. test_group_chat_highligted, id: 5756

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    30. test_public_chat_link_send_open, id: 700736

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    31. test_send_tx_token_8_decimals, id: 700764

    Class: TestSendTxDeviceMerged

    Device sessions

    32. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    33. test_onboarding_share_contact_address, id: 700743

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    34. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    35. test_restore_set_up_wallet_sign_phrase, id: 700749

    Class: TestRestoreOneDeviceMerged

    Device sessions

    36. test_ens_mention_nickname_1_1_chat, id: 702155

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    37. test_public_chat_mark_all_messages_as_read, id: 6270

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    38. test_browser_connection_is_secure_not_secure_warning, id: 702073

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    39. test_send_tx_set_recipient_options, id: 700757

    Class: TestSendTxDeviceMerged

    Device sessions

    40. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    41. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

    Class: TestSendTxDeviceMerged

    Device sessions

    42. test_group_chat_join_send_text_messages_push, id: 700731

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    43. test_browser_web3_permissions_testdapp, id: 702078

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    44. test_1_1_chat_text_message_with_push, id: 6316

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    45. test_wallet_add_delete_watch_only_account, id: 700760

    Class: TestWalletManagementDeviceMerged

    Device sessions

    46. test_public_chat_tag_message, id: 700738

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    47. test_onboarding_share_wallet_address, id: 700744

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    48. test_keycard_create_account_unlock_same_seed, id: 5689

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    49. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    50. test_pairing_sync_initial_contacts_blocked_users, id: 702194

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    51. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    52. test_pairing_sync_1_1_chat_message, id: 702198

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    53. test_pairing_sync_public_chat_add_remove, id: 702199

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    54. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    55. test_public_chat_fetch_more_history, id: 5675

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    56. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

    Class: TestWalletManagementDeviceMerged

    Device sessions

    57. test_group_chat_offline_pn, id: 3998

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    58. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    59. test_group_chat_add_new_member_activity_centre, id: 700732

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    60. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    61. test_ens_purchased_in_profile, id: 702152

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    62. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    63. test_keycard_send_tx_eth, id: 700767

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    64. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Class: TestRestoreOneDeviceMerged

    Device sessions

    65. test_browser_offline, id: 702075

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    66. test_browser_invalid_url, id: 702074

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    67. test_restore_seed_phrase_field_validation, id: 700750

    Class: TestRestoreOneDeviceMerged

    Device sessions

    68. test_wallet_add_account_generate_new, id: 700759

    Class: TestWalletManagementDeviceMerged

    Device sessions

    69. test_start_new_chat_public_key_validation, id: 702158

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    70. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

    Class: TestRestoreOneDeviceMerged

    Device sessions

    71. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    72. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

    Class: TestWalletManagementDeviceMerged

    Device sessions

    73. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    74. test_group_chat_leave_relogin, id: 3997

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    75. test_public_chat_message_delete, id: 700735

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    76. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    77. test_1_1_chat_push_emoji, id: 6283

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    78. test_pairing_sync_initial_public_chats, id: 702195

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    79. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Currently blocked users are not syncing
    3 participants