nix: quote GIT_ROOT uses to avoid issues with spaces #13723

jakubgs · 2022-07-25T20:39:53Z

Resolves:

make run-clojure is not working when there is space in repo path #13715

Parveshdhull · 2022-07-25T20:46:22Z

Still not working for me

[status-mobile]-> pwd
/home/parvesh_monu/Desktop/test repo/status-mobile
[status-mobile]-> make run-clojure
yarn shadow-cljs watch mobile
Configuring Nix shell for target 'clojure'...
/nix/store/mmaml7sb1isvixsywh46kfdh94f18ib3-stdenv-linux/setup: line 89: /home/parvesh_monu/Desktop/test: No such file or directory
yarn run v1.22.19
error Command "shadow-cljs" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [Makefile:258: run-clojure] Error 1

status-im-auto · 2022-07-25T20:50:06Z

Jenkins Builds

Click to see older builds (3)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`737bf2f`	#1	2022-07-25 20:50:06	~9 min	`android-e2e`	📦`apk` 📲
✔️	`737bf2f`	#1	2022-07-25 20:51:29	~11 min	`android`	📦`apk` 📲
✔️	`737bf2f`	#1	2022-07-25 20:51:42	~11 min	`ios`	📦`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`decd60d`	#2	2022-07-26 14:47:50	~10 min	`ios`	📦`ipa` 📲
✔️	`decd60d`	#2	2022-07-26 14:48:41	~11 min	`android-e2e`	📦`apk` 📲
✔️	`decd60d`	#2	2022-07-26 14:48:56	~11 min	`android`	📦`apk` 📲

✔️	`c27a74e`	#3	2022-07-27 14:22:57	~11 min	`android`	📦`apk` 📲
✔️	`c27a74e`	#3	2022-07-27 14:23:18	~11 min	`android-e2e`	📦`apk` 📲
✔️	`c27a74e`	#3	2022-07-27 14:25:45	~13 min	`ios`	📦`ipa` 📲

jakubgs · 2022-07-26T14:37:47Z

That issue appears to be MacOS specific, and the exact error is:

/bin/sh: /Users/jenkins/status mobile/node_modules/.bin/shadow-cljs:
  /nix/store/sgk1hhfhkskz3g9ak6gpkc868hg571kj-nodejs-16.14.2/bin/node:
    bad interpreter: No such file or directory

Which is caused by:

jenkins@maci7-01.ms-eu-dublin.slave.ci:~/status mobile % ls -l /nix/store/sgk1hhfhkskz3g9ak6gpkc868hg571kj-nodejs-16.14.2/bin/node
ls: /nix/store/sgk1hhfhkskz3g9ak6gpkc868hg571kj-nodejs-16.14.2/bin/node: No such file or directory

And that's due to nix/scripts/node_modules.sh script not running at all, since its path wasn't quoted in nix/shells.nix.

Parveshdhull

Works great! Thank you for fixing it.

This is most important on MacOS, but in general is a good idea. Resolves: #13715 Signed-off-by: Jakub Sokołowski <jakub@status.im>

jakubgs requested a review from a team July 25, 2022 20:39

jakubgs self-assigned this Jul 25, 2022

status-github-bot bot added this to REVIEW in Pipeline for QA Jul 25, 2022

jakubgs force-pushed the nix/handle-spaces-in-paths branch from 737bf2f to decd60d Compare July 26, 2022 14:37

Parveshdhull approved these changes Jul 26, 2022

View reviewed changes

nix: quote path uses to avoid issues with spaces

c27a74e

This is most important on MacOS, but in general is a good idea. Resolves: #13715 Signed-off-by: Jakub Sokołowski <jakub@status.im>

jakubgs force-pushed the nix/handle-spaces-in-paths branch from decd60d to c27a74e Compare July 27, 2022 14:11

jakubgs merged commit c27a74e into develop Jul 27, 2022

Pipeline for QA automation moved this from REVIEW to DONE Jul 27, 2022

jakubgs deleted the nix/handle-spaces-in-paths branch July 27, 2022 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nix: quote GIT_ROOT uses to avoid issues with spaces #13723

nix: quote GIT_ROOT uses to avoid issues with spaces #13723

jakubgs commented Jul 25, 2022

Parveshdhull commented Jul 25, 2022

status-im-auto commented Jul 25, 2022 •

edited

jakubgs commented Jul 26, 2022

Parveshdhull left a comment

nix: quote GIT_ROOT uses to avoid issues with spaces #13723

nix: quote GIT_ROOT uses to avoid issues with spaces #13723

Conversation

jakubgs commented Jul 25, 2022

Parveshdhull commented Jul 25, 2022

status-im-auto commented Jul 25, 2022 • edited

Jenkins Builds

jakubgs commented Jul 26, 2022

Parveshdhull left a comment

Choose a reason for hiding this comment

status-im-auto commented Jul 25, 2022 •

edited