fix error when switching dark/light mode while splash screen is shown

[Parveshdhull]

partially fixes #13740

Testing Note:

Not sure if the keycard issue is also fixed (if both are caused by the same bug), only tested 1st one.

status: ready

[status-im-auto]

Jenkins Builds

Click to see older builds (6)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	5417ac1	#1	2022-08-03 20:45:34	~11 min	android-e2e	📦apk 📲
✔️	5417ac1	#1	2022-08-03 20:52:58	~19 min	ios	📦ipa 📲
✔️	5417ac1	#2	2022-08-03 21:14:29	~9 min	android	📦apk 📲
✔️	5417ac1	#7	2022-08-04 14:52:11	~9 min	android	📦apk 📲
✔️	5417ac1	#4	2022-08-04 14:52:48	~10 min	android-e2e	📦apk 📲
✔️	5417ac1	#4	2022-08-04 14:53:09	~10 min	ios	📦ipa 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	9809099	#3	2022-08-04 12:28:48	~9 min	android-e2e	📦apk 📲
✔️	9809099	#3	2022-08-04 12:35:41	~16 min	ios	📦ipa 📲
✔️	9809099	#6	2022-08-04 12:49:02	~9 min	android	📦apk 📲
✔️	c9bae13	#5	2022-08-04 12:35:49	~10 min	android	📦apk 📲

[status-im-auto]

97% of end-end tests have passed

Total executed tests: 87
Failed tests: 3
Passed tests: 84

IDs of failed tests: 702153,702186,702076 

Failed tests (3)

Click to expand

Rerun failed tests

Class TestEnsStickersMultipleDevicesMerged:

1. test_ens_command_send_tx_eth_1_1_chat, id: 702153

Expected amount of confirmations is 3, in fact 6 Device 1: Wait for text element `TransactionStatus` to be equal to `Confirmed` critical/chats/test_1_1_public_chats.py:1028: in test_ens_command_send_tx_eth_1_1_chat chat_1_sender_message.transaction_status.wait_for_element_text(chat_1_sender_message.confirmed) ../views/base_element.py:152: in wait_for_element_text self.driv Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

1. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

Device 2: Find `TransactionElement` by `xpath`: `(//android.widget.TextView[contains(@text,'0.0003215214 ETH')])` Device 1: Wait for text element `TransactionStatus` to be equal to `Confirmed` critical/chats/test_1_1_public_chats.py:704: in test_keycard_command_send_tx_eth_1_1_chat sender_message.transaction_status.wait_for_element_text(sender_message.confirmed, 120) ../views/base_element.py:152: in wait_for_element_text self.driver.fai Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestPublicChatBrowserOneDeviceMerged:

1. test_browser_delete_close_tabs, id: 702076

Device 1: Find `Button` by `xpath`: `//*[contains(@text, 'bbc.com')]/../../../../*[@content-desc='empty-tab']` Device 1: Tap on found: Button critical/test_public_chat_browsing.py:423: in test_browser_delete_close_tabs web_page.element_by_text_part(urls['bbc.com']).wait_for_invisibility_of_element() ../views/base_element.py:144: in wait_for_invisibility_of_element raise TimeoutException Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (84)

Click to expand

Class TestOnboardingOneDeviceMerged:

1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_onboarding_home_initial_popup, id: 700742

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

3. test_onboarding_share_contact_address, id: 700743

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

6. test_onboarding_share_wallet_address, id: 700744

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestWalletManagementDeviceMerged:

1. test_wallet_manage_assets, id: 700758

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_wallet_add_account_seed_phrase_validation, id: 700762

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

3. test_wallet_add_hide_unhide_account_private_key, id: 700761

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

4. test_wallet_add_delete_watch_only_account, id: 700760

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

6. test_wallet_add_account_generate_new, id: 700759

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestCommandsMultipleDevicesMerged:

1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestPublicChatBrowserOneDeviceMerged:

1. test_public_chat_open_using_deep_link, id: 700739

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_browser_bookmarks_create_edit_remove, id: 702077

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

3. test_browser_blocked_url, id: 702072

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

4. test_browser_connection_is_secure_not_secure_warning, id: 702073

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

5. test_browser_web3_permissions_testdapp, id: 702078

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

6. test_public_chat_tag_message, id: 700738

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

7. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

8. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

9. test_public_chat_fetch_more_history, id: 5675

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

10. test_browser_offline, id: 702075

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

11. test_browser_invalid_url, id: 702074

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestPublicChatMultipleDeviceMerged:

1. test_public_chat_message_edit, id: 700734

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_public_chat_unread_messages_counter, id: 5360

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_public_chat_emoji_send_copy_paste_reply, id: 700719

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_public_chat_delete_chat_long_press, id: 5319

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_public_chat_link_send_open, id: 700736

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_public_chat_mark_all_messages_as_read, id: 6270

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

10. test_public_chat_message_delete, id: 700735

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestKeycardTxOneDeviceMerged:

1. test_keycard_relogin_after_restore, id: 700768

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

3. test_keycard_create_account_unlock_same_seed, id: 5689

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

4. test_keycard_send_tx_eth, id: 700767

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestPairingSyncMultipleDevicesMerged:

1. test_pairing_sync_clear_history, id: 702394

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_pairing_sync_contacts_block_unblock, id: 702196

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_pairing_sync_initial_profile_picture, id: 702392

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_pairing_sync_initial_bookmarks, id: 702393

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_pairing_sync_initial_contacts_blocked_users, id: 702194

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_pairing_sync_1_1_chat_message, id: 702198

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_pairing_sync_public_chat_add_remove, id: 702199

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_pairing_sync_initial_public_chats, id: 702195

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

9. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestSendTxDeviceMerged:

1. test_send_tx_eth_check_logcat, id: 700763

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

3. test_send_tx_token_8_decimals, id: 700764

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

4. test_send_tx_set_recipient_options, id: 700757

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestRestoreOneDeviceMerged:

1. test_restore_set_up_wallet_sign_phrase, id: 700749

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

3. test_restore_seed_phrase_field_validation, id: 700750

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

4. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestEnsStickersMultipleDevicesMerged:

1. test_sticker_1_1_public_chat_mainnet, id: 702157

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_ens_mention_push_highlighted_public_chat, id: 702156

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_ens_mention_nickname_1_1_chat, id: 702155

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_ens_purchased_in_profile, id: 702152

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_start_new_chat_public_key_validation, id: 702158

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_message_reaction, id: 6315

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_image_send_save_reply, id: 6305

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_1_1_chat_text_message_with_push, id: 6316

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

9. test_1_1_chat_push_emoji, id: 6283

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

1. test_contact_block_unblock_public_chat_offline, id: 702176

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMerged:

1. test_group_chat_push_system_messages_when_invited, id: 3994

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

2. test_group_chat_highligted, id: 5756

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

3. test_group_chat_join_send_text_messages_push, id: 700731

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

4. test_group_chat_offline_pn, id: 3998

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

5. test_group_chat_add_new_member_activity_centre, id: 700732

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

6. test_group_chat_leave_relogin, id: 3997

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

[status-im-auto]

67% of end-end tests have passed

Total executed tests: 3
Failed tests: 1
Passed tests: 2

IDs of failed tests: 702153 

Failed tests (1)

Click to expand

Rerun failed tests

Class TestEnsStickersMultipleDevicesMerged:

1. test_ens_command_send_tx_eth_1_1_chat, id: 702153

Expected amount of confirmations is 3, in fact 6 Device 1: Wait for text element `TransactionStatus` to be equal to `Confirmed` critical/chats/test_1_1_public_chats.py:1028: in test_ens_command_send_tx_eth_1_1_chat chat_1_sender_message.transaction_status.wait_for_element_text(chat_1_sender_message.confirmed) ../views/base_element.py:152: in wait_for_element_text self.driv Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (2)

Click to expand

Class TestPublicChatBrowserOneDeviceMerged:

1. test_browser_delete_close_tabs, id: 702076

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

1. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[qoqobolo]

Thanks for the fix @Parveshdhull!
LGTM except for the Keycard issue, I still can reproduce it.
Should I edit the issue to keep only the Keycard bug or you're going to try to fix this? (both are okay since it still looks like an edge case to me)

[qoqobolo]

@Parveshdhull I've checked the new builds and that's what we have:

1. In c9bae13 the Keycard issue is still reproducible.

2. In 9809099 the Keycard issue is fixed.

However, in the video below you can see that the mode is not applied immediately if switch it while the splash screen is shown. It only switches after re-opening the app / login

video_2022-08-04_15-44-53.mp4

And how it behaves in develop for comparison (the mode of device is applied immediately)

video_2022-08-04_15-48-26.mp4

[Parveshdhull]

hi @qoqobolo, Thank you very much for testing the new builds.

However, in the video below you can see that the mode is not applied immediately if switch it while the splash screen is shown. It only switches after re-opening the app / login

Yes, this was intentional. I was making sure if the system-theme-mode-changed event is the culprit. And looks like it is.
But as I currently don't have access to the keycard account and am unable to debug, I am not exactly sure where the issue is happening inside that event. So, for now, I am thinking of only merging with the fix of the first issue. wdyt?

[qoqobolo]

@Parveshdhull ah sure! I got so carried away by testing that just forgot it was just for checking, sorry!

Yea, let's merge the fix for the first issue and I'll edit the original one to keep the Keycard bug.
Thank you!