[#13672] Sync contact request decision #13776
Conversation
Jenkins BuildsClick to see older builds (18)
|
99% of end-end tests have passedFailed tests (1)Click to expandClass TestCommandsMultipleDevicesMerged:
Passed tests (86)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestWalletManagementDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestOnboardingOneDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestPublicChatMultipleDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
|
100% of end-end tests have passedPassed tests (1)Click to expandClass TestCommandsMultipleDevicesMerged:
|
|
Waiting for review of go PR status-im/status-go#2789 |
rasom
force-pushed
the
feat/#13672-sync-contact-request-decision
branch
from
1fc1fdc
to
cde12c4
Compare
|
@pavloburykh it was approved on status-go side, should be ready fro testing |
|
@rasom is it possible with a help of attached logs to figure out what's going on in issue below? I am not sure if this issue is PR related. ISSUE 1 Contact is being added/deleted by itself (without user's action) on paired DevicesUnfortunately I haven't found exact steps how to generate such account with this bug On Video below you can see the following:
Actual result: after contact request acceptence - user is added to contacts on Device 2 (IOS) but is deleted from contacts on paired Device 2 (Android). contact_bug.mp4 |
how do I reproduce this? |
|
@qoqobolo |
rasom
force-pushed
the
feat/#13672-sync-contact-request-decision
branch
from
cde12c4
to
957085d
Compare
99% of end-end tests have passedNot executed tests (1)Failed tests (1)Click to expandClass TestCommandsMultipleDevicesMerged:
Passed tests (85)Click to expandClass TestSendTxDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestOnboardingOneDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestRestoreOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestWalletManagementDeviceMerged:
|
100% of end-end tests have passedPassed tests (1)Click to expandClass TestCommandsMultipleDevicesMerged:
|
ISSUE 2 (it may be the same as issue 1 though): Contact is not deleted from the synced secondary device if delete it from the primary device while the secondary device is offlineSteps:
Expected result: no contacts on device2 The issue is not reproducible on develop, removed contacts are synced fine there. |
|
@rasom can you also rebase this PR, please? Go version was bumped to 0.105.1 |
rasom
force-pushed
the
feat/#13672-sync-contact-request-decision
branch
from
957085d
to
6b2a461
Compare
|
@qoqobolo PR is rebased |
|
@qoqobolo both issue should be fixed already |
|
Thanks @rasom! |
|
@qoqobolo my fault, this also should be fixed already |
91% of end-end tests have passedNot executed tests (1)Failed tests (8)Click to expandClass TestPublicChatBrowserOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Passed tests (78)Click to expandClass TestPublicChatBrowserOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestOnboardingOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestPairingSyncMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestKeycardTxOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
|
|
@rasom thanx for the fixes! |
rasom
force-pushed
the
feat/#13672-sync-contact-request-decision
branch
from
9740baa
to
1a30a5e
Compare
rasom
force-pushed
the
feat/#13672-sync-contact-request-decision
branch
from
1a30a5e
to
8e32587
Compare
fix #13672
status: ready