-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: nightly 12/08 fixes #13800
e2e: nightly 12/08 fixes #13800
Conversation
Jenkins BuildsClick to see older builds (8)
|
94% of end-end tests have passed
Not executed tests (1)Failed tests (11)Click to expandSingle device tests:
Class TestActivityCenterMultipleDeviceMedium:
Class TestChatMediumMultipleDevice:
Class TestOneToOneChatMultipleSharedDevices:
Passed tests (177)Click to expandClass TestBrowserProfileOneDevice:
Class TestMutualContactRequests:
Class TestActivityCenterMultipleDeviceMedium:
Class TestEnsStickersMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestPermissionsScanQrOneDevice:
Class TestSendTxDeviceMerged:
Single device tests:Class TestGroupChatMultipleDeviceMediumMerged:
Class TestWalletManagementDeviceMerged:
Class TestPairingSyncMediumMultipleDevicesMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestWalletTestDappMediumMultipleDevicesMerged:
Class TestChatKeycardMentionsMediumMultipleDevice:
Class TestKeycardMediumMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestTimelineHistoryNodesBootnodesMultipleDeviceMergedMedium:
Class TestDeeplinkChatProfileOneDevice:
Class TestProfileGapsCommunityMediumMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
|
75% of end-end tests have passed
Failed tests (1)Click to expandClass TestActivityCenterMultipleDeviceMedium:
Passed tests (3)Click to expandClass TestOneToOneChatMultipleSharedDevices:
|
@@ -3,6 +3,7 @@ | |||
from tests.base_test_case import MultipleSharedDeviceTestCase, create_shared_drivers | |||
from tests.users import transaction_senders, basic_user, ens_user, ens_user_message_sender | |||
from views.sign_in_view import SignInView | |||
from views.home_view import HomeView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is ens_banner_close_button unavailable without importing HomeView?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's a new button that I just added to HomeView, so we need to import this view to the current file to use this button I suppose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's a new button that I just added to HomeView, so we need to import this view to the current file to use this button I suppose
I supposed that if we use other buttons from HomeView then ens_banner_close_button should be available too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it. fixed too
|
||
self.home_1.just_fyi("Close the ENS banner") | ||
[home.home_button.double_click() for home in (self.home_1, self.home_2)] | ||
for key in self.drivers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if to replace the lines 155, 156. 157 by [home.ens_banner_close_button.click() for home in (self.home_1, self.home_2)] , will it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works. I just overcomplicated it for some reason :) will push the fix, thank you
9aa0944
to
c26ae1c
Compare
|
||
self.home_1.just_fyi("Close the ENS banner") | ||
[home.home_button.double_click() for home in (self.home_1, self.home_2)] | ||
[home.ens_banner_close_button.click() for home in (self.home_1, self.home_2)] | ||
[home.home_button.double_click() for home in (self.home_1, self.home_2)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like redudant home_button.double_click() I guess line 985 can be deleted
20% of end-end tests have passed
Failed tests (8)Click to expandSingle device tests:
Class TestChatMediumMultipleDevice:
Passed tests (2)Click to expandClass TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestChatKeycardMentionsMediumMultipleDevice:
|
480ddf2
to
78b0bf0
Compare
PR adds:
xfail
mark for a sticker testSelect token
button in Uniswap