-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade async storage version #13846
upgrade async storage version #13846
Conversation
Jenkins Builds
|
100% of end-end tests have passed
Not executed tests (1)Passed tests (86)Click to expandClass TestOneToOneChatMultipleSharedDevices:
Class TestCommandsMultipleDevicesMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
|
99% of end-end tests have passed
Not executed tests (1)Failed tests (1)Click to expandClass TestCommandsMultipleDevicesMerged:
Passed tests (85)Click to expandClass TestPublicChatBrowserOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
|
Tested briefly on IOS, can't see any regression. Tests are passed, therefore ready to go. |
dbf0ecf
to
9ac0901
Compare
fixes #13845
Summary
Upgrading AsyncStorage from https://www.npmjs.com/package/@react-native-community/async-storage to https://github.com/react-native-async-storage/async-storage because what we currently use has been deprecated.
Testing notes
Probably good to do a complete app test to make sure this did not break any existing functionality.
Platforms
Areas that maybe impacted
Maybe nothing, maybe everything
status: ready