fix some buttons are not responding after theme change #14811

Parveshdhull · 2023-01-17T19:22:47Z

Issue Cause

Chat was not closing on system theme change
As :close-chat and :navigate-to-chat both had :dispatch key, it was causing :merging-fx-with-common-keys error, due to unclosed chat
Models were not dismissed on theme change

status: ready

status-im-auto · 2023-01-17T19:25:30Z

Jenkins Builds

Click to see older builds (37)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`8cc5592`	#1	2023-01-17 19:25:30	~2 min	`ios`	📄`log`
✔️	`8cc5592`	#1	2023-01-17 19:26:12	~3 min	`tests`	📄`log`
✔️	`8cc5592`	#1	2023-01-17 19:30:53	~7 min	`android`	🤖`apk` 📲
✔️	`8cc5592`	#1	2023-01-17 19:31:47	~8 min	`android-e2e`	🤖`apk` 📲

✔️	`545f1e7`	#3	2023-01-17 19:50:37	~6 min	`tests`	📄`log`
✔️	`545f1e7`	#3	2023-01-17 19:53:41	~9 min	`ios`	📱`ipa` 📲
✔️	`545f1e7`	#3	2023-01-17 19:54:47	~10 min	`android-e2e`	🤖`apk` 📲
✔️	`545f1e7`	#3	2023-01-17 19:56:32	~12 min	`android`	🤖`apk` 📲

✔️	`bc1aab3`	#4	2023-01-18 12:31:24	~2 min	`tests`	📄`log`
✔️	`bc1aab3`	#4	2023-01-18 12:37:10	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`bc1aab3`	#4	2023-01-18 12:37:12	~7 min	`android`	🤖`apk` 📲
✔️	`bc1aab3`	#4	2023-01-18 12:46:26	~17 min	`ios`	📱`ipa` 📲

❌	`f08534e`	#5	2023-01-20 21:57:31	~2 min	`tests`	📄`log`

✔️	`1896f3a`	#6	2023-01-20 22:02:56	~2 min	`tests`	📄`log`
✔️	`1896f3a`	#6	2023-01-20 22:07:55	~7 min	`ios`	📱`ipa` 📲
✔️	`1896f3a`	#6	2023-01-20 22:08:06	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`1896f3a`	#6	2023-01-20 22:08:30	~7 min	`android`	🤖`apk` 📲

✔️	`81ab015`	#8	2023-01-20 23:11:16	~1 min	`tests`	📄`log`
✔️	`81ab015`	#8	2023-01-20 23:16:29	~7 min	`ios`	📱`ipa` 📲
✔️	`81ab015`	#8	2023-01-20 23:16:54	~7 min	`android`	🤖`apk` 📲
✔️	`81ab015`	#8	2023-01-20 23:17:33	~8 min	`android-e2e`	🤖`apk` 📲

✔️	`1c4e1b9`	#9	2023-01-23 07:49:53	~2 min	`tests`	📄`log`
✔️	`1c4e1b9`	#9	2023-01-23 07:54:18	~6 min	`ios`	📱`ipa` 📲
✔️	`1c4e1b9`	#9	2023-01-23 07:55:09	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`1c4e1b9`	#9	2023-01-23 07:55:15	~7 min	`android`	🤖`apk` 📲

✔️	`7987732`	#10	2023-01-23 08:26:14	~2 min	`tests`	📄`log`
✔️	`7987732`	#10	2023-01-23 08:30:57	~7 min	`ios`	📱`ipa` 📲
✔️	`7987732`	#10	2023-01-23 08:31:33	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`7987732`	#10	2023-01-23 08:31:53	~7 min	`android`	🤖`apk` 📲

✔️	`ee2bbf6`	#11	2023-01-23 14:23:17	~2 min	`tests`	📄`log`
✔️	`ee2bbf6`	#11	2023-01-23 14:28:10	~7 min	`ios`	📱`ipa` 📲
✔️	`ee2bbf6`	#11	2023-01-23 14:28:40	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ee2bbf6`	#11	2023-01-23 14:28:58	~7 min	`android`	🤖`apk` 📲

✔️	`2896fe3`	#12	2023-01-23 21:15:46	~3 min	`tests`	📄`log`
✔️	`2896fe3`	#12	2023-01-23 21:19:30	~7 min	`ios`	📱`ipa` 📲
✔️	`2896fe3`	#12	2023-01-23 21:21:16	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`2896fe3`	#12	2023-01-23 21:21:18	~8 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`679253f`	#13	2023-01-24 12:31:08	~2 min	`tests`	📄`log`
✔️	`679253f`	#13	2023-01-24 12:35:42	~7 min	`ios`	📱`ipa` 📲
✔️	`679253f`	#13	2023-01-24 12:36:57	~8 min	`android`	🤖`apk` 📲
✔️	`679253f`	#13	2023-01-24 12:37:01	~8 min	`android-e2e`	🤖`apk` 📲

✔️	`2f7b6bf`	#14	2023-01-24 14:56:54	~2 min	`tests`	📄`log`
✔️	`2f7b6bf`	#14	2023-01-24 15:02:06	~7 min	`ios`	📱`ipa` 📲
✔️	`2f7b6bf`	#14	2023-01-24 15:02:37	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`2f7b6bf`	#14	2023-01-24 15:02:53	~8 min	`android`	🤖`apk` 📲

status-im-auto · 2023-01-17T20:04:59Z

70% of end-end tests have passed

Total executed tests: 23
Failed tests: 7
Passed tests: 16

IDs of failed tests: 702732,702745,702851,702731,702808,702838,702843

Failed tests (7)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 41.807502297794116 percents `critical/chats/test_1_1_public_chats.py:1465: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:188: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Image of user in 1-1 chat is too different from template!` [[On profile picture failed due to #14718]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_pin_messages, id: 702731
Device 1: Wait for text element `Button` to be equal to `2` Device 1: Find `Button` by `xpath`: `//[@content-desc='pins-count']/android.widget.TextView` critical/chats/test_1_1_public_chats.py:1345: in test_1_1_chat_pin_messages chat.pinned_messages_count.wait_for_element_text("2", ../views/base_element.py:151: in wait_for_element_text text_element = self.find_element().text ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@content-desc='pins-count']/android.widget.TextView` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808

Device 1: Tap on found: Button
Device 1: Find ChatButton by accessibility id: start-group-chat-button

critical/chats/test_group_chat.py:248: in test_group_chat_offline_pn
    self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]],
../views/home_view.py:394: in create_group_chat
    chat_view = self.new_group_chat_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: ChatButton by accessibility id: `start-group-chat-button` is not found on the screen

[[mysterious issue when PNs are not fetched from offline,can not reproduce on real devices; needs investigation]]

Device sessions

Device 1:

Device 2:

Device 3:

Class TestGroupChatMediumMultipleDeviceNewUI:

1. test_group_chat_pin_messages, id: 702732

# STEP: Check pinned messages count and content
Device 1: Find Button by xpath: //*[@content-desc='pins-count']/android.widget.TextView

critical/chats/test_group_chat.py:370: in test_group_chat_pin_messages
    count = group_chat.pinned_messages_count.text
../views/base_element.py:208: in text
    return self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@content-desc='pins-count']/android.widget.TextView` is not found on the screen ; also Unexpected Alert is shown: 'Rendered more hooks than during the previous render.'

[[blocked by #14637]]

Device sessions

Device 1:

Device 2:

Class TestActivityCenterMultipleDevicePR:

1. test_activity_center_mentions_in_community_jump_to, id: 702851

Device 1: Find Button by xpath: //*[contains(@text, 'Winged Mediumvioletred Pe')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]
Device 1: Find Button by accessibility id: close-activity-center

medium/test_activity_center.py:247: in test_activity_center_mentions_in_community_jump_to
    self.home_1.handle_contact_request(username=self.default_username_2)
../views/home_view.py:363: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `close-activity-center` is not found on the screen

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 1: Looking for a message by text: hello Device 1: Find `TimeStampText` by `xpath`: `//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-timestamp']` `critical/test_public_chat_browsing.py:625: in test_community_message_send_check_timestamps_sender_username (sent_time_variants.join(','), timestamp)) 'list' object has no attribute 'join'` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_message_edit, id: 702843
Device 1: Find `SendMessageButton` by `accessibility id`: `send-message-button` Device 1: Tap on found: SendMessageButton `critical/test_public_chat_browsing.py:642: in test_community_message_edit self.errors.verify_no_errors() base_test_case.py:188: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message is not edited` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (16)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterMultipleDevicePR:

1. test_activity_center_decline_contact_request_no_pn, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mark_all_messages_as_read, id: 702842
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeeplinkOneDeviceNewUI:

1. test_public_chat_open_using_deep_link, id: 702776
Device sessions Device 1: Steps, video, logs
2. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 702774
Device sessions Device 1: Steps, video, logs
3. test_deep_link_open_user_profile, id: 702775
Device sessions Device 1: Steps, video, logs

Parveshdhull · 2023-01-18T09:26:58Z

maybe we should also improve safe-merge function, so that it will convert dispatch into dispatch-n, instead of throwing error merging-fx-with-common-keys

VolodLytvynenko · 2023-01-18T12:19:17Z

Hi @Parveshdhull could you resolve the conflicts, please?

src/status_im/events.cljs

flexsurfer · 2023-01-18T12:47:09Z

yeah this one is tricky one, just wondering what if won't reset root, in new code it should work, just use hot-reload trick instead

Parveshdhull · 2023-01-18T13:07:07Z

yeah this one is tricky one, just wondering what if won't reset root, in new code it should work, just use hot-reload trick instead

we can try, but not sure if it will work: https://wix.github.io/react-native-navigation/docs/style-theme#changing-theme-dynamically

flexsurfer · 2023-01-18T13:11:06Z

yeah this one is tricky one, just wondering what if won't reset root, in new code it should work, just use hot-reload trick instead

we can try, but not sure if it will work: https://wix.github.io/react-native-navigation/docs/style-theme#changing-theme-dynamically

we don't use RNN themes, so it won't work, but hot reload might work, we just need to force re-render entire react tree

Parveshdhull · 2023-01-18T13:13:49Z

tried hot reload, its working (apart from status bar icon, bottom bar colors, (easily fixable)). This is neat idea :)

Parveshdhull · 2023-01-18T13:18:17Z

@VladimrLitvinenko, thank you for picking up PR. Please can you pause testing, I am thinking of adding few more changes to this PR. I will ping you once PR will be ready for testing.

VolodLytvynenko · 2023-01-18T13:43:35Z

@VladimrLitvinenko, thank you for picking up PR. Please can you pause testing, I am thinking of adding few more changes to this PR. I will ping you once PR will be ready for testing.

Sure. Let me know when it is ready

Parveshdhull · 2023-01-23T08:32:38Z

Hi @VladimrLitvinenko, Thank you for your patience. PR is ready to be tested again.

Apart from #14780, please also test the behavior of status bar icon colors, and nav bar colors as per system theme changes and also app theme changes.
PR also remove the new-ui-toggle as it's not functional anymore, So please also test for regression for account creation and login.

Known issue

These changes might create this distorted app state on old screens while changing theme. It's fine for now, we need to re-implement these screens without the RNN theme. But if distortion happening on new screens, please let me know.

flexsurfer

nice

qoqobolo · 2023-01-23T13:15:22Z

Hi @Parveshdhull , thanks for the fixes!
There is an issue with the status bar icon colors on both Android and iOS, take a look, please.

ISSUE 1: Black font color of the status bar icons

Case 1:

Have your device in dark mode
Install Status

In this case, the status bar icons have a black font with a black background from the beginning.

Case 2:

Have your device in light mode
Install Status and create an account

You can see on the video, that in this case, the status bar looks okay during onboarding, but on the first Jump to screen icons get black with a black background.
The status bar gets also dark on other screens if you change the app theme to dark.

video_2023-01-23_12-32-06.mp4

On 14 sec you can also see that the Appearance title stays light when changing theme, but looks like a part of this known issue with old screens:

Known issue
These changes might create #12921 distorted app state on old screens while changing theme. It's fine for now, we need to re-implement these screens without the RNN theme. But if distortion happening on new screens, please let me know.

Parveshdhull · 2023-01-23T14:21:04Z

hi @qoqobolo, Thank you for testing the PR and finding this issue. Issue should be fixed now.

Also, yes Appearance color is expected as this still uses RNN theme.

qoqobolo · 2023-01-23T16:21:07Z

Thanks @Parveshdhull !

ISSUE 2: The status bar icons get white on the white background (or vice versa) if switch the mode while a community channel is open

Steps:

Switch the theme to dark on your device
Install Status
Create a community
Open a channel
Switch the mode to light on your device while the channel is opened
Actual result: status bar gets white with white icons

video_2023-01-23_17-10-59.mp4

Also, ISSUE 1 (Case 2) is still reproducible on iOS.

Steps:

Have your device in light mode
Install Status and go through the onboarding flow until the first Jump to screen
Actual result: fully black status bar

Parveshdhull · 2023-01-23T20:39:32Z

Hi @qoqobolo,

Issue 1: changing the status bar color without the re-initializing of app, is currently not working in ios.
We can also reproduce this behavior by opening and closing the shell screen(press jump-to).
Status bar icon color will remain the same in the both home-stack and shell screen.
Somewhat related issue: wix/react-native-navigation#5446

Issue 2: Currently we are not storing the ids of all opened screens, so on theme change we only change the status-bar icon color for the root screen. But once those screens closed and reopened the status bar color should be correct.

As Issue 1 looks a little not fixable(needs further research) and Issue 2 non blocker, I think we can skip them for now and log them separately. wdyt?

Parveshdhull · 2023-01-23T21:23:23Z

So, for ios, we are not able to change the status-bar icon color at runtime, but I made changes so that on login it should use the correct color.
Before Login Screens: Same as a system theme
After Login Screens: Same as app theme on most screens (except shell screen)

Please let me know if anything is not clear, It's a little confusing with so many edge cases. And thanks again for testing PR.

status-im-auto · 2023-01-24T10:45:49Z

0% of end-end tests have passed

Total executed tests: 10
Failed tests: 10
Passed tests: 0
Not executed tests: 15

IDs of not executed tests: 702730,702782,702731,702745,702813,702855,702733,702783,702784,702774,702775,702776,702807,702808,702846

IDs of failed tests: 702840,702732,702850,702851,702845,702841,702839,702842,702838,702843

Not executed tests (15)

Click to expand

Rerun not executed tests

Failed tests (10)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/test_public_chat_browsing.py:586: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
2. test_community_leave, id: 702845
Test setup failed: critical/test_public_chat_browsing.py:586: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
3. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/test_public_chat_browsing.py:586: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
4. test_community_message_delete, id: 702839
Test setup failed: critical/test_public_chat_browsing.py:586: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
5. test_community_mark_all_messages_as_read, id: 702842
Test setup failed: critical/test_public_chat_browsing.py:586: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 1: Find `Button` by `xpath`: `//[@text="Next"]` Device 1: Tap on found: Button Test setup failed: critical/test_public_chat_browsing.py:586: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element [[blocked by #14797]]** Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
7. test_community_message_edit, id: 702843
Test setup failed: critical/test_public_chat_browsing.py:586: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element [[blocked by #14797]]*

Class TestGroupChatMediumMultipleDeviceNewUI:

1. test_group_chat_pin_messages, id: 702732

Device 1: Find Button by xpath: //*[@text="Next"]
Device 1: Tap on found: Button

Test setup failed: critical/chats/test_group_chat.py:289: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,))))
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:35: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:204: in create_user
    self.chats_tab.wait_for_visibility_of_element(30)
../views/base_element.py:134: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element

[[blocked by #14637]]

Device sessions

Device 1:

Device 2:

Class TestActivityCenterMultipleDevicePR:

1. test_activity_center_decline_contact_request_no_pn, id: 702850
Device 2: Find `Button` by `xpath`: `//[@text="Next"]` Device 2: Tap on found: Button Test setup failed: medium/test_activity_center.py:192: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, **self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_mentions_in_community_jump_to, id: 702851
Test setup failed: medium/test_activity_center.py:192: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user,), (self.device_2.create_user,)))) /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:35: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:204: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:134: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element [[blocked by #14798]]*

qoqobolo · 2023-01-24T11:13:54Z

As Issue 1 looks a little not fixable(needs further research) and Issue 2 non blocker, I think we can skip them for now and log them separately. wdyt?

Sure, I'll log them in one new low-prio issue just to track them.
Thanks for the explanation! Overall, everything looks good to me.

But one more thing: e2e are failing because the Enable Notifications and Welcome to Status screens are back. Looks like they accidentally snuck into the code again :) Or it's on purpose? Can you clarify please?

video_2023-01-24_12-08-11.mp4

Parveshdhull · 2023-01-24T12:36:06Z

Looks like they accidentally snuck into the code again :) Or it's on purpose? Can you clarify please?

I also removed new-ui-toggle in PR and that accidentally exposed the else part(welcome screen).
Removed it, thank you for noticing.

status-im-auto · 2023-01-24T13:34:17Z

84% of end-end tests have passed

Total executed tests: 25
Failed tests: 4
Passed tests: 21

IDs of failed tests: 702838,702851,702745,702732

Failed tests (4)

Click to expand

Rerun failed tests

Class TestGroupChatMediumMultipleDeviceNewUI:

1. test_group_chat_pin_messages, id: 702732

Device 1: Looking for a pinned by message with text: Message 4
Device 2: Find `Button` by `xpath`: `//*[@content-desc='pins-count']//android.widget.TextView`

critical/chats/test_group_chat.py:371: in test_group_chat_pin_messages
    count = group_chat.pinned_messages_count.text
../views/base_element.py:208: in text
    return self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[@content-desc='pins-count']//android.widget.TextView` is not found on the screen

[[blocked by #14637]]

Device sessions

Device 1:

Device 2:

Class TestActivityCenterMultipleDevicePR:

1. test_activity_center_mentions_in_community_jump_to, id: 702851

Device 1: Find Button by xpath: //*[contains(@text, 'Long Minor Glassfrog')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]
Device 1: Find Button by accessibility id: close-activity-center

medium/test_activity_center.py:248: in test_activity_center_mentions_in_community_jump_to
    self.home_1.handle_contact_request(username=self.default_username_2)
../views/home_view.py:363: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `close-activity-center` is not found on the screen

[[blocked by #14798]]

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:628: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:850: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:134: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by #14797]]

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 41.807502297794116 percents `critical/chats/test_1_1_public_chats.py:1203: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:188: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Image of user in 1-1 chat is too different from template!` [[On profile picture failed due to #14718]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (21)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestDeeplinkOneDeviceNewUI:

1. test_deep_link_open_user_profile, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_public_chat_open_using_deep_link, id: 702776
Device sessions Device 1: Steps, video, logs
3. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 702774
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterMultipleDevicePR:

1. test_activity_center_decline_contact_request_no_pn, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mark_all_messages_as_read, id: 702842
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2023-01-24T13:34:53Z

Thanks @Parveshdhull !
I don't see any other issues besides the ones mentioned.
PR can be merged.

status-github-bot bot added this to REVIEW in Pipeline for QA Jan 17, 2023

Parveshdhull requested review from flexsurfer, siddarthkay and jo-mut January 17, 2023 19:27

Parveshdhull self-assigned this Jan 17, 2023

Parveshdhull added the request-manual-qa label Jan 17, 2023

Parveshdhull moved this from REVIEW to E2E Tests in Pipeline for QA Jan 17, 2023

Parveshdhull force-pushed the fix/theme-change-buttons branch from 36e24c3 to 545f1e7 Compare January 17, 2023 19:43

VolodLytvynenko self-assigned this Jan 18, 2023

status-github-bot bot moved this from E2E Tests to TO REBASE in Pipeline for QA Jan 18, 2023

Parveshdhull force-pushed the fix/theme-change-buttons branch from 545f1e7 to bc1aab3 Compare January 18, 2023 12:28

J-Son89 approved these changes Jan 18, 2023

View reviewed changes

flexsurfer reviewed Jan 18, 2023

View reviewed changes

src/status_im/events.cljs Outdated Show resolved Hide resolved

Parveshdhull marked this pull request as draft January 18, 2023 13:20

Parveshdhull force-pushed the fix/theme-change-buttons branch from bc1aab3 to f08534e Compare January 20, 2023 21:55

Parveshdhull marked this pull request as ready for review January 20, 2023 21:56

Parveshdhull force-pushed the fix/theme-change-buttons branch 3 times, most recently from 9758e04 to 81ab015 Compare January 20, 2023 23:08

Parveshdhull moved this from TO REBASE to E2E Tests in Pipeline for QA Jan 21, 2023

Parveshdhull force-pushed the fix/theme-change-buttons branch from 1c4e1b9 to 7987732 Compare January 23, 2023 08:23

Parveshdhull requested a review from flexsurfer January 23, 2023 08:32

flexsurfer approved these changes Jan 23, 2023

View reviewed changes

jo-mut approved these changes Jan 23, 2023

View reviewed changes

Parveshdhull mentioned this pull request Jan 23, 2023

Some of app elements (e.g Profile menu items, trans history list items etc) periodically stop responding on Android app #14020

Closed

qoqobolo assigned qoqobolo and unassigned VolodLytvynenko Jan 23, 2023

qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA Jan 23, 2023

Parveshdhull force-pushed the fix/theme-change-buttons branch from 7987732 to ee2bbf6 Compare January 23, 2023 14:20

Parveshdhull force-pushed the fix/theme-change-buttons branch from ee2bbf6 to 2896fe3 Compare January 23, 2023 21:12

qoqobolo added the Tested - OK label Jan 24, 2023

qoqobolo moved this from IN TESTING to MERGE in Pipeline for QA Jan 24, 2023

fix some buttons are not responding after theme change

2f7b6bf

Parveshdhull force-pushed the fix/theme-change-buttons branch from 679253f to 2f7b6bf Compare January 24, 2023 14:54

Parveshdhull merged commit 080b13c into develop Jan 24, 2023

Pipeline for QA automation moved this from MERGE to DONE Jan 24, 2023

Parveshdhull deleted the fix/theme-change-buttons branch January 24, 2023 14:58

Parveshdhull mentioned this pull request Mar 6, 2023

Updating status bar using merge options not working on iOS #15260

Open

Parveshdhull mentioned this pull request Apr 25, 2024

Changing theme not working properly #19794

Closed

fix some buttons are not responding after theme change #14811

fix some buttons are not responding after theme change #14811

Conversation

Parveshdhull commented Jan 17, 2023 • edited

Issue Cause

status-im-auto commented Jan 17, 2023 • edited

Jenkins Builds

status-im-auto commented Jan 17, 2023

70% of end-end tests have passed

Failed tests (7)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestGroupChatMediumMultipleDeviceNewUI:

Class TestActivityCenterMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Passed tests (16)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestDeeplinkOneDeviceNewUI:

Parveshdhull commented Jan 18, 2023

VolodLytvynenko commented Jan 18, 2023

flexsurfer commented Jan 18, 2023

Parveshdhull commented Jan 18, 2023

flexsurfer commented Jan 18, 2023

Parveshdhull commented Jan 18, 2023 • edited

Parveshdhull commented Jan 18, 2023

VolodLytvynenko commented Jan 18, 2023

Parveshdhull commented Jan 23, 2023

Known issue

flexsurfer left a comment

Choose a reason for hiding this comment

qoqobolo commented Jan 23, 2023 • edited

ISSUE 1: Black font color of the status bar icons

Parveshdhull commented Jan 23, 2023 • edited

qoqobolo commented Jan 23, 2023

ISSUE 2: The status bar icons get white on the white background (or vice versa) if switch the mode while a community channel is open

Parveshdhull commented Jan 23, 2023

Parveshdhull commented Jan 23, 2023

status-im-auto commented Jan 24, 2023

0% of end-end tests have passed

Not executed tests (15)

Failed tests (10)

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMediumMultipleDeviceNewUI:

Class TestActivityCenterMultipleDevicePR:

qoqobolo commented Jan 24, 2023

Parveshdhull commented Jan 24, 2023

status-im-auto commented Jan 24, 2023

84% of end-end tests have passed

Failed tests (4)

Class TestGroupChatMediumMultipleDeviceNewUI:

Class TestActivityCenterMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (21)

Class TestCommunityOneDeviceMerged:

Class TestDeeplinkOneDeviceNewUI:

Class TestActivityCenterMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

qoqobolo commented Jan 24, 2023

Parveshdhull commented Jan 17, 2023 •

edited

status-im-auto commented Jan 17, 2023 •

edited

Parveshdhull commented Jan 18, 2023 •

edited

qoqobolo commented Jan 23, 2023 •

edited

Parveshdhull commented Jan 23, 2023 •

edited