Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component - URL Preview #15607

Merged
merged 1 commit into from
Apr 11, 2023
Merged

New component - URL Preview #15607

merged 1 commit into from
Apr 11, 2023

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Apr 10, 2023

Fixes #15592

Summary

This PR implements the URL Preview component.

Light mode preview Dark mode preview

Review notes

  • Please, if you have access to iOS, check that the component renders correctly.
  • The red border around the icon has been reported in issue Clear icon is tinted incorrectly #15606
  • This PR is the first in a series of PRs related to URL Previews.
  • The loading state doesn't have a spinning icon on purpose. This will be done separately (issue yet to be created).

Platforms

  • Android
  • iOS

status: ready

@ilmotta ilmotta added the E:Mobile URL Preview MVP URL Preview feature label Apr 10, 2023
@ilmotta ilmotta self-assigned this Apr 10, 2023
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 10, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Apr 10, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 705d071 #1 2023-04-10 11:32:54 ~5 min tests 📄log
✔️ 705d071 #1 2023-04-10 11:34:28 ~7 min ios 📱ipa 📲
✔️ 705d071 #1 2023-04-10 11:35:12 ~8 min android-e2e 🤖apk 📲
✔️ 705d071 #1 2023-04-10 11:35:19 ~8 min android 🤖apk 📲
✔️ 2f5deee #2 2023-04-11 00:53:21 ~5 min tests 📄log
✔️ 2f5deee #2 2023-04-11 00:55:24 ~7 min android-e2e 🤖apk 📲
✔️ 2f5deee #2 2023-04-11 00:55:37 ~8 min ios 📱ipa 📲
✔️ 2f5deee #2 2023-04-11 00:55:48 ~8 min android 🤖apk 📲

Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Attaching screenshots for iOS.

Light mode preview Dark mode preview

Copy link
Member

@OmarBasem OmarBasem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renders correctly on iOS 👍

Copy link
Contributor

@ulisesmac ulisesmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good 👍

[rn/touchable-opacity
{:on-press on-press
:style style/clear-button-container
:hit-slop {:top 3 :right 3 :bottom 3 :left 3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good 👍
Some components are small and this seems useful!

@ilmotta ilmotta force-pushed the feat/new-url-preview-component branch from 705d071 to 2f5deee Compare April 11, 2023 00:47
@ilmotta ilmotta merged commit bfc7a2d into develop Apr 11, 2023
Pipeline for QA automation moved this from REVIEW to DONE Apr 11, 2023
@ilmotta ilmotta deleted the feat/new-url-preview-component branch April 11, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile URL Preview MVP URL Preview feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create quo component URL Preview
7 participants