Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mention text overlaying message text when mention is added during message editing (Android) #15778

Merged
merged 3 commits into from
May 3, 2023

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Apr 28, 2023

fixes #15770

A simple and straightforward way of fixing it is to force to render the message when it got edited — it is achieved here by adding a key.

Testing notes

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 28, 2023
@alwx alwx self-assigned this Apr 28, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Apr 28, 2023

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b44b60e #1 2023-04-28 16:15:10 ~6 min tests 📄log
✔️ b44b60e #1 2023-04-28 16:15:41 ~7 min ios 📱ipa 📲
✔️ b44b60e #1 2023-04-28 16:16:26 ~7 min android-e2e 🤖apk 📲
✔️ b44b60e #1 2023-04-28 16:16:37 ~8 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dbc557a #2 2023-05-02 12:59:38 ~6 min ios 📱ipa 📲
✔️ dbc557a #2 2023-05-02 13:00:46 ~7 min android 🤖apk 📲
✔️ dbc557a #2 2023-05-02 13:00:50 ~7 min android-e2e 🤖apk 📲
✔️ dbc557a #2 2023-05-02 13:00:52 ~7 min tests 📄log
✔️ 214ead4 #3 2023-05-03 16:14:03 ~6 min android-e2e 🤖apk 📲
✔️ 214ead4 #3 2023-05-03 16:14:05 ~6 min android 🤖apk 📲
✔️ 214ead4 #3 2023-05-03 16:14:10 ~6 min tests 📄log
✔️ 214ead4 #3 2023-05-03 16:14:19 ~7 min ios 📱ipa 📲

@VolodLytvynenko VolodLytvynenko moved this from REVIEW to E2E Tests in Pipeline for QA May 3, 2023
@pavloburykh pavloburykh moved this from E2E Tests to IN TESTING in Pipeline for QA May 3, 2023
@pavloburykh pavloburykh self-assigned this May 3, 2023
@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 30
Failed tests: 2
Passed tests: 28
IDs of failed tests: 702850,702838 

Failed tests (2)

Click to expand
  • Rerun failed tests

  • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find `Button` by `accessibility id`: `close-activity-center`
    Device 2: Tap on found: Button

    medium/test_activity_center.py:73: in test_activity_center_contact_request_decline
        self.errors.verify_no_errors()
    base_test_case.py:184: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Username is not shown on 'Add contact' page after entering valid public key 
    

    [[Blocked by 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello

    critical/test_public_chat_browsing.py:410: in test_community_message_send_check_timestamps_sender_username
        channel.verify_message_is_under_today_text(message, self.errors)
    ../views/chat_view.py:927: in verify_message_is_under_today_text
        message_element.wait_for_visibility_of_element()
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element 
    

    [[blocked by 14797]]

    Device sessions

    Passed tests (28)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @alwx thanx for the fix. Tested and ready for merge.

    @pavloburykh pavloburykh moved this from IN TESTING to MERGE in Pipeline for QA May 3, 2023
    @alwx alwx merged commit 4774b0f into develop May 3, 2023
    @alwx alwx deleted the bugfix/15770 branch May 3, 2023 16:26
    Pipeline for QA automation moved this from MERGE to DONE May 3, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Mention text overlays message text when mention is added during message editing (Android)
    4 participants