Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "Rendered more hooks than during the previous render" error on closing group chat/communty channel #16145

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Fix for "Rendered more hooks than during the previous render" error on closing group chat/communty channel #16145

merged 3 commits into from
Jun 2, 2023

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Jun 2, 2023

Fixes #16140

Platforms

  • Android
  • iOS

status: ready

@alwx alwx requested review from flexsurfer and ilmotta June 2, 2023 10:24
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jun 2, 2023
@alwx alwx requested a review from briansztamfater June 2, 2023 10:24
flexsurfer
flexsurfer approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@flexsurfer flexsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please explain how it works?

@status-im-auto
Copy link
Member

status-im-auto commented Jun 2, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c01f842 #1 2023-06-02 10:30:24 ~6 min ios 📱ipa 📲
❌ c01f842 #1 2023-06-02 10:31:26 ~7 min tests 📄log
✔️ c01f842 #1 2023-06-02 10:33:28 ~9 min android 🤖apk 📲
✔️ c01f842 #1 2023-06-02 10:33:57 ~9 min android-e2e 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 52338e6 #2 2023-06-02 10:57:07 ~5 min ios 📱ipa 📲
✔️ 52338e6 #2 2023-06-02 10:59:11 ~7 min android 🤖apk 📲
✔️ 52338e6 #2 2023-06-02 10:59:58 ~8 min android-e2e 🤖apk 📲
✔️ 52338e6 #2 2023-06-02 11:02:47 ~11 min tests 📄log
✔️ d7f0128 #3 2023-06-02 13:27:41 ~5 min android 🤖apk 📲
✔️ d7f0128 #3 2023-06-02 13:28:32 ~6 min ios 📱ipa 📲
✔️ d7f0128 #3 2023-06-02 13:28:33 ~6 min android-e2e 🤖apk 📲
✔️ d7f0128 #3 2023-06-02 13:30:13 ~8 min tests 📄log

@churik churik moved this from REVIEW to E2E Tests in Pipeline for QA Jun 2, 2023
@pavloburykh pavloburykh moved this from E2E Tests to IN TESTING in Pipeline for QA Jun 2, 2023
@pavloburykh pavloburykh self-assigned this Jun 2, 2023
@status-im-auto
Copy link
Member

73% of end-end tests have passed

Total executed tests: 33
Failed tests: 9
Passed tests: 24

IDs of failed tests: 702732,702745,702730,702782,702894,702783,702731,702808,702838

Failed tests (9)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732

    Device 1: Looking for a pinned message by text: Message 2
    Device 1: Find `Button` by `xpath`: `//*[@content-desc='pinned-messages-menu']//*[starts-with(@text,'Message 2')]` 

    critical/chats/test_group_chat.py:307: in test_group_chat_pin_messages
    self.chats[0].pinned_messages_list.message_element_by_text(self.message_2).click_inside_element_by_coordinate()
../views/base_element.py:328: in click_inside_element_by_coordinate
    location, size = self.get_element_coordinates()
../views/base_element.py:266: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@content-desc='pinned-messages-menu']//*[starts-with(@text,'Message 2')]` is not found on the screen



    Device sessions

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:258: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 message from new member PN was not fetched from offline



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 2: Tap on found: SendMessageButton
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:748: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not received in 1-1 chat after user unblock!



    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Looking for a message by text: hello
    Device 2: Find TimeStampText by xpath: //*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp'] 

    critical/chats/test_1_1_public_chats.py:1045: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    timestamp = self.chat_2.chat_element_by_text(messages[0]).timestamp
../views/chat_view.py:161: in timestamp
    return TimeStampText(self.driver, self.locator).text
../views/base_element.py:209: in text
    return self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: TimeStampText by xpath: `//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp']` is not found on the screen



    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730

    Device 1: Long press on ChatElementByText until expected element is shown
    Device 1: Find Button by accessibility id: emoji-picker-2 

    critical/chats/test_1_1_public_chats.py:869: in test_1_1_chat_message_reaction
    self.chat_1.set_reaction(message_from_sender)
../views/chat_view.py:1012: in set_reaction
    element.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `emoji-picker-2` is not found on the screen



    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Long press on Button until expected element is shown
    Device 1: Find Button by xpath: //*[@text="Reply"] 

    critical/chats/test_1_1_public_chats.py:896: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_1.quote_message(emoji_unicode)
../views/chat_view.py:995: in quote_message
    self.reply_message_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="Reply"]` is not found on the screen



    Device sessions

    4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1230: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!



    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731

    Device 1: Wait for text element Button to be equal to 2
    Device 1: Find Button by xpath: //*[@content-desc='pins-count']//android.widget.TextView 

    critical/chats/test_1_1_public_chats.py:952: in test_1_1_chat_pin_messages
    chat.pinned_messages_count.wait_for_element_text("2",
../views/base_element.py:152: in wait_for_element_text
    text_element = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@content-desc='pins-count']//android.widget.TextView` is not found on the screen



    Device sessions

    Passed tests (24)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_mentions_push_notification, id: 702786
    Device sessions

    6. test_community_leave, id: 702845
    Device sessions

    7. test_community_unread_messages_badge, id: 702841
    Device sessions

    8. test_community_message_delete, id: 702839
    Device sessions

    9. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @alwx Thanx for the fix. Let's merge it.

    @pavloburykh pavloburykh moved this from IN TESTING to MERGE in Pipeline for QA Jun 2, 2023
    @alwx alwx merged commit 39ea12c into develop Jun 2, 2023
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE Jun 2, 2023
    @alwx alwx deleted the bugfix/16140 branch June 2, 2023 13:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    Assignees

    @alwx alwx

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    "Rendered more hooks than during the previous render" error on closing group chat/communty channel
    5 participants
    @alwx @status-im-auto @pavloburykh @ilmotta @flexsurfer