Update navigation bar to support dark mode #16762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexsurfer
approved these changes
Jul 24, 2023
Jenkins BuildsClick to see older builds (12)
|
J-Son89
reviewed
Jul 24, 2023
| {:position :absolute | ||
| :top 0 | ||
| :left 0 | ||
| :right 0 | ||
| :height navigation-bar-height | ||
| :background-color (colors/theme-colors colors/white-opa-70 :transparent) | ||
| :background-color (colors/theme-colors colors/white-opa-70 colors/neutral-100-opa-70) |
There was a problem hiding this comment.
while you're making changes here can you update this component to use quo2.theme with-theme HOC and then pass in theme as a 3rd param. e,g
(defn background-view [theme]
{:position :absolute
:top 0
:left 0
:right 0
:height navigation-bar-height
:background-color (colors/theme-colors colors/white-opa-70 colors/neutral-100-opa-70 theme)
44% of end-end tests have passedNot executed tests (3)Failed tests (20)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (16)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
rasom
approved these changes
Jul 24, 2023
vkjr
approved these changes
Jul 24, 2023
|
@J-Son89 done! |
J-Son89
approved these changes
Jul 25, 2023
78% of end-end tests have passedNot executed tests (3)Failed tests (8)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Passed tests (28)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
|
|
hi, @Francesca-G could you check if the top bar is suitable on the dark mode? No issues from my side |
Francesca-G
reviewed
Jul 25, 2023
There was a problem hiding this comment.
@VolodLytvynenko the blur doesn't look right (see screenshots).
I'm aware that the blur on Android is a known issue but I tested it too.
iOS
Android
Hope this helps!
@Francesca-G. That's interesting. The bar looks different for you. This is how it looks for me: IOS: It seems that our builds are different. Could you please check if the previous PR build was removed to avoid the current last PR build installation over the previous one? If it does not help, could you provide the model of devices you use? |
Francesca-G
reviewed
Jul 25, 2023
There was a problem hiding this comment.
@VolodLytvynenko thanks for helping me fix the builds, it was a problem on my side!
Here's the Figma frame with the design review
@Francesca-G thank you for the feedback! Hi @alwx |
andresceballosm
pushed a commit
to andresceballosm/status-mobile
that referenced
this pull request
Aug 6, 2023
* Dark mode top bar * Fixes * Style fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes nav bar look properly with dark mode.
Platforms
Areas that maybe impacted
Functional
status: ready