Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: getting stuck on the "Keys saved" randomly #16816

Merged
merged 2 commits into from
Aug 1, 2023
Merged

fixed: getting stuck on the "Keys saved" randomly #16816

merged 2 commits into from
Aug 1, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Jul 31, 2023

Summary

After this PR, the issue of getting stuck during the creation of a new profile when the screen shows 'Keys saved' should be resolved.

relate comment
relate PR for status-go

Platforms

  • Android
  • iOS

status: ready

@qfrank qfrank requested a review from siddarthkay July 31, 2023 08:15
@qfrank qfrank self-assigned this Jul 31, 2023
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jul 31, 2023
@siddarthkay
Copy link
Contributor

@status-im/mobile-qa : This PR is going to require some extensive testing :D

@status-im-auto
Copy link
Member

status-im-auto commented Jul 31, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e62a71f #1 2023-07-31 08:24:39 ~9 min ios 📱ipa 📲
✔️ e62a71f #1 2023-07-31 08:27:23 ~11 min tests 📄log
✔️ e62a71f #1 2023-07-31 08:27:59 ~12 min android-e2e 🤖apk 📲
✔️ e62a71f #1 2023-07-31 08:27:59 ~12 min android 🤖apk 📲
✔️ e056510 #3 2023-08-01 09:25:06 ~8 min android 🤖apk 📲
✔️ e056510 #3 2023-08-01 09:26:33 ~9 min ios 📱ipa 📲
✔️ e056510 #3 2023-08-01 09:27:32 ~10 min tests 📄log
✔️ e056510 #3 2023-08-01 09:28:00 ~11 min android-e2e 🤖apk 📲

@qoqobolo qoqobolo moved this from REVIEW to E2E Tests in Pipeline for QA Jul 31, 2023
@qoqobolo qoqobolo self-assigned this Jul 31, 2023
@qoqobolo qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA Jul 31, 2023
@status-im-auto
Copy link
Member

85% of end-end tests have passed

Total executed tests: 40
Failed tests: 6
Passed tests: 34

IDs of failed tests: 702732,703133,702851,703495,702783,702731

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Tap on found: Button
    Device 2: Find `EditBox` by `accessibility id`: `profile-title-input` 

    medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.create_user(second_user=True, username=new_username)
../views/sign_in_view.py:234: in create_user
    self.set_profile(username)
../views/sign_in_view.py:218: in set_profile
    self.profile_your_name_edit_box.set_value(username)
../views/base_element.py:352: in set_value
    self.find_element().set_value(value)
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: EditBox by accessibility id: `profile-title-input` is not found on the screen



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Delivered 

    critical/chats/test_1_1_public_chats.py:1379: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chat name is not shown after unmute



    Device sessions

    Passed tests (34)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    7. test_1_1_chat_edit_message, id: 702855
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    9. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_mentions_push_notification, id: 702786
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    12. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    @status-im-auto
    Copy link
    Member

    33% of end-end tests have passed

    Total executed tests: 3
Failed tests: 2
Passed tests: 1

    IDs of failed tests: 702851,703495

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Tap on found: Button
    Device 2: Find `Button` by `accessibility id`: `create-new-profile` 

    medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.create_user(second_user=True, username=new_username)
../views/sign_in_view.py:230: in create_user
    self.create_new_profile_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `create-new-profile` is not found on the screen



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chat name is not shown after unmute



    Device sessions

    Passed tests (1)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 2
Failed tests: 2
Passed tests: 0

    IDs of failed tests: 702851,703495

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Tap on found: Button
    Device 2: Find `Button` by `accessibility id`: `create-new-profile` 

    medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.create_user(second_user=True, username=new_username)
../views/sign_in_view.py:230: in create_user
    self.create_new_profile_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `create-new-profile` is not found on the screen



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chat name is not shown after unmute



    Device sessions

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Jul 31, 2023 •
    edited
    Loading

    @qfrank thanks a lot for the fix!
    We couldn't reproduce the issue after multiple attempts in different scenarios and on different devices.
    If it comes back, we will let you know.
    PR can be merged.

    @qoqobolo qoqobolo moved this from IN TESTING to Design review in Pipeline for QA Jul 31, 2023
    Francesca-G
    Francesca-G approved these changes Aug 1, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I didn't get stuck on the "Keys saved" and everything looked good.

    Follow up issue about the animation:
    There's a frame that shouldn't be there at the end of the key saving animation, as you can see after the key has been grabbed by the end and goes inside the device the particles appear once again at the end of the animation, for a couple of frames.

    RPReplay_Final1690874692.mp4

    The animation should end here:
    IMG_0292

    @Francesca-G Francesca-G moved this from Design review to MERGE in Pipeline for QA Aug 1, 2023
    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Aug 1, 2023

    There's a frame that shouldn't be there at the end of the key saving animation, as you can see after the key has been grabbed by the end and goes inside the device the particles appear once again at the end of the animation, for a couple of frames.

    Oops, this PR was not supposed to be reviewed by you @Francesca-G, I moved it to the wrong column out of habit, sorry 😅
    But that's cool that you found this issue with the animation, I'll log the follow-up.
    Thank you!

    @qfrank qfrank merged commit 99c1051 into develop Aug 1, 2023
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE Aug 1, 2023
    @qfrank qfrank deleted the fix/stuck_on_keys_saved branch August 1, 2023 10:23
    @qoqobolo qoqobolo mentioned this pull request Aug 1, 2023
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @siddarthkay siddarthkay siddarthkay approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    Assignees

    @qfrank qfrank

    @qoqobolo qoqobolo

    Labels
    followup required request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    None yet
    5 participants
    @qfrank @siddarthkay @status-im-auto @qoqobolo @Francesca-G