use new API for ens name registration #17127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (55)
|
flexsurfer
reviewed
Aug 28, 2023
49% of end-end tests have passedFailed tests (22)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Passed tests (21)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
flexsurfer
approved these changes
Aug 28, 2023
Parveshdhull
approved these changes
Aug 28, 2023
qfrank
force-pushed
the
feat/sync_ens_name
branch
from
37943f1
to
ffdcd3d
Compare
yqrashawn
approved these changes
Aug 29, 2023
|
Hi @qfrank could you please rebase the PR? Thanx |
qfrank
force-pushed
the
feat/sync_ens_name
branch
from
ffdcd3d
to
c916684
Compare
done! @VolodLytvynenko |
67% of end-end tests have passedFailed tests (14)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Passed tests (29)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
done! hope we merge this soon @pavloburykh |
|
oh, no, i found another bug ...
should i fix it in this PR? i believe it's not relate to my PR, but maybe it's brought by the rebasing of status-go @pavloburykh |
@qfrank for sure it is brought by status-go rebasing. We need to fix it in this PR as we cannot introduce broken status-go to our develop. Thank you for catching those issues. |
qfrank
force-pushed
the
feat/sync_ens_name
branch
from
e4e3944
to
87048f5
Compare
should be fixed now 🙂 |
|
@qfrank thank you for the fixes. Unfortunately there is a new issue ISSUE 3 User gets stucked on Sign in by syncing screen after scanning sync QR codeSteps:
Actual result: Device 2 gets stucked on Sign in by syncing screen. Unable to perform syncing. scan_failed.mp4 |
74% of end-end tests have passedFailed tests (11)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (32)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
the fix coming soon |
qfrank
force-pushed
the
feat/sync_ens_name
branch
from
87048f5
to
c43f554
Compare
|
Thank you for the fixes. Unfortunately ISSUE 2 is still reproducible telegram-cloud-document-2-5197696690643023345.mp4Also there is a new issue ISSUE 4 Display name is not shown on Profile page after syncSteps:
Actual result: name field is empty
telegram-cloud-document-2-5197696690643023322.mp4I really don't want to block this PR from merging anymore, but we need to fix ISSUEs 1, 2, 3 in followups after merge as they seem to be PR related. I am waiting for e2e run, once it is finished I'll ping you up |
84% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (36)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
i'll take rest issues as follow up, let's merge now 🙂 |
|
Thank you @qfrank |
qfrank
force-pushed
the
feat/sync_ens_name
branch
from
c43f554
to
ad9ee3e
Compare
84% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Passed tests (36)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR mainly focused on following requirements:
ens_usernamesrather thansettings.usernamesanymorefixes #12891
Platforms
status: ready