Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quo2: keypair blur #17294

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Quo2: keypair blur #17294

merged 9 commits into from
Sep 25, 2023

Conversation

OmarBasem
Copy link
Member

fixes: #17068

This PR implements blur for Keypair component.

Designs

@OmarBasem OmarBasem self-assigned this Sep 15, 2023
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Sep 15, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 15, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ a52fda2 #1 2023-09-15 08:38:15 ~2 min tests 📄log
✔️ a52fda2 #1 2023-09-15 08:41:31 ~6 min android 🤖apk 📲
✔️ a52fda2 #1 2023-09-15 08:42:15 ~6 min android-e2e 🤖apk 📲
✔️ a52fda2 #1 2023-09-15 08:42:27 ~6 min ios 📱ipa 📲
✔️ c99fc3b #2 2023-09-15 08:48:57 ~6 min ios 📱ipa 📲
✔️ c99fc3b #2 2023-09-15 08:50:16 ~7 min android-e2e 🤖apk 📲
✔️ c99fc3b #2 2023-09-15 08:52:52 ~10 min android 🤖apk 📲
✔️ c99fc3b #2 2023-09-15 08:53:02 ~10 min tests 📄log
✔️ 099b4ac #3 2023-09-15 10:07:57 ~5 min android-e2e 🤖apk 📲
✔️ 099b4ac #3 2023-09-15 10:09:16 ~6 min ios 📱ipa 📲
✔️ 099b4ac #3 2023-09-15 10:10:30 ~7 min android 🤖apk 📲
✔️ 099b4ac #3 2023-09-15 10:12:37 ~9 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ ce1c7e8 #4 2023-09-25 04:04:31 ~2 min ios 📄log
❌ d51b738 #5 2023-09-25 04:07:10 ~2 min ios 📄log
✔️ d51b738 #5 2023-09-25 04:10:56 ~5 min android 🤖apk 📲
✔️ d51b738 #5 2023-09-25 04:13:10 ~8 min android-e2e 🤖apk 📲
✔️ d51b738 #5 2023-09-25 04:14:40 ~9 min tests 📄log

smohamedjavid
smohamedjavid reviewed Sep 15, 2023
View reviewed changes
src/quo2/components/wallet/keypair/view.cljs Outdated
[rn/view
{:style {:margin-left 8
:flex 1}}
[title-view (merge props {:selected? @selected?})]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assoc is the best choice here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smohamedjavid fixed it

src/quo2/components/wallet/keypair/view.cljs Show resolved Hide resolved
smohamedjavid
smohamedjavid approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@OmarBasem OmarBasem moved this from REVIEW to E2E Tests in Pipeline for QA Sep 15, 2023
@OmarBasem OmarBasem moved this from E2E Tests to Design review in Pipeline for QA Sep 15, 2023
@OmarBasem
Copy link
Member Author

@Francesca-G a design review please :)

Francesca-G
Francesca-G approved these changes Sep 15, 2023
View reviewed changes
Copy link

@Francesca-G Francesca-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Francesca-G Francesca-G moved this from Design review to MERGE in Pipeline for QA Sep 15, 2023
@J-Son89
Copy link
Member

J-Son89 commented Sep 15, 2023

@Francesca-G a design review please :)

Just a suggestion, we should hold off getting design reviews/QA for some reasonable time period, even if we have approvals. This pr is only open a few hours and some of our devs have not even started their day yet so it makes it harder to consider their requested changes once the review process has began. 1 dev's approval is the minimum requirement but we agreed upon the meetings with @Samyoul that we would leave a reasonable timeframe for others to review. (f I recall correctly)

@status-im-auto
Copy link
Member

77% of end-end tests have passed

Total executed tests: 43
Failed tests: 10
Passed tests: 33

IDs of failed tests: 702732,703133,703086,702894,702783,703503,703496,702786,702731,702808

Failed tests (10)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 1: Mention user user_2 in the chat
    Device 1: Find `ChatMessageInput` by `accessibility id`: `chat-message-input` 

    critical/test_public_chat_browsing.py:1134: in test_community_mentions_push_notification
    self.channel_1.mention_user(self.username_2)
../views/chat_view.py:1208: in mention_user
    self.chat_message_input.click_inside()
../views/chat_view.py:737: in click_inside
    location = self.find_element().location
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:286: in location
    old_loc = self._execute(Command.GET_ELEMENT_RECT)["value"]
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:395: in _execute
    return self._parent.execute(command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
    raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
 The element 'By.accessibilityId: chat-message-input' is not linked to the same object in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
E   Stacktrace:
E   io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.accessibilityId: chat-message-input' is not linked to the same object in DOM anymore
E   	at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:122)
E   	at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153)
E   	at io.appium.uiautomator2.handler.GetRect.safeHandle(GetRect.java:40)
E   	at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271)
E   	at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
E   	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
E   	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
E   	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911)
E   	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
E   	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
E   	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
E   	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
E   	at java.lang.Thread.run(Thread.java:919)

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until Text by accessibility id: community-description-text will be presented 

    critical/test_public_chat_browsing.py:1028: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Community element
E    New messages counter is not shown in community channel element



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:533: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect contacts number restored: 0 instead of 2
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    2. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline
E    Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: after unmute 

    critical/chats/test_1_1_public_chats.py:1457: in test_1_1_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message text 'should be muted' is not shown in chat preview after mute
E    Message 'should be muted' is not shown in chat for receiver after mute
E    New messages counter is not shown after unmute
E    Message text 'after unmute' is not shown in chat preview after unmute
E    Message 'after unmute' is not shown in chat for receiver after unmute



    Device sessions

    Passed tests (33)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    @J-Son89 J-Son89 requested a review from vkjr September 19, 2023 11:10
    @OmarBasem OmarBasem merged commit 1aadffd into develop Sep 25, 2023
    5 of 6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE Sep 25, 2023
    @OmarBasem OmarBasem deleted the quo2/keypair-blur branch September 25, 2023 04:32
    @jakubgs
    Copy link
    Member

    jakubgs commented Sep 25, 2023

    You really shouldn't merge PRs with merge conflicts that break iOS builds dude:

    status-mobile/ios/Podfile.lock

    Lines 775 to 783 in 1aadffd

    <<<<<<< HEAD
    <<<<<<< HEAD
    RNReanimated: 43adb0307a62c1ce9694f36f124ca3b51a15272a
    =======
    RNReanimated: 06a228c5a245ef7b5b03f0efc29d76ce4db9031c
    >>>>>>> c50db2fd2 (lint)
    =======
    RNReanimated: d0db0ee059c33381bca787a2193c27e52750ccaf
    >>>>>>> a52fda25e (lint)

    @OmarBasem
    Copy link
    Member Author

    OmarBasem commented Sep 25, 2023 •
    edited
    Loading

    @jakubgs my bad, apologies, made a PR #17406

    ibrkhalil pushed a commit that referenced this pull request Oct 1, 2023
    @OmarBasem @ibrkhalil
    Quo2: keypair blur (#17294)
    9c39745 
    * quo2: keypair blur
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @vkjr vkjr vkjr approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    Assignees

    @OmarBasem OmarBasem

    Labels
    None yet
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Follow up: Keypair
    8 participants
    @OmarBasem @status-im-auto @J-Son89 @jakubgs @vkjr @smohamedjavid @Francesca-G @flexsurfer