Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17383] migrate status-im.utils.types #17389

Merged
merged 2 commits into from
Sep 25, 2023
Merged

[#17383] migrate status-im.utils.types #17389

merged 2 commits into from
Sep 25, 2023

Conversation

flexsurfer
Copy link
Member

fixes #17383

@flexsurfer flexsurfer self-assigned this Sep 22, 2023
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Sep 22, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 22, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5e02cfd #1 2023-09-22 10:16:20 ~6 min android-e2e 🤖apk 📲
✔️ 5e02cfd #1 2023-09-22 10:17:25 ~7 min ios 📱ipa 📲
✔️ 5e02cfd #1 2023-09-22 10:19:13 ~8 min android 🤖apk 📲
✔️ 5e02cfd #1 2023-09-22 10:19:53 ~9 min tests 📄log
✔️ dcca75d #2 2023-09-22 10:34:26 ~6 min android-e2e 🤖apk 📲
✔️ dcca75d #2 2023-09-22 10:34:54 ~6 min android 🤖apk 📲
✔️ dcca75d #2 2023-09-22 10:34:57 ~6 min ios 📱ipa 📲
✔️ dcca75d #2 2023-09-22 10:37:29 ~9 min tests 📄log

@flexsurfer flexsurfer moved this from REVIEW to E2E Tests in Pipeline for QA Sep 22, 2023
smohamedjavid
smohamedjavid reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/status_im/utils/deprecated_types.cljs
@@ -1,4 +1,4 @@
(ns status-im.utils.types
(ns status-im.utils.deprecated-types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add metadata {:deprecated true :superseded-by "utils.transforms"} to this ns as an additional measure to prevent devs from using this namespace?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@status-im-auto
Copy link
Member

77% of end-end tests have passed

Total executed tests: 43
Failed tests: 10
Passed tests: 33

IDs of failed tests: 702809,702784,702732,702894,702783,703503,703496,702786,702731,702808

Failed tests (10)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 

    Test setup failed: critical/chats/test_1_1_public_chats.py:1357: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:377: in handle_contact_request
    self.close_activity_centre.wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Button by xpath: //*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]
    Device 2: Find Button by accessibility id: close-activity-center 

    Test setup failed: critical/chats/test_1_1_public_chats.py:1357: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:377: in handle_contact_request
    self.close_activity_centre.wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496 

    Test setup failed: critical/chats/test_1_1_public_chats.py:1357: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:377: in handle_contact_request
    self.close_activity_centre.wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/test_public_chat_browsing.py:1201: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 inline code is not displayed with markdown in community channel for the recipient (device 1)



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Passed tests (33)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    @flexsurfer flexsurfer merged commit b2cae88 into develop Sep 25, 2023
    6 checks passed
    Pipeline for QA automation moved this from E2E Tests to DONE Sep 25, 2023
    @flexsurfer flexsurfer deleted the feature/migrate_status-im.utils.types_#17383 branch September 25, 2023 07:32
    ibrkhalil pushed a commit that referenced this pull request Oct 1, 2023
    @flexsurfer @ibrkhalil
    [#17383] migrate status-im.utils.types (#17389)
    8c71238
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @smohamedjavid smohamedjavid smohamedjavid left review comments

    @qfrank qfrank qfrank approved these changes

    @yqrashawn yqrashawn yqrashawn approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    Assignees

    @flexsurfer flexsurfer

    Labels
    None yet
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    migrate status-im.utils.types
    6 participants
    @flexsurfer @status-im-auto @qfrank @yqrashawn @smohamedjavid @ibrkhalil