Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing/empty user-avatar in component previews #17430

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix: missing/empty user-avatar in component previews #17430

merged 1 commit into from
Sep 29, 2023

Conversation

yqrashawn
Copy link
Member

@yqrashawn yqrashawn commented Sep 27, 2023 •
edited
Loading

fixes #17208

Summary

why this happens:

  • we changed to using status-go to render user-avatar
  • we request status-go to render ident ring most of the time, :ring? default to true
  • params passed to user-avatar in most previews are {:display-name "..."} turns to {:display-name "..." :ring? true ...} (no pubkey or keyuid) when passed to status-go
  • pubkey or keyuid is required to render the ident ring
  • status-go refuse to render the avatar -> empty avatar

changes:

add mock image as :photo-path in

  1. system-message preview
  2. user-list preview
  3. top-nav preview
  4. toast preview

Testing notes

no need to test I guess? it only changes preview

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Sep 27, 2023
@yqrashawn yqrashawn force-pushed the fix/user-avatar-in-system-message-preview branch from a408e16 to c704cb8 Compare September 27, 2023 01:51
@yqrashawn yqrashawn changed the title fix: missing user-avatar in system message preview fix: missing user-avatar in component previews Sep 27, 2023
@yqrashawn yqrashawn mentioned this pull request Sep 27, 2023
Merged
@status-im-auto
Copy link
Member

status-im-auto commented Sep 27, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c704cb8 #2 2023-09-27 01:57:32 ~5 min android 🤖apk 📲
✔️ c704cb8 #2 2023-09-27 01:57:36 ~6 min ios 📱ipa 📲
✔️ c704cb8 #2 2023-09-27 01:59:32 ~7 min android-e2e 🤖apk 📲
✔️ c704cb8 #2 2023-09-27 02:01:05 ~9 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 06516b0 #3 2023-09-27 02:14:34 ~6 min ios 📱ipa 📲
✔️ 06516b0 #3 2023-09-27 02:18:56 ~10 min android-e2e 🤖apk 📲
✔️ 06516b0 #3 2023-09-27 02:19:00 ~10 min tests 📄log
✔️ 06516b0 #3 2023-09-27 02:19:00 ~10 min android 🤖apk 📲
✔️ af2d334 #4 2023-09-29 03:23:10 ~5 min android 🤖apk 📲
✔️ af2d334 #4 2023-09-29 03:24:47 ~7 min ios 📱ipa 📲
✔️ af2d334 #4 2023-09-29 03:27:23 ~9 min android-e2e 🤖apk 📲
✔️ af2d334 #4 2023-09-29 03:27:39 ~9 min tests 📄log

@yqrashawn yqrashawn force-pushed the fix/user-avatar-in-system-message-preview branch from c704cb8 to 06516b0 Compare September 27, 2023 02:08
@yqrashawn yqrashawn changed the title fix: missing user-avatar in component previews fix: missing/empty user-avatar in component previews Sep 27, 2023
ajayesivan
ajayesivan reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in the toast with user-avatar isn't vertically centered, though it might be outside the scope of this PR.

@yqrashawn
Copy link
Member Author

@ajayesivan yes, it's not in the scope of this PR
also it's not required https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=1503-32285&mode=design&t=HWo5gpr01S57J0Ik-4

@yqrashawn yqrashawn force-pushed the fix/user-avatar-in-system-message-preview branch from 06516b0 to af2d334 Compare September 29, 2023 03:17
@yqrashawn yqrashawn moved this from REVIEW to E2E Tests in Pipeline for QA Sep 29, 2023
@status-im-auto
Copy link
Member

49% of end-end tests have passed

Total executed tests: 43
Failed tests: 22
Passed tests: 21

IDs of failed tests: 702809,703194,702859,702732,702957,702840,703495,703086,702948,702894,702783,703503,703202,702786,702839,702838,702844,702843,702731,702808,702958,702841

Failed tests (22)

Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Find `Button` by `xpath`: `//*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']`
    Device 2: Tap on found: Button 

    Test setup failed: medium/test_activity_center.py:323: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: medium/test_activity_center.py:323: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chat name is not shown after unmute
E    New messages counter near chats tab button is 1 after unmute, but should be 2
E    Message text 'Chat is unmuted now' is not shown in chat preview after unmute



    Device sessions

    3. test_group_chat_reactions, id: 703202

    Device 2: Looking for a message by text: This is a test message to check some reactions.
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/chats/test_group_chat.py:242: in test_group_chat_reactions
    self.chats[1].set_reaction(message=message, emoji="thumbs-up")
../views/chat_view.py:1064: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:317: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    4. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:443: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1417: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline
E    Message status was not changed to Delivered, it's Sent after back up online!

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/test_public_chat_browsing.py:1218: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 italic text in asteric is not displayed with markdown in 1-1 chat for the recipient (device 2)



    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Looking for a message by text: closed community
    Device 2: Find BaseElement by xpath: //*[starts-with(@text,'closed community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View'] 

    critical/test_public_chat_browsing.py:1249: in test_community_hashtag_links_to_community_channels
    self.chat_2.chat_element_by_text(community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'closed community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    3. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1166: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, https://github.com//issues/17396]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    2. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    3. test_community_emoji_send_copy_paste_reply, id: 702840 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    4. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    5. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    6. test_community_message_delete, id: 702839 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    7. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']
    Device 2: Tap on found: Button 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    9. test_community_message_edit, id: 702843 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    10. test_community_unread_messages_badge, id: 702841 

    Test setup failed: critical/test_public_chat_browsing.py:597: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Device 1: Tap on found: Button
    Device 1: Swiping up 

    critical/test_public_chat_browsing.py:359: in test_community_discovery
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Element show-request-to-join-screen-button is different from expected template discovery_join_button.png!

    [[Request to Join Community button color issue: https://github.com//issues/17295]]

    Device sessions

    Passed tests (21)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @yqrashawn yqrashawn merged commit 1c31127 into develop Sep 29, 2023
    6 of 7 checks passed
    Pipeline for QA automation moved this from E2E Tests to DONE Sep 29, 2023
    @yqrashawn yqrashawn deleted the fix/user-avatar-in-system-message-preview branch September 29, 2023 07:30
    ibrkhalil pushed a commit that referenced this pull request Oct 1, 2023
    @yqrashawn @ibrkhalil
    fix: missing/empty user-avatar in component previews (#17430)
    bcabb0a
    clauxx pushed a commit that referenced this pull request Oct 3, 2023
    @yqrashawn @clauxx
    fix: missing/empty user-avatar in component previews (#17430)
    16467fe
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ajayesivan ajayesivan ajayesivan approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @clauxx clauxx Awaiting requested review from clauxx

    Assignees

    @yqrashawn yqrashawn

    Labels
    None yet
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    User Avatar missing in system-messages component Quo Preview
    3 participants
    @yqrashawn @status-im-auto @ajayesivan