Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👒 Update page top quo component to accommodate connected dapps anchor [19867] #19929

Conversation

shivekkhurana
Copy link
Contributor

fixes #19867

Summary

Add ability to show an action button to the page-nav component. For the case where an account switcher is visible (on account details page).

Review notes

The button is hidden behind a feature flag. Enable wallet-connect feature flag to see the changes.

Testing notes

This is a quo level change. There are 46 usages of this component. Unfortunately, all of them need to be tested for visual correctness. I'm sorry for that 😢

Below are all the files where the component is used. It should help you find the component in the app. Feel free to ping me on Discord if you are not able to find any listed component in the app.

Namespaces that need to be tested

-*- mode: grep; default-directory: "~/Wip/status-im/status-mobile/src/status_im/" -*-
Grep started at Tue May  7 22:03:07

find -H . -type d \( -path \*/SCCS -o -path \*/RCS -o -path \*/CVS -o -path \*/MCVS -o -path \*/.src -o -path \*/.svn -o -path \*/.git -o -path \*/.hg -o -path \*/.bzr -o -path \*/_MTN -o -path \*/_darcs -o -path \*/\{arch\} \) -prune -o \! -type d \( -name .\#\* -o -name \*.o -o -name \*\~ -o -name \*.bin -o -name \*.lbin -o -name \*.so -o -name \*.a -o -name \*.ln -o -name \*.blg -o -name \*.bbl -o -name \*.elc -o -name \*.lof -o -name \*.glo -o -name \*.idx -o -name \*.lot -o -name \*.fmt -o -name \*.tfm -o -name \*.class -o -name \*.fas -o -name \*.lib -o -name \*.mem -o -name \*.x86f -o -name \*.sparcf -o -name \*.dfsl -o -name \*.pfsl -o -name \*.d64fsl -o -name \*.p64fsl -o -name \*.lx64fsl -o -name \*.lx32fsl -o -name \*.dx64fsl -o -name \*.dx32fsl -o -name \*.fx64fsl -o -name \*.fx32fsl -o -name \*.sx64fsl -o -name \*.sx32fsl -o -name \*.wx64fsl -o -name \*.wx32fsl -o -name \*.fasl -o -name \*.ufsl -o -name \*.fsl -o -name \*.dxl -o -name \*.lo -o -name \*.la -o -name \*.gmo -o -name \*.mo -o -name \*.toc -o -name \*.aux -o -name \*.cp -o -name \*.fn -o -name \*.ky -o -name \*.pg -o -name \*.tp -o -name \*.vr -o -name \*.cps -o -name \*.fns -o -name \*.kys -o -name \*.pgs -o -name \*.tps -o -name \*.vrs -o -name \*.pyc -o -name \*.pyo \) -prune -o  -type f \( -iname view.cljs \) -exec grep --color=auto -i -nH --null -e quo/page-nav \{\} +
./contexts/settings/wallet/wallet_options/view.cljs�37:     [quo/page-nav
./contexts/settings/wallet/saved_addresses/view.cljs�29:     [quo/page-nav
./contexts/chat/group_details/view.cljs�125:     [quo/page-nav
./contexts/chat/group_create/view.cljs�85:      :header                 [quo/page-nav
./contexts/communities/actions/airdrop_addresses/view.cljs�55:       [quo/page-nav
./contexts/communities/actions/share_community/view.cljs�50:      [quo/page-nav
./contexts/communities/actions/channel_view_details/view.cljs�78:       [quo/page-nav
./contexts/communities/actions/addresses_for_permissions/view.cljs�144:       [quo/page-nav
./contexts/communities/actions/accounts_selection/view.cljs�84:     [quo/page-nav
./contexts/communities/actions/share_community_channel/view.cljs�30:        [quo/page-nav
./contexts/profile/settings/view.cljs�59:      [quo/page-nav
./contexts/profile/settings/screens/password/view.cljs�63:     [quo/page-nav
./contexts/profile/settings/screens/password/change_password/view.cljs�30:      [quo/page-nav
./contexts/profile/settings/screens/messages/view.cljs�17:   [quo/page-nav
./contexts/profile/settings/screens/messages/blocked_users/view.cljs�33:     [quo/page-nav
./contexts/profile/contact/share/view.cljs�35:      [quo/page-nav
./contexts/profile/edit/view.cljs�33:     [quo/page-nav
./contexts/profile/edit/bio/view.cljs�38:       [quo/page-nav
./contexts/profile/edit/accent_colour/view.cljs�29:         [quo/page-nav
./contexts/profile/edit/name/view.cljs�39:       [quo/page-nav
./contexts/wallet/save_address/view.cljs�50:      :header                   [quo/page-nav
./contexts/wallet/add_account/add_address_to_watch/view.cljs�129:          {:header [quo/page-nav
./contexts/wallet/add_account/create_account/view.cljs�115:          :header                   [quo/page-nav
./contexts/wallet/add_account/create_account/edit_derivation_path/view.cljs�69:         [quo/page-nav
./contexts/wallet/add_account/create_account/select_keypair/view.cljs�80:     [quo/page-nav
./contexts/wallet/add_account/create_account/new_keypair/keypair_name/view.cljs�42:      {:header [quo/page-nav
./contexts/wallet/add_account/create_account/new_keypair/check_your_backup/view.cljs�92:         [quo/page-nav
./contexts/wallet/add_account/create_account/new_keypair/backup_recovery_phrase/view.cljs�68:         [quo/page-nav
./contexts/wallet/add_account/create_account/import_private_key/view.cljs�97:       :header              [quo/page-nav
./contexts/wallet/common/screen_base/create_or_edit_account/view.cljs�28:     {:header                   [quo/page-nav
./contexts/wallet/common/account_switcher/view.cljs�25:    [quo/page-nav
./contexts/wallet/account/share_address/view.cljs�83:          [quo/page-nav
./contexts/wallet/send/transaction_confirmation/view.cljs�243:           :header                   [quo/page-nav
./contexts/wallet/send/transaction_progress/view.cljs�57:          :header                   [quo/page-nav
./contexts/preview/feature_flags/view.cljs�13:   [quo/page-nav
./contexts/preview/status_im/common/floating_button_page/view.cljs�23:        {:header              [quo/page-nav
./contexts/onboarding/enable_notifications/view.cljs�78:      [quo/page-nav
./contexts/onboarding/welcome/view.cljs�41:     [quo/page-nav
./contexts/onboarding/create_password/view.cljs�212:        [quo/page-nav
./contexts/onboarding/new_to_status/view.cljs�102:     [quo/page-nav
./contexts/onboarding/create_profile/view.cljs�110:       [quo/page-nav
./contexts/onboarding/syncing/progress/view.cljs�55:     [quo/page-nav {:type :no-title :background :blur}]
./contexts/syncing/setup_syncing/view.cljs�63:        [quo/page-nav
./contexts/syncing/syncing_devices_list/view.cljs�30:     [quo/page-nav
./common/enter_seed_phrase/view.cljs�171:          [quo/page-nav
./common/scroll_page/view.cljs�64:        [quo/page-nav

Grep finished with 46 matches found at Tue May  7 22:03:08

Platforms

  • Android
  • iOS

Areas that maybe impacted

  • All screens that use the page-nav component
  • App UI

Steps to test

  1. Enable wallet/wallet-connect feature flag

Before and after screenshots comparison

Before After
image image
Notice that the account switcher does not have any option for additional actions Design needs the dapp action

status: draft

@shivekkhurana shivekkhurana self-assigned this May 7, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 7, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 8, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
c3fc2bc #2 2024-05-08 07:35:08 ~3 min tests 📄log
✔️ c3fc2bc #2 2024-05-08 07:38:41 ~6 min android-e2e 🤖apk 📲
✔️ c3fc2bc #2 2024-05-08 07:39:02 ~7 min android 🤖apk 📲
✔️ c3fc2bc #2 2024-05-08 07:40:50 ~8 min ios 📱ipa 📲

@shivekkhurana
Copy link
Contributor Author

Superseded by #19934

Approved...

Pipeline for QA automation moved this from REVIEW to DONE May 8, 2024
@shivekkhurana shivekkhurana deleted the 19867--update-page-top-quo-component-to-accommodate-connected-dapps-anchor branch May 8, 2024 09:55
@alwx alwx self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

⚓ Update page-top Quo component to accommodate connected dapps anchor
3 participants