fix: use go 1.19 only for integration tests on Darwin #19965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
changed the title
Jenkins BuildsClick to see older builds (12)
|
jakubgs
reviewed
May 10, 2024
siddarthkay
force-pushed
the
investigate-integration-test-failure
branch
from
5ff1b5d
to
dda85c1
Compare
jakubgs
approved these changes
May 10, 2024
siddarthkay
force-pushed
the
investigate-integration-test-failure
branch
2 times, most recently
from
63a9fe7
to
d55f6be
Compare
cammellos
approved these changes
May 10, 2024
fixes #19802 Contract Tests are failing with missing symbols runtime error on `MacOS` after `golang` version was upgraded to 1.20 A simple hack fix such a case is to use `go 1.19` only to build the status-go library that is used specifically for these integration tests. Its ugly but it works and unblocks devs from running tests locally. - execute `make test-contract` on MacOS and it should not fail. not needed since this impacts only the integration tests. - macOS status: ready
siddarthkay
force-pushed
the
investigate-integration-test-failure
branch
from
d55f6be
to
11bbc5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19802
Summary
Contract Tests are failing with missing symbols runtime error on
MacOSaftergolangversion was upgraded to 1.20A simple hack fix such a case is to use
go 1.19only to build the status-go library that is used specifically for these integration tests.Its ugly but it works and unblocks devs from running tests locally.
Review Notes
make test-contracton MacOS and it should not fail.Testing notes
not needed since this impacts only the integration tests.
Platforms
status: ready