fix: white panel when the bottom sheet is launched #20167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (24)
|
flexsurfer
reviewed
May 24, 2024
| :overlay {:interceptTouchOutside true | ||
| :handleKeyboardEvents true}} | ||
| opts)}}))) | ||
| (let [theme (:theme opts) |
There was a problem hiding this comment.
thank you @jo-mut i've looked into show-overlay usages and I didn't find where we have :theme in opts, so probably it's better to remove it from code
flexsurfer
requested changes
May 24, 2024
|
we should move (rf/reg-fx :show-toasts
(fn [[view-id theme]]
(let [[rnn-status-bar nav-bar-color] (get-status-nav-color view-id theme)]
(show-overlay "toasts"
(assoc (options/statusbar-and-navbar-options nil rnn-status-bar nav-bar-color) |
jo-mut
force-pushed
the
bug/white-panel
branch
2 times, most recently
from
a943dc4
to
7d40f81
Compare
Screen_Recording_20240524_143631_Status_Debug.mp4 |
jo-mut
force-pushed
the
bug/white-panel
branch
6 times, most recently
from
9d95478
to
5dca94d
Compare
jo-mut
changed the title
flexsurfer
reviewed
May 24, 2024
| :overlay {:interceptTouchOutside true | ||
| :handleKeyboardEvents true}} | ||
| opts)}}))) | ||
| (let [theme (rf/sub [:theme])] |
There was a problem hiding this comment.
it's illegal, (rf/sub [:theme]) can't be used here , subscription can be used only in views, so you have to pass theme as parameter
jo-mut
changed the title
|
@flexsurfer I had missed your comment above am fixing that now |
flexsurfer
reviewed
May 27, 2024
| (show-overlay "toasts" | ||
| (assoc (options/statusbar-and-navbar-options nil rnn-status-bar nav-bar-color) | ||
| :overlay | ||
| {:interceptTouchOutside false}))))) |
There was a problem hiding this comment.
also this should keep {:interceptTouchOutside false} here
|
this is fixed here #20258 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20114
Summary
The white panel appears when the user initiates any action that launches the bottom sheet. This component does not have a theme property when I inspected it using re-frisk but we do have the global theme value of the app.
In this pr we get this global value of the applied theme and use that to determine which background needs to be applied on the navigation bar.
The issue is resolved
Screen_Recording_20240524_101819_Status_Debug.mp4
status: ready